[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..


IMPALA-5452: Rewrite test case to avoid 'pos'.

The original test case accessed the 'pos' field of nested
collections. The query results could vary when reloading
the data because the order of items within a nested
collection is not necessarily the same accross loads.

This patch reformulates the test to avoid 'pos'.

Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
Reviewed-on: http://gerrit.cloudera.org:8080/7708
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins
---
M 
testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1091/

-- 
To view, visit http://gerrit.cloudera.org:8080/7708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Alex Behm (Code Review) 
Alex Behm has uploaded a new patch set (#3).

Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..

IMPALA-5452: Rewrite test case to avoid 'pos'.

The original test case accessed the 'pos' field of nested
collections. The query results could vary when reloading
the data because the order of items within a nested
collection is not necessarily the same accross loads.

This patch reformulates the test to avoid 'pos'.

Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
---
M 
testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/7708/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change.

Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7708/1/testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
File 
testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test:

Line 666:  (select lead(l.l_linenumber) over (order by l.l_shipdate)
> I'm not sure that l_shipdate gives a total order. I think the below query g
You are right. I changed the query to have a total ordering (the PK of lineitem 
is (o_orderkey,l_linenum))


-- 
To view, visit http://gerrit.cloudera.org:8080/7708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Alex Behm (Code Review) 
Alex Behm has uploaded a new patch set (#2).

Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..

IMPALA-5452: Rewrite test case to avoid 'pos'.

The original test case accessed the 'pos' field of nested
collections. The query results could vary when reloading
the data because the order of items within a nested
collection is not necessarily the same accross loads.

This patch reformulates the test to avoid 'pos'.

Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
---
M 
testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/7708/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7708/1/testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
File 
testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test:

Line 666:  (select lead(l.l_linenumber) over (order by l.l_shipdate)
I'm not sure that l_shipdate gives a total order. I think the below query gives 
back a list of the lineitems belonging to orders where there were duplicate 
l_shipdates

  select o_custkey, l_orderkey, l_shipdate
  from tpch_parquet.lineitem join tpch_parquet.orders on o_orderkey = l_orderkey
  where o_custkey < 10 and l_orderkey in (
 select l_orderkey
 from tpch_parquet.lineitem join tpch_parquet.orders on o_orderkey = 
l_orderkey
 where o_custkey < 10 group by 1 having count(l_shipdate) != count(distinct 
l_shipdate))
  order by 1, 2, 3;


-- 
To view, visit http://gerrit.cloudera.org:8080/7708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Alex Behm (Code Review) 
Alex Behm has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7708

Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..

IMPALA-5452: Rewrite test case to avoid 'pos'.

The original test case accessed the 'pos' field of nested
collections. The query results could vary when reloading
the data because the order of items within a nested
collection is not necessarily the same accross loads.

This patch reformulates the test to avoid 'pos'.

Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
---
M 
testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/7708/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I32e47f0845da8b27652faaceae834e025ecff42a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm