[Impala-ASF-CR] IMPALA-5810: reduce minimum non-reservation memory

2017-08-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has abandoned this change.

Change subject: IMPALA-5810: reduce minimum non-reservation memory
..


Abandoned

absorbed by https://gerrit.cloudera.org/#/c/7678/

-- 
To view, visit http://gerrit.cloudera.org:8080/7710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I28d7cc4b969b5ac47890a673eb4a6716047d284d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-5810: reduce minimum non-reservation memory

2017-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5810: reduce minimum non-reservation memory
..


Patch Set 1:

works for me

-- 
To view, visit http://gerrit.cloudera.org:8080/7710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28d7cc4b969b5ac47890a673eb4a6716047d284d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-5810: reduce minimum non-reservation memory

2017-08-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5810: reduce minimum non-reservation memory
..


Patch Set 1: Code-Review+1

Since I'm touching this code as well in https://gerrit.cloudera.org/#/c/7678/

How about I just make this change and then I don't have to deal with merging?

-- 
To view, visit http://gerrit.cloudera.org:8080/7710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28d7cc4b969b5ac47890a673eb4a6716047d284d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-5810: reduce minimum non-reservation memory

2017-08-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5810: reduce minimum non-reservation memory
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28d7cc4b969b5ac47890a673eb4a6716047d284d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-5810: reduce minimum non-reservation memory

2017-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7710

Change subject: IMPALA-5810: reduce minimum non-reservation memory
..

IMPALA-5810: reduce minimum non-reservation memory

See JIRA for experimental results that show this slightly
improves min memory requirements for small queries.

One reason to tweak this is to compensate for the fact that
BufferedBlockMgr didn't count small buffers against the
BlockMgr limit, but BufferPool counts all buffers against it.

Change-Id: I28d7cc4b969b5ac47890a673eb4a6716047d284d
---
M be/src/runtime/query-state.cc
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/7710/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28d7cc4b969b5ac47890a673eb4a6716047d284d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong