[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/7974/9/.clang-tidy File .clang-tidy: Line 27: -clang-analyzer-cplusplus.NewDeleteLeaks,\ > I'm concerned that some of these went in with only self-review. Some of the I didn't remove any coverage and the suppressed warnings were mostly special cases or variants of ones that are already suppressed (e.g. new/delete is the same as the malloc one that's suppressed). I looked at the output of the warnings and they didn't turn up anything helpful so IMO not worth putting time into. -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Jim Apple has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/7974/9/.clang-tidy File .clang-tidy: Line 27: -clang-analyzer-cplusplus.NewDeleteLeaks,\ I'm concerned that some of these went in with only self-review. Some of them, by their name, look very useful to me. What is your preferred forum to discuss those new warning suppressions? -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. IMPALA-5860: upgrade to LLVM 3.9.1 LLVM made a few API changes: * Misc minor changes to function and type signatures * The CloneFunction() API changed semantics (http://reviews.llvm.org/D18628) Needed to fix a few new clang-tidy warnings. Testing: Ran core and ASAN tests. Perf: Ran single node TPC-H and targeted perf with scale factor 60. Both improved on average. +--+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +--+---+-++++ | TPCH(60) | parquet / none / none | 17.82 | -5.01% | 11.64 | -4.23% | +--+---+-++++ +--+--+---++-++++-+---+ | Workload | Query| File Format | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters | +--+--+---++-++++-+---+ | TPCH(60) | TPCH-Q1 | parquet / none / none | 27.97 | 27.59 | +1.36% | 0.39%| 0.41%| 1 | 5 | | TPCH(60) | TPCH-Q20 | parquet / none / none | 5.81 | 5.78| +0.44% | 0.73%| 0.21%| 1 | 5 | | TPCH(60) | TPCH-Q21 | parquet / none / none | 62.98 | 62.98 | +0.01% | 5.56%| 1.07%| 1 | 5 | | TPCH(60) | TPCH-Q15 | parquet / none / none | 8.45 | 8.46| -0.20% | 0.40%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q4 | parquet / none / none | 5.57 | 5.59| -0.41% | 0.43%| 0.80%| 1 | 5 | | TPCH(60) | TPCH-Q6 | parquet / none / none | 3.16 | 3.17| -0.45% | 0.78%| 1.70%| 1 | 5 | | TPCH(60) | TPCH-Q5 | parquet / none / none | 7.41 | 7.47| -0.92% | 0.71%| 1.06%| 1 | 5 | | TPCH(60) | TPCH-Q9 | parquet / none / none | 33.45 | 33.78 | -0.99% | 1.15%| 0.85%| 1 | 5 | | TPCH(60) | TPCH-Q11 | parquet / none / none | 2.00 | 2.03| -1.34% | 1.71%| 2.24%| 1 | 5 | | TPCH(60) | TPCH-Q2 | parquet / none / none | 4.71 | 4.79| -1.60% | 1.49%| 1.95%| 1 | 5 | | TPCH(60) | TPCH-Q18 | parquet / none / none | 46.48 | 47.71 | -2.58% | 1.04%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q14 | parquet / none / none | 5.85 | 6.02| -2.84% | 0.44%| 0.70%| 1 | 5 | | TPCH(60) | TPCH-Q22 | parquet / none / none | 6.51 | 6.76| -3.71% | 2.29%| 2.42%| 1 | 5 | | TPCH(60) | TPCH-Q19 | parquet / none / none | 7.27 | 7.63| -4.69% | 1.33%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q10 | parquet / none / none | 13.19 | 13.84 | -4.73% | 0.42%| 1.44%| 1 | 5 | | TPCH(60) | TPCH-Q13 | parquet / none / none | 21.95 | 23.12 | -5.03% | 0.25%| 1.19%| 1 | 5 | | TPCH(60) | TPCH-Q16 | parquet / none / none | 5.29 | 5.57| -5.04% | 0.85%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q7 | parquet / none / none | 42.05 | 44.33 | -5.16% | 2.07%| 2.28%| 1 | 5 | | TPCH(60) | TPCH-Q12 | parquet / none / none | 19.77 | 21.00 | -5.87% | 8.14%| 5.09%| 1 | 5 | | TPCH(60) | TPCH-Q3 | parquet / none / none | 11.46 | 12.32 | -6.94% | 0.76%| 0.53%| 1 | 5 | | TPCH(60) | TPCH-Q17 | parquet / none / none | 40.09 | 49.28 | -18.64% | 2.09%| 0.67%| 1 | 5 | | TPCH(60) | TPCH-Q8 | parquet / none / none | 10.63 | 13.47 | I -21.08% | * 12.34% * | * 21.09% * | 1 | 5 | +--+--+---++-++++-+---+ +---+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +---+---+-++++ | TARGETED-PERF(60) | parquet / none / none | 22.38 | -1.24% | 4.17 | +0.81% |
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 9: Code-Review+2 Missed a couple of clang warnings. -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 9: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1233/ -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7974 to look at the new patch set (#9). Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. IMPALA-5860: upgrade to LLVM 3.9.1 LLVM made a few API changes: * Misc minor changes to function and type signatures * The CloneFunction() API changed semantics (http://reviews.llvm.org/D18628) Needed to fix a few new clang-tidy warnings. Testing: Ran core and ASAN tests. Perf: Ran single node TPC-H and targeted perf with scale factor 60. Both improved on average. +--+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +--+---+-++++ | TPCH(60) | parquet / none / none | 17.82 | -5.01% | 11.64 | -4.23% | +--+---+-++++ +--+--+---++-++++-+---+ | Workload | Query| File Format | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters | +--+--+---++-++++-+---+ | TPCH(60) | TPCH-Q1 | parquet / none / none | 27.97 | 27.59 | +1.36% | 0.39%| 0.41%| 1 | 5 | | TPCH(60) | TPCH-Q20 | parquet / none / none | 5.81 | 5.78| +0.44% | 0.73%| 0.21%| 1 | 5 | | TPCH(60) | TPCH-Q21 | parquet / none / none | 62.98 | 62.98 | +0.01% | 5.56%| 1.07%| 1 | 5 | | TPCH(60) | TPCH-Q15 | parquet / none / none | 8.45 | 8.46| -0.20% | 0.40%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q4 | parquet / none / none | 5.57 | 5.59| -0.41% | 0.43%| 0.80%| 1 | 5 | | TPCH(60) | TPCH-Q6 | parquet / none / none | 3.16 | 3.17| -0.45% | 0.78%| 1.70%| 1 | 5 | | TPCH(60) | TPCH-Q5 | parquet / none / none | 7.41 | 7.47| -0.92% | 0.71%| 1.06%| 1 | 5 | | TPCH(60) | TPCH-Q9 | parquet / none / none | 33.45 | 33.78 | -0.99% | 1.15%| 0.85%| 1 | 5 | | TPCH(60) | TPCH-Q11 | parquet / none / none | 2.00 | 2.03| -1.34% | 1.71%| 2.24%| 1 | 5 | | TPCH(60) | TPCH-Q2 | parquet / none / none | 4.71 | 4.79| -1.60% | 1.49%| 1.95%| 1 | 5 | | TPCH(60) | TPCH-Q18 | parquet / none / none | 46.48 | 47.71 | -2.58% | 1.04%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q14 | parquet / none / none | 5.85 | 6.02| -2.84% | 0.44%| 0.70%| 1 | 5 | | TPCH(60) | TPCH-Q22 | parquet / none / none | 6.51 | 6.76| -3.71% | 2.29%| 2.42%| 1 | 5 | | TPCH(60) | TPCH-Q19 | parquet / none / none | 7.27 | 7.63| -4.69% | 1.33%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q10 | parquet / none / none | 13.19 | 13.84 | -4.73% | 0.42%| 1.44%| 1 | 5 | | TPCH(60) | TPCH-Q13 | parquet / none / none | 21.95 | 23.12 | -5.03% | 0.25%| 1.19%| 1 | 5 | | TPCH(60) | TPCH-Q16 | parquet / none / none | 5.29 | 5.57| -5.04% | 0.85%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q7 | parquet / none / none | 42.05 | 44.33 | -5.16% | 2.07%| 2.28%| 1 | 5 | | TPCH(60) | TPCH-Q12 | parquet / none / none | 19.77 | 21.00 | -5.87% | 8.14%| 5.09%| 1 | 5 | | TPCH(60) | TPCH-Q3 | parquet / none / none | 11.46 | 12.32 | -6.94% | 0.76%| 0.53%| 1 | 5 | | TPCH(60) | TPCH-Q17 | parquet / none / none | 40.09 | 49.28 | -18.64% | 2.09%| 0.67%| 1 | 5 | | TPCH(60) | TPCH-Q8 | parquet / none / none | 10.63 | 13.47 | I -21.08% | * 12.34% * | * 21.09% * | 1 | 5 | +--+--+---++-++++-+---+ +---+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +---+---+-++++ | TARGETED-PERF(60) |
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 8: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1232/ -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1232/ -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 8: Code-Review+2 Need to suppress a few new clang-tidy checks -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7974 to look at the new patch set (#8). Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. IMPALA-5860: upgrade to LLVM 3.9.1 LLVM made a few API changes: * Misc minor changes to function and type signatures * The CloneFunction() API changed semantics (http://reviews.llvm.org/D18628) Testing: Ran core and ASAN tests. Perf: Ran single node TPC-H and targeted perf with scale factor 60. Both improved on average. +--+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +--+---+-++++ | TPCH(60) | parquet / none / none | 17.82 | -5.01% | 11.64 | -4.23% | +--+---+-++++ +--+--+---++-++++-+---+ | Workload | Query| File Format | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters | +--+--+---++-++++-+---+ | TPCH(60) | TPCH-Q1 | parquet / none / none | 27.97 | 27.59 | +1.36% | 0.39%| 0.41%| 1 | 5 | | TPCH(60) | TPCH-Q20 | parquet / none / none | 5.81 | 5.78| +0.44% | 0.73%| 0.21%| 1 | 5 | | TPCH(60) | TPCH-Q21 | parquet / none / none | 62.98 | 62.98 | +0.01% | 5.56%| 1.07%| 1 | 5 | | TPCH(60) | TPCH-Q15 | parquet / none / none | 8.45 | 8.46| -0.20% | 0.40%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q4 | parquet / none / none | 5.57 | 5.59| -0.41% | 0.43%| 0.80%| 1 | 5 | | TPCH(60) | TPCH-Q6 | parquet / none / none | 3.16 | 3.17| -0.45% | 0.78%| 1.70%| 1 | 5 | | TPCH(60) | TPCH-Q5 | parquet / none / none | 7.41 | 7.47| -0.92% | 0.71%| 1.06%| 1 | 5 | | TPCH(60) | TPCH-Q9 | parquet / none / none | 33.45 | 33.78 | -0.99% | 1.15%| 0.85%| 1 | 5 | | TPCH(60) | TPCH-Q11 | parquet / none / none | 2.00 | 2.03| -1.34% | 1.71%| 2.24%| 1 | 5 | | TPCH(60) | TPCH-Q2 | parquet / none / none | 4.71 | 4.79| -1.60% | 1.49%| 1.95%| 1 | 5 | | TPCH(60) | TPCH-Q18 | parquet / none / none | 46.48 | 47.71 | -2.58% | 1.04%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q14 | parquet / none / none | 5.85 | 6.02| -2.84% | 0.44%| 0.70%| 1 | 5 | | TPCH(60) | TPCH-Q22 | parquet / none / none | 6.51 | 6.76| -3.71% | 2.29%| 2.42%| 1 | 5 | | TPCH(60) | TPCH-Q19 | parquet / none / none | 7.27 | 7.63| -4.69% | 1.33%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q10 | parquet / none / none | 13.19 | 13.84 | -4.73% | 0.42%| 1.44%| 1 | 5 | | TPCH(60) | TPCH-Q13 | parquet / none / none | 21.95 | 23.12 | -5.03% | 0.25%| 1.19%| 1 | 5 | | TPCH(60) | TPCH-Q16 | parquet / none / none | 5.29 | 5.57| -5.04% | 0.85%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q7 | parquet / none / none | 42.05 | 44.33 | -5.16% | 2.07%| 2.28%| 1 | 5 | | TPCH(60) | TPCH-Q12 | parquet / none / none | 19.77 | 21.00 | -5.87% | 8.14%| 5.09%| 1 | 5 | | TPCH(60) | TPCH-Q3 | parquet / none / none | 11.46 | 12.32 | -6.94% | 0.76%| 0.53%| 1 | 5 | | TPCH(60) | TPCH-Q17 | parquet / none / none | 40.09 | 49.28 | -18.64% | 2.09%| 0.67%| 1 | 5 | | TPCH(60) | TPCH-Q8 | parquet / none / none | 10.63 | 13.47 | I -21.08% | * 12.34% * | * 21.09% * | 1 | 5 | +--+--+---++-++++-+---+ +---+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +---+---+-++++ | TARGETED-PERF(60) | parquet / none / none | 22.38 | -1.24% |
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 7: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1231/ -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1231/ -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7974 to look at the new patch set (#7). Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. IMPALA-5860: upgrade to LLVM 3.9.1 LLVM made a few API changes: * Misc minor changes to function and type signatures * The CloneFunction() API changed semantics (http://reviews.llvm.org/D18628) Testing: Ran core and ASAN tests. Perf: Ran single node TPC-H and targeted perf with scale factor 60. Both improved on average. +--+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +--+---+-++++ | TPCH(60) | parquet / none / none | 17.82 | -5.01% | 11.64 | -4.23% | +--+---+-++++ +--+--+---++-++++-+---+ | Workload | Query| File Format | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters | +--+--+---++-++++-+---+ | TPCH(60) | TPCH-Q1 | parquet / none / none | 27.97 | 27.59 | +1.36% | 0.39%| 0.41%| 1 | 5 | | TPCH(60) | TPCH-Q20 | parquet / none / none | 5.81 | 5.78| +0.44% | 0.73%| 0.21%| 1 | 5 | | TPCH(60) | TPCH-Q21 | parquet / none / none | 62.98 | 62.98 | +0.01% | 5.56%| 1.07%| 1 | 5 | | TPCH(60) | TPCH-Q15 | parquet / none / none | 8.45 | 8.46| -0.20% | 0.40%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q4 | parquet / none / none | 5.57 | 5.59| -0.41% | 0.43%| 0.80%| 1 | 5 | | TPCH(60) | TPCH-Q6 | parquet / none / none | 3.16 | 3.17| -0.45% | 0.78%| 1.70%| 1 | 5 | | TPCH(60) | TPCH-Q5 | parquet / none / none | 7.41 | 7.47| -0.92% | 0.71%| 1.06%| 1 | 5 | | TPCH(60) | TPCH-Q9 | parquet / none / none | 33.45 | 33.78 | -0.99% | 1.15%| 0.85%| 1 | 5 | | TPCH(60) | TPCH-Q11 | parquet / none / none | 2.00 | 2.03| -1.34% | 1.71%| 2.24%| 1 | 5 | | TPCH(60) | TPCH-Q2 | parquet / none / none | 4.71 | 4.79| -1.60% | 1.49%| 1.95%| 1 | 5 | | TPCH(60) | TPCH-Q18 | parquet / none / none | 46.48 | 47.71 | -2.58% | 1.04%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q14 | parquet / none / none | 5.85 | 6.02| -2.84% | 0.44%| 0.70%| 1 | 5 | | TPCH(60) | TPCH-Q22 | parquet / none / none | 6.51 | 6.76| -3.71% | 2.29%| 2.42%| 1 | 5 | | TPCH(60) | TPCH-Q19 | parquet / none / none | 7.27 | 7.63| -4.69% | 1.33%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q10 | parquet / none / none | 13.19 | 13.84 | -4.73% | 0.42%| 1.44%| 1 | 5 | | TPCH(60) | TPCH-Q13 | parquet / none / none | 21.95 | 23.12 | -5.03% | 0.25%| 1.19%| 1 | 5 | | TPCH(60) | TPCH-Q16 | parquet / none / none | 5.29 | 5.57| -5.04% | 0.85%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q7 | parquet / none / none | 42.05 | 44.33 | -5.16% | 2.07%| 2.28%| 1 | 5 | | TPCH(60) | TPCH-Q12 | parquet / none / none | 19.77 | 21.00 | -5.87% | 8.14%| 5.09%| 1 | 5 | | TPCH(60) | TPCH-Q3 | parquet / none / none | 11.46 | 12.32 | -6.94% | 0.76%| 0.53%| 1 | 5 | | TPCH(60) | TPCH-Q17 | parquet / none / none | 40.09 | 49.28 | -18.64% | 2.09%| 0.67%| 1 | 5 | | TPCH(60) | TPCH-Q8 | parquet / none / none | 10.63 | 13.47 | I -21.08% | * 12.34% * | * 21.09% * | 1 | 5 | +--+--+---++-++++-+---+ +---+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +---+---+-++++ | TARGETED-PERF(60) | parquet / none / none | 22.38 | -1.24% | 4.17 | +0.81%
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 7: Code-Review+2 carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 6: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1230/ -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 6: Code-Review+2 rebase and update build ID -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1230/ -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7974 to look at the new patch set (#6). Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. IMPALA-5860: upgrade to LLVM 3.9.1 LLVM made a few API changes: * Misc minor changes to function and type signatures * The CloneFunction() API changed semantics (http://reviews.llvm.org/D18628) TODO: need to rebase and update toolchain to a later version. It has gotten behind with the frequent Kudu version bumps. Testing: Ran core and ASAN tests. Perf: Ran single node TPC-H and targeted perf with scale factor 60. Both improved on average. +--+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +--+---+-++++ | TPCH(60) | parquet / none / none | 17.82 | -5.01% | 11.64 | -4.23% | +--+---+-++++ +--+--+---++-++++-+---+ | Workload | Query| File Format | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters | +--+--+---++-++++-+---+ | TPCH(60) | TPCH-Q1 | parquet / none / none | 27.97 | 27.59 | +1.36% | 0.39%| 0.41%| 1 | 5 | | TPCH(60) | TPCH-Q20 | parquet / none / none | 5.81 | 5.78| +0.44% | 0.73%| 0.21%| 1 | 5 | | TPCH(60) | TPCH-Q21 | parquet / none / none | 62.98 | 62.98 | +0.01% | 5.56%| 1.07%| 1 | 5 | | TPCH(60) | TPCH-Q15 | parquet / none / none | 8.45 | 8.46| -0.20% | 0.40%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q4 | parquet / none / none | 5.57 | 5.59| -0.41% | 0.43%| 0.80%| 1 | 5 | | TPCH(60) | TPCH-Q6 | parquet / none / none | 3.16 | 3.17| -0.45% | 0.78%| 1.70%| 1 | 5 | | TPCH(60) | TPCH-Q5 | parquet / none / none | 7.41 | 7.47| -0.92% | 0.71%| 1.06%| 1 | 5 | | TPCH(60) | TPCH-Q9 | parquet / none / none | 33.45 | 33.78 | -0.99% | 1.15%| 0.85%| 1 | 5 | | TPCH(60) | TPCH-Q11 | parquet / none / none | 2.00 | 2.03| -1.34% | 1.71%| 2.24%| 1 | 5 | | TPCH(60) | TPCH-Q2 | parquet / none / none | 4.71 | 4.79| -1.60% | 1.49%| 1.95%| 1 | 5 | | TPCH(60) | TPCH-Q18 | parquet / none / none | 46.48 | 47.71 | -2.58% | 1.04%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q14 | parquet / none / none | 5.85 | 6.02| -2.84% | 0.44%| 0.70%| 1 | 5 | | TPCH(60) | TPCH-Q22 | parquet / none / none | 6.51 | 6.76| -3.71% | 2.29%| 2.42%| 1 | 5 | | TPCH(60) | TPCH-Q19 | parquet / none / none | 7.27 | 7.63| -4.69% | 1.33%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q10 | parquet / none / none | 13.19 | 13.84 | -4.73% | 0.42%| 1.44%| 1 | 5 | | TPCH(60) | TPCH-Q13 | parquet / none / none | 21.95 | 23.12 | -5.03% | 0.25%| 1.19%| 1 | 5 | | TPCH(60) | TPCH-Q16 | parquet / none / none | 5.29 | 5.57| -5.04% | 0.85%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q7 | parquet / none / none | 42.05 | 44.33 | -5.16% | 2.07%| 2.28%| 1 | 5 | | TPCH(60) | TPCH-Q12 | parquet / none / none | 19.77 | 21.00 | -5.87% | 8.14%| 5.09%| 1 | 5 | | TPCH(60) | TPCH-Q3 | parquet / none / none | 11.46 | 12.32 | -6.94% | 0.76%| 0.53%| 1 | 5 | | TPCH(60) | TPCH-Q17 | parquet / none / none | 40.09 | 49.28 | -18.64% | 2.09%| 0.67%| 1 | 5 | | TPCH(60) | TPCH-Q8 | parquet / none / none | 10.63 | 13.47 | I -21.08% | * 12.34% * | * 21.09% * | 1 | 5 | +--+--+---++-++++-+---+ +---+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) |
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7974 to look at the new patch set (#5). Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. IMPALA-5860: upgrade to LLVM 3.9.1 LLVM made a few API changes: * Misc minor changes to function and type signatures * The CloneFunction() API changed semantics (http://reviews.llvm.org/D18628) TODO: need to rebase and update toolchain to a later version. It has gotten behind with the frequent Kudu version bumps. Testing: Ran core and ASAN tests. Perf: Ran single node TPC-H and targeted perf with scale factor 60. Both improved on average. +--+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +--+---+-++++ | TPCH(60) | parquet / none / none | 17.82 | -5.01% | 11.64 | -4.23% | +--+---+-++++ +--+--+---++-++++-+---+ | Workload | Query| File Format | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters | +--+--+---++-++++-+---+ | TPCH(60) | TPCH-Q1 | parquet / none / none | 27.97 | 27.59 | +1.36% | 0.39%| 0.41%| 1 | 5 | | TPCH(60) | TPCH-Q20 | parquet / none / none | 5.81 | 5.78| +0.44% | 0.73%| 0.21%| 1 | 5 | | TPCH(60) | TPCH-Q21 | parquet / none / none | 62.98 | 62.98 | +0.01% | 5.56%| 1.07%| 1 | 5 | | TPCH(60) | TPCH-Q15 | parquet / none / none | 8.45 | 8.46| -0.20% | 0.40%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q4 | parquet / none / none | 5.57 | 5.59| -0.41% | 0.43%| 0.80%| 1 | 5 | | TPCH(60) | TPCH-Q6 | parquet / none / none | 3.16 | 3.17| -0.45% | 0.78%| 1.70%| 1 | 5 | | TPCH(60) | TPCH-Q5 | parquet / none / none | 7.41 | 7.47| -0.92% | 0.71%| 1.06%| 1 | 5 | | TPCH(60) | TPCH-Q9 | parquet / none / none | 33.45 | 33.78 | -0.99% | 1.15%| 0.85%| 1 | 5 | | TPCH(60) | TPCH-Q11 | parquet / none / none | 2.00 | 2.03| -1.34% | 1.71%| 2.24%| 1 | 5 | | TPCH(60) | TPCH-Q2 | parquet / none / none | 4.71 | 4.79| -1.60% | 1.49%| 1.95%| 1 | 5 | | TPCH(60) | TPCH-Q18 | parquet / none / none | 46.48 | 47.71 | -2.58% | 1.04%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q14 | parquet / none / none | 5.85 | 6.02| -2.84% | 0.44%| 0.70%| 1 | 5 | | TPCH(60) | TPCH-Q22 | parquet / none / none | 6.51 | 6.76| -3.71% | 2.29%| 2.42%| 1 | 5 | | TPCH(60) | TPCH-Q19 | parquet / none / none | 7.27 | 7.63| -4.69% | 1.33%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q10 | parquet / none / none | 13.19 | 13.84 | -4.73% | 0.42%| 1.44%| 1 | 5 | | TPCH(60) | TPCH-Q13 | parquet / none / none | 21.95 | 23.12 | -5.03% | 0.25%| 1.19%| 1 | 5 | | TPCH(60) | TPCH-Q16 | parquet / none / none | 5.29 | 5.57| -5.04% | 0.85%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q7 | parquet / none / none | 42.05 | 44.33 | -5.16% | 2.07%| 2.28%| 1 | 5 | | TPCH(60) | TPCH-Q12 | parquet / none / none | 19.77 | 21.00 | -5.87% | 8.14%| 5.09%| 1 | 5 | | TPCH(60) | TPCH-Q3 | parquet / none / none | 11.46 | 12.32 | -6.94% | 0.76%| 0.53%| 1 | 5 | | TPCH(60) | TPCH-Q17 | parquet / none / none | 40.09 | 49.28 | -18.64% | 2.09%| 0.67%| 1 | 5 | | TPCH(60) | TPCH-Q8 | parquet / none / none | 10.63 | 13.47 | I -21.08% | * 12.34% * | * 21.09% * | 1 | 5 | +--+--+---++-++++-+---+ +---+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) |
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7974/2/be/src/codegen/codegen-symbol-emitter.cc File be/src/codegen/codegen-symbol-emitter.cc: PS2, Line 98: getType > what type does that thing return? oh, maybe it's an "Expected<>"? Maybe pu Done PS2, Line 104: *addr_or_err > how about using get() like you did on line 98? Done PS2, Line 106: -> > same Done -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 2: unintended rebase, still need to address comments -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7974 to look at the new patch set (#4). Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. IMPALA-5860: upgrade to LLVM 3.9.1 LLVM made a few API changes: * Misc minor changes to function and type signatures * The CloneFunction() API changed semantics (http://reviews.llvm.org/D18628) TODO: need to rebase and update toolchain to a later version. It has gotten behind with the frequent Kudu version bumps. Testing: Ran core and ASAN tests. Perf: Ran single node TPC-H and targeted perf with scale factor 60. Both improved on average. +--+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +--+---+-++++ | TPCH(60) | parquet / none / none | 17.82 | -5.01% | 11.64 | -4.23% | +--+---+-++++ +--+--+---++-++++-+---+ | Workload | Query| File Format | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters | +--+--+---++-++++-+---+ | TPCH(60) | TPCH-Q1 | parquet / none / none | 27.97 | 27.59 | +1.36% | 0.39%| 0.41%| 1 | 5 | | TPCH(60) | TPCH-Q20 | parquet / none / none | 5.81 | 5.78| +0.44% | 0.73%| 0.21%| 1 | 5 | | TPCH(60) | TPCH-Q21 | parquet / none / none | 62.98 | 62.98 | +0.01% | 5.56%| 1.07%| 1 | 5 | | TPCH(60) | TPCH-Q15 | parquet / none / none | 8.45 | 8.46| -0.20% | 0.40%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q4 | parquet / none / none | 5.57 | 5.59| -0.41% | 0.43%| 0.80%| 1 | 5 | | TPCH(60) | TPCH-Q6 | parquet / none / none | 3.16 | 3.17| -0.45% | 0.78%| 1.70%| 1 | 5 | | TPCH(60) | TPCH-Q5 | parquet / none / none | 7.41 | 7.47| -0.92% | 0.71%| 1.06%| 1 | 5 | | TPCH(60) | TPCH-Q9 | parquet / none / none | 33.45 | 33.78 | -0.99% | 1.15%| 0.85%| 1 | 5 | | TPCH(60) | TPCH-Q11 | parquet / none / none | 2.00 | 2.03| -1.34% | 1.71%| 2.24%| 1 | 5 | | TPCH(60) | TPCH-Q2 | parquet / none / none | 4.71 | 4.79| -1.60% | 1.49%| 1.95%| 1 | 5 | | TPCH(60) | TPCH-Q18 | parquet / none / none | 46.48 | 47.71 | -2.58% | 1.04%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q14 | parquet / none / none | 5.85 | 6.02| -2.84% | 0.44%| 0.70%| 1 | 5 | | TPCH(60) | TPCH-Q22 | parquet / none / none | 6.51 | 6.76| -3.71% | 2.29%| 2.42%| 1 | 5 | | TPCH(60) | TPCH-Q19 | parquet / none / none | 7.27 | 7.63| -4.69% | 1.33%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q10 | parquet / none / none | 13.19 | 13.84 | -4.73% | 0.42%| 1.44%| 1 | 5 | | TPCH(60) | TPCH-Q13 | parquet / none / none | 21.95 | 23.12 | -5.03% | 0.25%| 1.19%| 1 | 5 | | TPCH(60) | TPCH-Q16 | parquet / none / none | 5.29 | 5.57| -5.04% | 0.85%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q7 | parquet / none / none | 42.05 | 44.33 | -5.16% | 2.07%| 2.28%| 1 | 5 | | TPCH(60) | TPCH-Q12 | parquet / none / none | 19.77 | 21.00 | -5.87% | 8.14%| 5.09%| 1 | 5 | | TPCH(60) | TPCH-Q3 | parquet / none / none | 11.46 | 12.32 | -6.94% | 0.76%| 0.53%| 1 | 5 | | TPCH(60) | TPCH-Q17 | parquet / none / none | 40.09 | 49.28 | -18.64% | 2.09%| 0.67%| 1 | 5 | | TPCH(60) | TPCH-Q8 | parquet / none / none | 10.63 | 13.47 | I -21.08% | * 12.34% * | * 21.09% * | 1 | 5 | +--+--+---++-++++-+---+ +---+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) |
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7974 to look at the new patch set (#3). Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. IMPALA-5860: upgrade to LLVM 3.9.1 LLVM made a few API changes: * Misc minor changes to function and type signatures * The CloneFunction() API changed semantics (http://reviews.llvm.org/D18628) TODO: need to rebase and update toolchain to a later version. It has gotten behind with the frequent Kudu version bumps. Testing: Ran core and ASAN tests. Perf: Ran single node TPC-H and targeted perf with scale factor 60. Both improved on average. +--+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +--+---+-++++ | TPCH(60) | parquet / none / none | 17.82 | -5.01% | 11.64 | -4.23% | +--+---+-++++ +--+--+---++-++++-+---+ | Workload | Query| File Format | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters | +--+--+---++-++++-+---+ | TPCH(60) | TPCH-Q1 | parquet / none / none | 27.97 | 27.59 | +1.36% | 0.39%| 0.41%| 1 | 5 | | TPCH(60) | TPCH-Q20 | parquet / none / none | 5.81 | 5.78| +0.44% | 0.73%| 0.21%| 1 | 5 | | TPCH(60) | TPCH-Q21 | parquet / none / none | 62.98 | 62.98 | +0.01% | 5.56%| 1.07%| 1 | 5 | | TPCH(60) | TPCH-Q15 | parquet / none / none | 8.45 | 8.46| -0.20% | 0.40%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q4 | parquet / none / none | 5.57 | 5.59| -0.41% | 0.43%| 0.80%| 1 | 5 | | TPCH(60) | TPCH-Q6 | parquet / none / none | 3.16 | 3.17| -0.45% | 0.78%| 1.70%| 1 | 5 | | TPCH(60) | TPCH-Q5 | parquet / none / none | 7.41 | 7.47| -0.92% | 0.71%| 1.06%| 1 | 5 | | TPCH(60) | TPCH-Q9 | parquet / none / none | 33.45 | 33.78 | -0.99% | 1.15%| 0.85%| 1 | 5 | | TPCH(60) | TPCH-Q11 | parquet / none / none | 2.00 | 2.03| -1.34% | 1.71%| 2.24%| 1 | 5 | | TPCH(60) | TPCH-Q2 | parquet / none / none | 4.71 | 4.79| -1.60% | 1.49%| 1.95%| 1 | 5 | | TPCH(60) | TPCH-Q18 | parquet / none / none | 46.48 | 47.71 | -2.58% | 1.04%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q14 | parquet / none / none | 5.85 | 6.02| -2.84% | 0.44%| 0.70%| 1 | 5 | | TPCH(60) | TPCH-Q22 | parquet / none / none | 6.51 | 6.76| -3.71% | 2.29%| 2.42%| 1 | 5 | | TPCH(60) | TPCH-Q19 | parquet / none / none | 7.27 | 7.63| -4.69% | 1.33%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q10 | parquet / none / none | 13.19 | 13.84 | -4.73% | 0.42%| 1.44%| 1 | 5 | | TPCH(60) | TPCH-Q13 | parquet / none / none | 21.95 | 23.12 | -5.03% | 0.25%| 1.19%| 1 | 5 | | TPCH(60) | TPCH-Q16 | parquet / none / none | 5.29 | 5.57| -5.04% | 0.85%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q7 | parquet / none / none | 42.05 | 44.33 | -5.16% | 2.07%| 2.28%| 1 | 5 | | TPCH(60) | TPCH-Q12 | parquet / none / none | 19.77 | 21.00 | -5.87% | 8.14%| 5.09%| 1 | 5 | | TPCH(60) | TPCH-Q3 | parquet / none / none | 11.46 | 12.32 | -6.94% | 0.76%| 0.53%| 1 | 5 | | TPCH(60) | TPCH-Q17 | parquet / none / none | 40.09 | 49.28 | -18.64% | 2.09%| 0.67%| 1 | 5 | | TPCH(60) | TPCH-Q8 | parquet / none / none | 10.63 | 13.47 | I -21.08% | * 12.34% * | * 21.09% * | 1 | 5 | +--+--+---++-++++-+---+ +---+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) |
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Dan Hecht has posted comments on this change. Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. Patch Set 2: Code-Review+2 (3 comments) Please decide if you want kwho to take a look as well. http://gerrit.cloudera.org:8080/#/c/7974/2/be/src/codegen/codegen-symbol-emitter.cc File be/src/codegen/codegen-symbol-emitter.cc: PS2, Line 98: getType what type does that thing return? oh, maybe it's an "Expected<>"? Maybe pull that into a variable to make this operator bool() overloading clearer? PS2, Line 104: *addr_or_err how about using get() like you did on line 98? PS2, Line 106: -> same -- To view, visit http://gerrit.cloudera.org:8080/7974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5860: upgrade to LLVM 3.9.1 .. IMPALA-5860: upgrade to LLVM 3.9.1 LLVM made a few API changes: * Misc minor changes to function and type signatures * The CloneFunction() API changed semantics (http://reviews.llvm.org/D18628) TODO: need to rebase and update toolchain to a later version. It has gotten behind with the frequent Kudu version bumps. Testing: Ran core and ASAN tests. Perf: Ran single node TPC-H and targeted perf with scale factor 60. Both improved on average. +--+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +--+---+-++++ | TPCH(60) | parquet / none / none | 17.82 | -5.01% | 11.64 | -4.23% | +--+---+-++++ +--+--+---++-++++-+---+ | Workload | Query| File Format | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters | +--+--+---++-++++-+---+ | TPCH(60) | TPCH-Q1 | parquet / none / none | 27.97 | 27.59 | +1.36% | 0.39%| 0.41%| 1 | 5 | | TPCH(60) | TPCH-Q20 | parquet / none / none | 5.81 | 5.78| +0.44% | 0.73%| 0.21%| 1 | 5 | | TPCH(60) | TPCH-Q21 | parquet / none / none | 62.98 | 62.98 | +0.01% | 5.56%| 1.07%| 1 | 5 | | TPCH(60) | TPCH-Q15 | parquet / none / none | 8.45 | 8.46| -0.20% | 0.40%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q4 | parquet / none / none | 5.57 | 5.59| -0.41% | 0.43%| 0.80%| 1 | 5 | | TPCH(60) | TPCH-Q6 | parquet / none / none | 3.16 | 3.17| -0.45% | 0.78%| 1.70%| 1 | 5 | | TPCH(60) | TPCH-Q5 | parquet / none / none | 7.41 | 7.47| -0.92% | 0.71%| 1.06%| 1 | 5 | | TPCH(60) | TPCH-Q9 | parquet / none / none | 33.45 | 33.78 | -0.99% | 1.15%| 0.85%| 1 | 5 | | TPCH(60) | TPCH-Q11 | parquet / none / none | 2.00 | 2.03| -1.34% | 1.71%| 2.24%| 1 | 5 | | TPCH(60) | TPCH-Q2 | parquet / none / none | 4.71 | 4.79| -1.60% | 1.49%| 1.95%| 1 | 5 | | TPCH(60) | TPCH-Q18 | parquet / none / none | 46.48 | 47.71 | -2.58% | 1.04%| 0.38%| 1 | 5 | | TPCH(60) | TPCH-Q14 | parquet / none / none | 5.85 | 6.02| -2.84% | 0.44%| 0.70%| 1 | 5 | | TPCH(60) | TPCH-Q22 | parquet / none / none | 6.51 | 6.76| -3.71% | 2.29%| 2.42%| 1 | 5 | | TPCH(60) | TPCH-Q19 | parquet / none / none | 7.27 | 7.63| -4.69% | 1.33%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q10 | parquet / none / none | 13.19 | 13.84 | -4.73% | 0.42%| 1.44%| 1 | 5 | | TPCH(60) | TPCH-Q13 | parquet / none / none | 21.95 | 23.12 | -5.03% | 0.25%| 1.19%| 1 | 5 | | TPCH(60) | TPCH-Q16 | parquet / none / none | 5.29 | 5.57| -5.04% | 0.85%| 0.78%| 1 | 5 | | TPCH(60) | TPCH-Q7 | parquet / none / none | 42.05 | 44.33 | -5.16% | 2.07%| 2.28%| 1 | 5 | | TPCH(60) | TPCH-Q12 | parquet / none / none | 19.77 | 21.00 | -5.87% | 8.14%| 5.09%| 1 | 5 | | TPCH(60) | TPCH-Q3 | parquet / none / none | 11.46 | 12.32 | -6.94% | 0.76%| 0.53%| 1 | 5 | | TPCH(60) | TPCH-Q17 | parquet / none / none | 40.09 | 49.28 | -18.64% | 2.09%| 0.67%| 1 | 5 | | TPCH(60) | TPCH-Q8 | parquet / none / none | 10.63 | 13.47 | I -21.08% | * 12.34% * | * 21.09% * | 1 | 5 | +--+--+---++-++++-+---+ +---+---+-++++ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +---+---+-++++ | TARGETED-PERF(60) | parquet / none / none | 22.38 | -1.24%