[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change.

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8050/3//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
> Ah, I saw this too late and the change got submitted in the meantime. I don
No worries, I think it's fine as is.


-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change.

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8050/3//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
> We should fix this msg, not correct anymore, sorry
Ah, I saw this too late and the change got submitted in the meantime. I don't 
think it warrants a force push, let me know if you think otherwise. Feel free 
to -2 my changes if I miss something similar in the future. :)


-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..


IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

ChildQuery::Cancel() prints a binary ID into the log which can show up
as random characters. One fix is to print it as a hex string.

I tested this by running test_cancellation::test_cancel_insert and
making sure the ID is printed as hex.

This change also removes PrintAsHex() which was broken and unused.

Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Reviewed-on: http://gerrit.cloudera.org:8080/8050
Reviewed-by: Lars Volker 
Tested-by: Impala Public Jenkins
---
M be/src/service/child-query.cc
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
3 files changed, 10 insertions(+), 12 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Lars Volker: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change.

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8050/3//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
We should fix this msg, not correct anymore, sorry


-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change.

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..


Patch Set 3: Code-Review+2

Carrying Alex's +2.

-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change.

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8050/2/be/src/service/child-query.cc
File be/src/service/child-query.cc:

Line 139: VLOG_QUERY << status;
> VLOG_QUERY << "Cancelling and closing child query. Failed to get query id: 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1219/

-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Lars Volker (Code Review)]

Hello Alex Behm,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/8050

to look at the new patch set (#3).

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..

IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

ChildQuery::Cancel() prints a binary ID into the log which can show up
as random characters. One fix is to print it as a hex string.

I tested this by running test_cancellation::test_cancel_insert and
making sure the ID is printed as hex.

This change also removes PrintAsHex() which was broken and unused.

Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
---
M be/src/service/child-query.cc
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
3 files changed, 10 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/8050/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change.

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8050/2/be/src/service/child-query.cc
File be/src/service/child-query.cc:

Line 139: VLOG_QUERY << status;
VLOG_QUERY << "Cancelling and closing child query. Failed to get query id: " << 
status;


-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change.

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8050/1/be/src/service/child-query.cc
File be/src/service/child-query.cc:

Line 131:   const string& guid = hs2_handle_.operationId.guid;
> Why not use ImpalaServer::THandleIdentifierToTUniqueId() to convert to a TU
Thanks, I didn't know what one.


-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Lars Volker (Code Review)]

Lars Volker has uploaded a new patch set (#2).

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..

IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

ChildQuery::Cancel() prints a binary ID into the log which can show up
as random characters. One fix is to print it as a hex string.

I tested this by running test_cancellation::test_cancel_insert and
making sure the ID is printed as hex.

This change also removes PrintAsHex() which was broken and unused.

Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
---
M be/src/service/child-query.cc
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
3 files changed, 9 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/8050/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change.

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8050/1/be/src/service/child-query.cc
File be/src/service/child-query.cc:

Line 131:   const string& guid = hs2_handle_.operationId.guid;
Why not use ImpalaServer::THandleIdentifierToTUniqueId() to convert to a 
TUniqueId?

You can take a look at ExecuteStatement() in impala-hs2-server.cc that converts 
out internal query id to the HS2 handle guid


-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Lars Volker (Code Review)]

Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/8050

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
..

IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

ChildQuery::Cancel() prints a binary ID into the log which can show up
as random characters. One fix is to print it as a hex string.

I tested this by running test_cancellation::test_cancel_insert and
making sure the ID is printed as hex.

Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
---
M be/src/service/child-query.cc
M be/src/util/debug-util.cc
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/8050/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker