[Impala-ASF-CR] IMPALA-6099: Fix crash in CheckForAlwaysFalse()

2017-10-24 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8369 )

Change subject: IMPALA-6099: Fix crash in CheckForAlwaysFalse()
..

IMPALA-6099: Fix crash in CheckForAlwaysFalse()

Filter states indexed by FilterStats::ROW_GROUPS_KEY was only relevant
if the runtime filter is bound by partitioning columns. This is no
longer true since always-false filter can filter out row groups as
well, which results in a crash in CheckForAlwaysFalse(). This patch
registers row groups counters unconditionally to fix this bug.

Change-Id: I3eda43845b78516c1e76e07e0d2dd9d862168e1d
Reviewed-on: http://gerrit.cloudera.org:8080/8369
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins
---
M be/src/exec/filter-context.cc
M be/src/exec/filter-context.h
M be/src/exec/scan-node.cc
3 files changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3eda43845b78516c1e76e07e0d2dd9d862168e1d
Gerrit-Change-Number: 8369
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-6099: Fix crash in CheckForAlwaysFalse()

2017-10-24 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8369 )

Change subject: IMPALA-6099: Fix crash in CheckForAlwaysFalse()
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eda43845b78516c1e76e07e0d2dd9d862168e1d
Gerrit-Change-Number: 8369
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 24 Oct 2017 22:19:21 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6099: Fix crash in CheckForAlwaysFalse()

2017-10-24 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8369 )

Change subject: IMPALA-6099: Fix crash in CheckForAlwaysFalse()
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1376/


--
To view, visit http://gerrit.cloudera.org:8080/8369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eda43845b78516c1e76e07e0d2dd9d862168e1d
Gerrit-Change-Number: 8369
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 24 Oct 2017 18:15:05 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6099: Fix crash in CheckForAlwaysFalse()

2017-10-24 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8369 )

Change subject: IMPALA-6099: Fix crash in CheckForAlwaysFalse()
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eda43845b78516c1e76e07e0d2dd9d862168e1d
Gerrit-Change-Number: 8369
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 24 Oct 2017 18:14:55 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6099: Fix crash in CheckForAlwaysFalse()

2017-10-24 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8369 )

Change subject: IMPALA-6099: Fix crash in CheckForAlwaysFalse()
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eda43845b78516c1e76e07e0d2dd9d862168e1d
Gerrit-Change-Number: 8369
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 24 Oct 2017 18:14:27 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6099: Fix crash in CheckForAlwaysFalse()

2017-10-24 Thread Thomas Tauber-Marshall (Code Review) 
Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8369 )

Change subject: IMPALA-6099: Fix crash in CheckForAlwaysFalse()
..


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8369/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8369/1//COMMIT_MSG@14
PS1, Line 14:
brief note about testing, eg. "ran existing test ... which previously repro-ed 
this"



--
To view, visit http://gerrit.cloudera.org:8080/8369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eda43845b78516c1e76e07e0d2dd9d862168e1d
Gerrit-Change-Number: 8369
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Tue, 24 Oct 2017 17:22:32 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6099: Fix crash in CheckForAlwaysFalse()

2017-10-24 Thread Tianyi Wang (Code Review) 
Tianyi Wang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8369


Change subject: IMPALA-6099: Fix crash in CheckForAlwaysFalse()
..

IMPALA-6099: Fix crash in CheckForAlwaysFalse()

Filter states indexed by FilterStats::ROW_GROUPS_KEY was only relevant
if the runtime filter is bound by partitioning columns. This is no
longer true since always-false filter can filter out row groups as
well, which results in a crash in CheckForAlwaysFalse(). This patch
registers row groups counters unconditionally to fix this bug.

Change-Id: I3eda43845b78516c1e76e07e0d2dd9d862168e1d
---
M be/src/exec/filter-context.cc
M be/src/exec/filter-context.h
M be/src/exec/scan-node.cc
3 files changed, 4 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/8369/1
--
To view, visit http://gerrit.cloudera.org:8080/8369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eda43845b78516c1e76e07e0d2dd9d862168e1d
Gerrit-Change-Number: 8369
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang