[Impala-ASF-CR] Improve substitution variables.
Impala Public Jenkins has submitted this change and it was merged. Change subject: Improve substitution variables. .. Improve substitution variables. Fix the version numbers that show up in titles and in lead-ins, e.g. " or higher only", to reflect purely Impala release numbers. Substitute the most prevalent forms of reference to CDH and Cloudera support with generic equivalents. Resolved merge conflict with the code review to reorg all the keydefs into a separate file. Change-Id: Ia23b96a8344e6430528701b81bea7eaaccc72b18 Reviewed-on: http://gerrit.cloudera.org:8080/5661 Reviewed-by: John RussellTested-by: Impala Public Jenkins --- M docs/impala_keydefs.ditamap 1 file changed, 22 insertions(+), 24 deletions(-) Approvals: Impala Public Jenkins: Verified John Russell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia23b96a8344e6430528701b81bea7eaaccc72b18 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] Improve substitution variables.
Impala Public Jenkins has posted comments on this change. Change subject: Improve substitution variables. .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/20/ -- To view, visit http://gerrit.cloudera.org:8080/5661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia23b96a8344e6430528701b81bea7eaaccc72b18 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John RussellGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] Improve substitution variables.
John Russell has posted comments on this change. Change subject: Improve substitution variables. .. Patch Set 2: Code-Review+2 Fixed merge conflict. Rebuilt PDF and confirmed the substitution changes are still effective. -- To view, visit http://gerrit.cloudera.org:8080/5661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia23b96a8344e6430528701b81bea7eaaccc72b18 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John RussellGerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] Improve substitution variables.
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5661 to look at the new patch set (#2). Change subject: Improve substitution variables. .. Improve substitution variables. Fix the version numbers that show up in titles and in lead-ins, e.g. " or higher only", to reflect purely Impala release numbers. Substitute the most prevalent forms of reference to CDH and Cloudera support with generic equivalents. Resolved merge conflict with the code review to reorg all the keydefs into a separate file. Change-Id: Ia23b96a8344e6430528701b81bea7eaaccc72b18 --- M docs/impala_keydefs.ditamap 1 file changed, 22 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/5661/2 -- To view, visit http://gerrit.cloudera.org:8080/5661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia23b96a8344e6430528701b81bea7eaaccc72b18 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John RussellGerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] Improve substitution variables.
Laurel Hale has posted comments on this change. Change subject: Improve substitution variables. .. Patch Set 1: Code-Review+1 pulled into private branch, caused a merge conflict. Resolved merge conflict and built PDF. Found 4 occurrences of "CDH 5.5 or higher" in text, but none in titles. I think this achieved what you stated in your check-in comments. -- To view, visit http://gerrit.cloudera.org:8080/5661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia23b96a8344e6430528701b81bea7eaaccc72b18 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John RussellGerrit-Reviewer: Laurel Hale Gerrit-HasComments: No
[Impala-ASF-CR] Improve substitution variables.
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5661 Change subject: Improve substitution variables. .. Improve substitution variables. Fix the version numbers that show up in titles and in lead-ins, e.g. " or higher only", to reflect purely Impala release numbers. Substitute the most prevalent forms of reference to CDH and Cloudera support with generic equivalents. This isolated change will probably cause a merge conflict with the code review to reorg all the keydefs into a separate file. But that will be easy to resolve, and this small fix will result in some high-visibility improvements since the release numbers are present in the Table of Contents. Change-Id: Ia23b96a8344e6430528701b81bea7eaaccc72b18 --- M docs/impala.ditamap 1 file changed, 24 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/5661/1 -- To view, visit http://gerrit.cloudera.org:8080/5661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia23b96a8344e6430528701b81bea7eaaccc72b18 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell