[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-03 Thread Tim Armstrong (Code Review) 
Tim Armstrong has abandoned this change.

Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics"
..


Abandoned

See https://gerrit.cloudera.org/#/c/7573/

-- 
To view, visit http://gerrit.cloudera.org:8080/7571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaa9317492c77279d79af770ef9a77df0e0914826
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change.

Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics"
..


Patch Set 2:

Posted the alternative fix here: https://gerrit.cloudera.org/#/c/7573

-- 
To view, visit http://gerrit.cloudera.org:8080/7571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9317492c77279d79af770ef9a77df0e0914826
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Henry Robinson (Code Review) 
Henry Robinson has posted comments on this change.

Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics"
..


Patch Set 2:

sounds good - let me give you a 'conditional +2'? since you've started a GVO I 
don't want it to commit accidentally if you're making progress, but if you 
determine it's too hard to solve quickly, feel free to +2 and commit.

-- 
To view, visit http://gerrit.cloudera.org:8080/7571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9317492c77279d79af770ef9a77df0e0914826
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change.

Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics"
..


Patch Set 2:

I mainly wanted to be sure that I unblocked people tomorrow. It looked like the 
fix was non-trivial but I'm not sure now. Going to try something and will post 
it instead if it works out.

-- 
To view, visit http://gerrit.cloudera.org:8080/7571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9317492c77279d79af770ef9a77df0e0914826
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Henry Robinson (Code Review) 
Henry Robinson has posted comments on this change.

Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics"
..


Patch Set 2:

Thanks for jumping on the broken build. Just wondering why a revert was in 
order here - is the problem not easily fixed, or do you not think you'll find 
time to fix it?

-- 
To view, visit http://gerrit.cloudera.org:8080/7571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9317492c77279d79af770ef9a77df0e0914826
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics"
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/973/

-- 
To view, visit http://gerrit.cloudera.org:8080/7571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9317492c77279d79af770ef9a77df0e0914826
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Tim Armstrong (Code Review) 
Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7571

Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics"
..

Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

This reverts commit 3f82d15704160f31d4060123520c3fb3493a3533,
which caused IMPALA-5756.

Change-Id: Iaa9317492c77279d79af770ef9a77df0e0914826
---
M be/src/common/init.cc
M be/src/runtime/exec-env.cc
M be/src/util/default-path-handlers.cc
M be/src/util/mem-info.cc
M be/src/util/mem-info.h
M be/src/util/memory-metrics.cc
M be/src/util/memory-metrics.h
M common/thrift/metrics.json
M www/memz.tmpl
9 files changed, 38 insertions(+), 384 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/7571/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa9317492c77279d79af770ef9a77df0e0914826
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong