[native-toolchain-CR] IMPALA-4983: Compile LZ4 in release mode

[Henry Robinson (Code Review)]

Henry Robinson has submitted this change and it was merged.

Change subject: IMPALA-4983: Compile LZ4 in release mode
..


IMPALA-4983: Compile LZ4 in release mode

LZ4 was not compiled (apparently ever?) with optimization enabled. In
recent versions this lead to a regression in compression time that was
noticeable vs previous LZ4 versions. With optimization enabled, the
regression appears to vanish.

Change-Id: I8bd113822dfc4df2d76c4393c4b3b3550066dd18
---
M source/lz4/build.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Henry Robinson: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8bd113822dfc4df2d76c4393c4b3b3550066dd18
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 

[native-toolchain-CR] IMPALA-4983: Compile LZ4 in release mode

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: IMPALA-4983: Compile LZ4 in release mode
..


Patch Set 1: Code-Review+2 Verified+1

Carry +2 from Toolchain project. Verified by complete build.

-- 
To view, visit http://gerrit.cloudera.org:8080/6164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bd113822dfc4df2d76c4393c4b3b3550066dd18
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-4983: Compile LZ4 in release mode

[Henry Robinson (Code Review)]

Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6164

Change subject: IMPALA-4983: Compile LZ4 in release mode
..

IMPALA-4983: Compile LZ4 in release mode

LZ4 was not compiled (apparently ever?) with optimization enabled. In
recent versions this lead to a regression in compression time that was
noticeable vs previous LZ4 versions. With optimization enabled, the
regression appears to vanish.

Change-Id: I8bd113822dfc4df2d76c4393c4b3b3550066dd18
---
M source/lz4/build.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain 
refs/changes/64/6164/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bd113822dfc4df2d76c4393c4b3b3550066dd18
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson