[native-toolchain-CR] IMPALA-5714: Add linker's version script for OpenSSL library

[Michael Ho (Code Review)]

Michael Ho has abandoned this change.

Change subject: IMPALA-5714: Add linker's version script for OpenSSL library
..


Abandoned

Decided that we won't need it for KRPC.

-- 
To view, visit http://gerrit.cloudera.org:8080/7484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
Gerrit-PatchSet: 6
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 

[native-toolchain-CR] IMPALA-5714: Add linker's version script for OpenSSL library

[Matthew Jacobs (Code Review)]

Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5714: Add linker's version script for OpenSSL library
..


Patch Set 6: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7484/6/source/openssl/build.sh
File source/openssl/build.sh:

PS6, Line 48: $PWD/..
is there a better variable to use for this directory?


-- 
To view, visit http://gerrit.cloudera.org:8080/7484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
Gerrit-PatchSet: 6
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: Yes

[native-toolchain-CR] IMPALA-5714: Add linker's version script for OpenSSL library

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change.

Change subject: IMPALA-5714: Add linker's version script for OpenSSL library
..


Patch Set 6:

FWIW, the tarball of openssl-1.0.2l has already been uploaded to the S3 bucket. 
I was able to execute the following command with this change:

./build.sh openssl 1.0.2l

-- 
To view, visit http://gerrit.cloudera.org:8080/7484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
Gerrit-PatchSet: 6
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-5714: Add linker's version script for OpenSSL library

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change.

Change subject: IMPALA-5714: Add linker's version script for OpenSSL library
..


Patch Set 6:

PS6 uses the Ubuntu's libssl 1.0.2g linker script without any modification. I 
looked at the OpenSSL release notes between 1.0.2g and 1.0.2l and it appears 
that all changes were related to CVE and no new interfaces were introduced. So, 
it should be safe to use the linker script of 1.0.2g.

-- 
To view, visit http://gerrit.cloudera.org:8080/7484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
Gerrit-PatchSet: 6
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-5714: Add linker's version script for OpenSSL library

[Michael Ho (Code Review)]

Michael Ho has uploaded a new patch set (#6).

Change subject: IMPALA-5714: Add linker's version script for OpenSSL library
..

IMPALA-5714: Add linker's version script for OpenSSL library

Debian based distribution (e.g. Ubuntu) expects OpenSSL
dynamically linked library to have been compiled with
a version script to control the exported symbols for
different versions of the library. Without this version
info, one may get errors like the following:

$IMPALA_HOME/be/build/latest/statestore/statestored: 
$IMPALA_HOME/toolchain/openssl-1.0.1p/lib/libssl.so.1.0.0: no version 
information available (required by 
$IMPALA_HOME/toolchain/kudu-1070e76/debug/lib/libkudu_client.so.0)

This change copies the version script of Ubuntu's libssl 1.0.2g
(https://launchpad.net/ubuntu/+archive/primary/+files/openssl_1.0.2g-1ubuntu11.2.debian.tar.xz)
and uses it when building the shared library.

Built Impala with this library and ran some sanity tests.

Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
---
M source/openssl/build.sh
A source/openssl/openssl.ld
2 files changed, 4,786 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain 
refs/changes/84/7484/6
-- 
To view, visit http://gerrit.cloudera.org:8080/7484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
Gerrit-PatchSet: 6
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 

[native-toolchain-CR] IMPALA-5714: Add linker's version script for OpenSSL library

[Michael Ho (Code Review)]

Michael Ho has uploaded a new patch set (#5).

Change subject: IMPALA-5714: Add linker's version script for OpenSSL library
..

IMPALA-5714: Add linker's version script for OpenSSL library

Debian based distribution (e.g. Ubuntu) expects OpenSSL
dynamically linked library to have been compiled with
a version script to control the exported symbols for
different versions of the library. Without this version
info, one may get errors like the following:

$IMPALA_HOME/be/build/latest/statestore/statestored: 
$IMPALA_HOME/toolchain/openssl-1.0.1p/lib/libssl.so.1.0.0: no version 
information available (required by 
$IMPALA_HOME/toolchain/kudu-1070e76/debug/lib/libkudu_client.so.0)

This change copies part of the version script of Ubuntu's libssl 1.0.2g
(https://launchpad.net/ubuntu/+archive/primary/+files/openssl_1.0.2g-1ubuntu11.2.debian.tar.xz)
and uses it as part of building the shared library.

Built Impala with this library and ran some sanity tests.

Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
---
M source/openssl/build.sh
A source/openssl/openssl.ld
2 files changed, 4,639 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain 
refs/changes/84/7484/5
-- 
To view, visit http://gerrit.cloudera.org:8080/7484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
Gerrit-PatchSet: 5
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil