[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #777: [IoTDB-400] Support rest api
sonarcloud[bot] removed a comment on issue #777: [IoTDB-400] Support rest api URL: https://github.com/apache/incubator-iotdb/pull/777#issuecomment-609807364 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=SECURITY_HOTSPOT) [6 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=CODE_SMELL) [24 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=777) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=777=new_duplicated_lines_density=list) [0.6% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=777=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #777: [IoTDB-400] Support rest api
sonarcloud[bot] commented on issue #777: [IoTDB-400] Support rest api URL: https://github.com/apache/incubator-iotdb/pull/777#issuecomment-611344236 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=SECURITY_HOTSPOT) [6 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=CODE_SMELL) [24 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=777=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=777) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=777=new_duplicated_lines_density=list) [0.6% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=777=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #1013: [IOTDB-583] Start API services at last
sonarcloud[bot] removed a comment on issue #1013: [IOTDB-583] Start API services at last URL: https://github.com/apache/incubator-iotdb/pull/1013#issuecomment-611309714 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1013) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1013=new_duplicated_lines_density=list) [4.1% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1013=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #1013: [IOTDB-583] Start API services at last
sonarcloud[bot] commented on issue #1013: [IOTDB-583] Start API services at last URL: https://github.com/apache/incubator-iotdb/pull/1013#issuecomment-611328103 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1013) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1013=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1013=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] samperson1997 opened a new pull request #1014: Fix some HDFS config issues in rel/0.9
samperson1997 opened a new pull request #1014: Fix some HDFS config issues in rel/0.9 URL: https://github.com/apache/incubator-iotdb/pull/1014 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #1013: [IOTDB-583] Start API services at last
sonarcloud[bot] commented on issue #1013: [IOTDB-583] Start API services at last URL: https://github.com/apache/incubator-iotdb/pull/1013#issuecomment-611309714 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1013=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1013) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1013=new_duplicated_lines_density=list) [4.1% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1013=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1012: [IOTDB-583] [to rel/0.9] Start JDBC service in the last
qiaojialin merged pull request #1012: [IOTDB-583] [to rel/0.9] Start JDBC service in the last URL: https://github.com/apache/incubator-iotdb/pull/1012 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #1013: [IOTDB-583] Start API services at last
qiaojialin opened a new pull request #1013: [IOTDB-583] Start API services at last URL: https://github.com/apache/incubator-iotdb/pull/1013 When the server started, it first register the StorageEngine, JDBCService and UpgradeService. If the client write new data while the upgrade thread traverses the tsfile resource list, a ConcurrentModificationException will occur. We should start API services at last. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] SailVR commented on a change in pull request #1010: modify site & docs
SailVR commented on a change in pull request #1010: modify site & docs
URL: https://github.com/apache/incubator-iotdb/pull/1010#discussion_r405912296
##
File path: site/src/main/.vuepress/config.js
##
@@ -520,21 +515,14 @@ var config = {
{
text: 'ASF',
items: [
- { text: '基础', link:
'http://www.apache.org/foundation/',rel:''},
- { text: '执照', link:
'http://www.apache.org/licenses/',rel:''},
- { text: '安全', link:
'http://www.apache.org/security/',rel:''},
- { text: '赞助', link:
'http://www.apache.org/foundation/sponsorship.html',rel:''},
- { text: '致谢', link:
'http://www.apache.org/foundation/thanks.html',rel:''},
- { text: '现在发生的事', link:
'http://www.apache.org/events/current-event',rel:''},
+ { text: '基础', link:
'http://www.apache.org/',target:'_self', rel:''},
+ { text: '执照', link:
'http://www.apache.org/licenses/',target:'_self', rel:''},
+ { text: '安全', link:
'http://www.apache.org/security/',target:'_self', rel:''},
+ { text: '赞助', link:
'http://www.apache.org/foundation/sponsorship.html',target:'_self', rel:''},
+ { text: '致谢', link:
'http://www.apache.org/foundation/thanks.html',target:'_self', rel:''},
+ { text: '现在发生的事', link:
'http://www.apache.org/events/current-event',target:'_self', rel:''},
Review comment:
已修改
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #1012: [IOTDB-583] Start JDBC service in the last
qiaojialin opened a new pull request #1012: [IOTDB-583] Start JDBC service in the last URL: https://github.com/apache/incubator-iotdb/pull/1012 When the server started, it first register the StorageEngine, JDBCService and UpgradeService. If the client write new data while the upgrade thread traverses the tsfile resource list, a ConcurrentModificationException will occur. The upgrade traverse is in the startup. no need to copy resources. Just move the JDBCService start at last. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1011: [IOTDB-583] fix concurrent modification exception
qiaojialin merged pull request #1011: [IOTDB-583] fix concurrent modification exception URL: https://github.com/apache/incubator-iotdb/pull/1011 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin edited a comment on issue #1011: [IOTDB-583] fix concurrent modification exception
qiaojialin edited a comment on issue #1011: [IOTDB-583] fix concurrent
modification exception
URL: https://github.com/apache/incubator-iotdb/pull/1011#issuecomment-611275692
> It can reduce the concurrecny exception, but I am not sure whether new
ArrayList(Collection) is atomic..
Maybe not atomic, but I don't see exception in this test:
```
List list = new ArrayList<>();
for (int i = 0; i < 100; i++) {
list.add(i+"");
}
new Thread(() -> {
while (true) {
List newList = new ArrayList<>(list);
}
}).start();
new Thread(() -> {
while (true) {
list.add("aaa");
}
}).start();
```
The most important is we need to release 0.9.2...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on issue #1009: Revert "[IOTDB-578] Cluster module should use the same thrift version with io…"
jixuan1989 commented on issue #1009: Revert "[IOTDB-578] Cluster module should use the same thrift version with io…" URL: https://github.com/apache/incubator-iotdb/pull/1009#issuecomment-611276294 > thrift 0.13.0 used by the stand-alone IoTDB will cause bugs in Mac OS and that is why we use a separate version in the distributed version. PLEASE, do not merge any outside code without informing the committers who are working on this branch. If so, 1. should we downgrade the thrift version in the server module? 2. add a comment on the top of the dependency in the cluster pom.xml to claim why you have to do that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin commented on issue #1011: [IOTDB-583] fix concurrent modification exception
qiaojialin commented on issue #1011: [IOTDB-583] fix concurrent modification exception URL: https://github.com/apache/incubator-iotdb/pull/1011#issuecomment-611275692 > It can reduce the concurrecny exception, but I am not sure whether new ArrayList(Collection) is atomic.. Maybe not atomic, but the most important is we need to release 0.9.2... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 merged pull request #929: [IOTDB-565] MQTT Protocol Support
jixuan1989 merged pull request #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1010: modify site & docs
jixuan1989 commented on a change in pull request #1010: modify site & docs
URL: https://github.com/apache/incubator-iotdb/pull/1010#discussion_r405885923
##
File path: site/src/main/.vuepress/config.js
##
@@ -520,21 +515,14 @@ var config = {
{
text: 'ASF',
items: [
- { text: '基础', link:
'http://www.apache.org/foundation/',rel:''},
- { text: '执照', link:
'http://www.apache.org/licenses/',rel:''},
- { text: '安全', link:
'http://www.apache.org/security/',rel:''},
- { text: '赞助', link:
'http://www.apache.org/foundation/sponsorship.html',rel:''},
- { text: '致谢', link:
'http://www.apache.org/foundation/thanks.html',rel:''},
- { text: '现在发生的事', link:
'http://www.apache.org/events/current-event',rel:''},
+ { text: '基础', link:
'http://www.apache.org/',target:'_self', rel:''},
+ { text: '执照', link:
'http://www.apache.org/licenses/',target:'_self', rel:''},
+ { text: '安全', link:
'http://www.apache.org/security/',target:'_self', rel:''},
+ { text: '赞助', link:
'http://www.apache.org/foundation/sponsorship.html',target:'_self', rel:''},
+ { text: '致谢', link:
'http://www.apache.org/foundation/thanks.html',target:'_self', rel:''},
+ { text: '现在发生的事', link:
'http://www.apache.org/events/current-event',target:'_self', rel:''},
Review comment:
翻译为：“活动”
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] vesense removed a comment on issue #929: [IOTDB-565] MQTT Protocol Support
vesense removed a comment on issue #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929#issuecomment-610937660 oh, exists some conflicting files due to flink-tsfile merged to master. I will update. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #1011: [IOTDB-583] fix concurrent modification exception
qiaojialin opened a new pull request #1011: [IOTDB-583] fix concurrent modification exception URL: https://github.com/apache/incubator-iotdb/pull/1011 The upgrade thread traverses the list while new resources is added. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] SailVR opened a new pull request #1010: modify site & docs
SailVR opened a new pull request #1010: modify site & docs URL: https://github.com/apache/incubator-iotdb/pull/1010 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1008: enable compression in session pool
qiaojialin merged pull request #1008: enable compression in session pool URL: https://github.com/apache/incubator-iotdb/pull/1008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 merged pull request #1009: Revert "[IOTDB-578] Cluster module should use the same thrift version with io…"
jt2594838 merged pull request #1009: Revert "[IOTDB-578] Cluster module should use the same thrift version with io…" URL: https://github.com/apache/incubator-iotdb/pull/1009 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on issue #986: [IOTDB-578] Cluster module should use the same thrift version with io…
jt2594838 commented on issue #986: [IOTDB-578] Cluster module should use the same thrift version with io… URL: https://github.com/apache/incubator-iotdb/pull/986#issuecomment-610943497 thrift 0.13.0 used by the stand-alone IoTDB will cause bugs in Mac OS and that is why we use a separate version in the distributed version. PLEASE, do not merge any outside code without informing the committers who are working on this branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 opened a new pull request #1009: Revert "[IOTDB-578] Cluster module should use the same thrift version with io…"
jt2594838 opened a new pull request #1009: Revert "[IOTDB-578] Cluster module should use the same thrift version with io…" URL: https://github.com/apache/incubator-iotdb/pull/1009 Reverts apache/incubator-iotdb#986 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] vesense commented on issue #929: [IOTDB-565] MQTT Protocol Support
vesense commented on issue #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929#issuecomment-610937660 oh, exists some conflicting files due to flink-tsfile merged to master. I will update. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] vesense edited a comment on issue #929: [IOTDB-565] MQTT Protocol Support
vesense edited a comment on issue #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929#issuecomment-610907774 @jixuan1989 I merged the master again, and all tests passed.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin merged pull request #947: [IOTDB-560] add TsFileInputFormat for reading TsFiles on flink.
qiaojialin merged pull request #947: [IOTDB-560] add TsFileInputFormat for reading TsFiles on flink. URL: https://github.com/apache/incubator-iotdb/pull/947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #947: [IOTDB-560] add TsFileInputFormat for reading TsFiles on flink.
qiaojialin commented on a change in pull request #947: [IOTDB-560] add
TsFileInputFormat for reading TsFiles on flink.
URL: https://github.com/apache/incubator-iotdb/pull/947#discussion_r405483729
##
File path:
example/flink/src/main/java/org/apache/iotdb/flink/FlinkTsFileStreamSource.java
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.iotdb.flink;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.datastream.DataStreamUtils;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.types.Row;
+import org.apache.iotdb.flink.tsfile.RowRowRecordParser;
+import org.apache.iotdb.flink.tsfile.TsFileInputFormat;
+import org.apache.iotdb.tsfile.common.constant.QueryConstant;
+import org.apache.iotdb.tsfile.read.common.Path;
+import org.apache.iotdb.tsfile.read.expression.QueryExpression;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
+import java.util.stream.Collectors;
+
+/**
+ * The example of reading TsFile via Flink DataStream API.
+ */
+public class FlinkTsFileStreamSource {
+
+ public static void main(String[] args) throws IOException {
+ String path = "test.tsfile";
+ TsFlieUtils.writeTsFile(path);
+ new File(path).deleteOnExit();
+ String[] filedNames = {
+ QueryConstant.RESERVED_TIME,
+ "device_1.sensor_1",
+ "device_1.sensor_2",
+ "device_1.sensor_3",
+ "device_2.sensor_1",
+ "device_2.sensor_2",
+ "device_2.sensor_3"
+ };
+ TypeInformation[] typeInformations = new TypeInformation[] {
+ Types.LONG,
+ Types.LONG,
+ Types.LONG,
+ Types.LONG,
+ Types.LONG,
+ Types.LONG,
+ Types.LONG
+ };
+ List paths = Arrays.stream(filedNames)
+ .filter(s -> !s.equals(QueryConstant.RESERVED_TIME))
+ .map(Path::new)
+ .collect(Collectors.toList());
+ RowTypeInfo rowTypeInfo = new RowTypeInfo(typeInformations,
filedNames);
+ QueryExpression queryExpression = QueryExpression.create(paths,
null);
Review comment:
I see, thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on issue #1008: enable compression in session pool
sonarcloud[bot] removed a comment on issue #1008: enable compression in session pool URL: https://github.com/apache/incubator-iotdb/pull/1008#issuecomment-610868678 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1008) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1008=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1008=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #1008: enable compression in session pool
sonarcloud[bot] commented on issue #1008: enable compression in session pool URL: https://github.com/apache/incubator-iotdb/pull/1008#issuecomment-610922299 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1008) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1008=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1008=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] SailVR closed pull request #1006: upgrade vuepress to 1.3
SailVR closed pull request #1006: upgrade vuepress to 1.3 URL: https://github.com/apache/incubator-iotdb/pull/1006 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] vesense commented on issue #929: [IOTDB-565] MQTT Protocol Support
vesense commented on issue #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929#issuecomment-610907774 @jixuan1989 I merged the master again, and all tests passed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on issue #1008: enable compression in session pool
jixuan1989 commented on issue #1008: enable compression in session pool URL: https://github.com/apache/incubator-iotdb/pull/1008#issuecomment-610885577 Hi, please add an ignore annotation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #1008: enable compression in session pool
sonarcloud[bot] commented on issue #1008: enable compression in session pool URL: https://github.com/apache/incubator-iotdb/pull/1008#issuecomment-610868678 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1008=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1008) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1008=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1008=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1007: not delete incompatible file in file level api
qiaojialin merged pull request #1007: not delete incompatible file in file level api URL: https://github.com/apache/incubator-iotdb/pull/1007 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on issue #1007: not delete incompatible file in file level api
sonarcloud[bot] commented on issue #1007: not delete incompatible file in file level api URL: https://github.com/apache/incubator-iotdb/pull/1007#issuecomment-610832354 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1007=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1007=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1007=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1007=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1007=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1007=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1007=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1007=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1007=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1007=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1007=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1007) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1007=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1007=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #1008: enable compression in session pool
qiaojialin opened a new pull request #1008: enable compression in session pool URL: https://github.com/apache/incubator-iotdb/pull/1008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] vesense commented on issue #1007: not delete incompatible file in file level api
vesense commented on issue #1007: not delete incompatible file in file level api URL: https://github.com/apache/incubator-iotdb/pull/1007#issuecomment-610809613 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #1007: not delete incompatible file in file level api
qiaojialin opened a new pull request #1007: not delete incompatible file in file level api URL: https://github.com/apache/incubator-iotdb/pull/1007 Only delete incompatible file in the server. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] WeiZhong94 commented on a change in pull request #947: [IOTDB-560] add TsFileInputFormat for reading TsFiles on flink.
WeiZhong94 commented on a change in pull request #947: [IOTDB-560] add
TsFileInputFormat for reading TsFiles on flink.
URL: https://github.com/apache/incubator-iotdb/pull/947#discussion_r405289563
##
File path:
example/flink/src/main/java/org/apache/iotdb/flink/FlinkTsFileStreamSource.java
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.iotdb.flink;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeinfo.Types;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.datastream.DataStreamUtils;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.types.Row;
+import org.apache.iotdb.flink.tsfile.RowRowRecordParser;
+import org.apache.iotdb.flink.tsfile.TsFileInputFormat;
+import org.apache.iotdb.tsfile.common.constant.QueryConstant;
+import org.apache.iotdb.tsfile.read.common.Path;
+import org.apache.iotdb.tsfile.read.expression.QueryExpression;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
+import java.util.stream.Collectors;
+
+/**
+ * The example of reading TsFile via Flink DataStream API.
+ */
+public class FlinkTsFileStreamSource {
+
+ public static void main(String[] args) throws IOException {
+ String path = "test.tsfile";
+ TsFlieUtils.writeTsFile(path);
+ new File(path).deleteOnExit();
+ String[] filedNames = {
+ QueryConstant.RESERVED_TIME,
+ "device_1.sensor_1",
+ "device_1.sensor_2",
+ "device_1.sensor_3",
+ "device_2.sensor_1",
+ "device_2.sensor_2",
+ "device_2.sensor_3"
+ };
+ TypeInformation[] typeInformations = new TypeInformation[] {
+ Types.LONG,
+ Types.LONG,
+ Types.LONG,
+ Types.LONG,
+ Types.LONG,
+ Types.LONG,
+ Types.LONG
+ };
+ List paths = Arrays.stream(filedNames)
+ .filter(s -> !s.equals(QueryConstant.RESERVED_TIME))
+ .map(Path::new)
+ .collect(Collectors.toList());
+ RowTypeInfo rowTypeInfo = new RowTypeInfo(typeInformations,
filedNames);
+ QueryExpression queryExpression = QueryExpression.create(paths,
null);
Review comment:
If `TsFileInputFormat` only accepts the `RowRowRecordParser`(default
implementation of `RowRecordParser` which parses the `RowRecord` to `Row`) then
the answer is "yes". But the `TsFileInputFormat` is designed to accept any
`RowRecordParser`, which may be implemented by users or 3rd parities. If the
output type of `RowRecordParser` is not a Row, this approach may not work.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support
jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929#issuecomment-610773022 Hi, yes I noticed the error. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] vesense commented on issue #929: [IOTDB-565] MQTT Protocol Support
vesense commented on issue #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929#issuecomment-610769370 @jixuan1989 Now there is a tsfile test error which is unrelated to mqtt after I merged the master to current branch. Maybe someone should fix it first. And we should take effort to keep the master branch always passing the CI. > [ERROR] Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.039 s <<< FAILURE! - in org.apache.iotdb.tsfile.write.writer.RestorableTsFileIOWriterTest > [ERROR] testBadHeadMagic(org.apache.iotdb.tsfile.write.writer.RestorableTsFileIOWriterTest) Time elapsed: 0.001 s <<< ERROR! > java.lang.Exception: Unexpected exception, expected but was >at org.apache.iotdb.tsfile.write.writer.RestorableTsFileIOWriterTest.testBadHeadMagic(RestorableTsFileIOWriterTest.java:71) > This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
