[GitHub] [iotdb] ZhanGHanG9991 opened a new pull request, #8904: [IOTDB-5432] Use freemarker to generate eventWindow and eventWindowManager
ZhanGHanG9991 opened a new pull request, #8904: URL: https://github.com/apache/iotdb/pull/8904 ## Description Use freemarker to generate eventWindow and eventWindowManager. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [ ] concurrent read and write - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. - [ ] added or updated version, __license__, or notice information - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage. - [ ] added integration tests. - [ ] been tested in a test IoTDB cluster. # Key changed/added classes (or packages if there are too many classes) in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] THUMarkLau merged pull request #8879: [IOTDB-5140] Add metrics for compaction deserializing pages or writing chunks
THUMarkLau merged PR #8879: URL: https://github.com/apache/iotdb/pull/8879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8879: [IOTDB-5140] Add metrics for compaction deserializing pages or writing chunks
sonarcloud[bot] commented on PR #8879: URL: https://github.com/apache/iotdb/pull/8879#issuecomment-1398203412 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8879) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8879=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8879=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8879=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=CODE_SMELL) [36 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8879=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8879=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8879=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8879=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] THUMarkLau commented on pull request #8879: [IOTDB-5140] Add metrics for compaction deserializing pages or writing chunks
THUMarkLau commented on PR #8879: URL: https://github.com/apache/iotdb/pull/8879#issuecomment-1398203033 I have done some performance test for this PR. For inner sequence space compaction, file num is 23, total file size is 4.0GB. For inner unsequence space compaction, file num is 22, total file size is 4.7GB. For cross space compaction, sequence file num is 1, unsequence file num is 1, sequence file size is 4.0GB, unsequence file size is 4.7 GB. | | master(030302c96582f)| IOTDB-5140 | |||| |Inner-Seq| 281 s| 271 s | |Inner-Unseq| 235 s| 239 s | |Cross| 492 s| 501 s | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Beyyes merged pull request #8901: [IOTDB-5287] Added status “Discouraged” to RegionGroup
Beyyes merged PR #8901: URL: https://github.com/apache/iotdb/pull/8901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] github-actions[bot] commented on issue #8903: maven error in China, https://github.com:443: The target server failed to respond
github-actions[bot] commented on issue #8903: URL: https://github.com/apache/iotdb/issues/8903#issuecomment-1386714239 Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] zhangchunsheng opened a new issue, #8903: maven error in China, https://github.com:443: The target server failed to respond
zhangchunsheng opened a new issue, #8903:
URL: https://github.com/apache/iotdb/issues/8903
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/iotdb/issues) and
found nothing similar.
### Version
1.0.0
### Describe the bug and provide the minimal reproduce step
```
mvn clean package -pl distribution -am -DskipTests
```
```
Downloaded from central:
https://repo.maven.apache.org/maven2/org/sonatype/plexus/plexus-sec-dispatcher/1.4/plexus-sec-dispatcher-1.4.jar
(28 kB at 11 kB/s)
Jan 18, 2023 8:50:16 AM org.apache.http.impl.execchain.RetryExec execute
INFO: I/O exception (org.apache.http.NoHttpResponseException) caught when
processing request to {s}->https://github.com:443: The target server failed to
respond
Jan 18, 2023 8:50:16 AM org.apache.http.impl.execchain.RetryExec execute
INFO: Retrying request to {s}->https://github.com:443
Jan 18, 2023 8:53:19 AM org.apache.http.impl.execchain.RetryExec execute
INFO: I/O exception (org.apache.http.NoHttpResponseException) caught when
processing request to {s}->https://github.com:443: The target server failed to
respond
Jan 18, 2023 8:53:19 AM org.apache.http.impl.execchain.RetryExec execute
INFO: Retrying request to {s}->https://github.com:443
Jan 18, 2023 8:56:23 AM org.apache.http.impl.execchain.RetryExec execute
INFO: I/O exception (org.apache.http.NoHttpResponseException) caught when
processing request to {s}->https://github.com:443: The target server failed to
respond
Jan 18, 2023 8:56:23 AM org.apache.http.impl.execchain.RetryExec execute
INFO: Retrying request to {s}->https://github.com:443
[WARNING] Could not get content
org.apache.http.NoHttpResponseException: github.com:443 failed to respond
at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead
(DefaultHttpResponseParser.java:141)
at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead
(DefaultHttpResponseParser.java:56)
at org.apache.http.impl.io.AbstractMessageParser.parse
(AbstractMessageParser.java:259)
at
org.apache.http.impl.DefaultBHttpClientConnection.receiveResponseHeader
(DefaultBHttpClientConnection.java:163)
at org.apache.http.impl.conn.CPoolProxy.receiveResponseHeader
(CPoolProxy.java:157)
at org.apache.http.protocol.HttpRequestExecutor.doReceiveResponse
(HttpRequestExecutor.java:273)
at org.apache.http.protocol.HttpRequestExecutor.execute
(HttpRequestExecutor.java:125)
at org.apache.http.impl.execchain.MainClientExec.execute
(MainClientExec.java:272)
at org.apache.http.impl.execchain.ProtocolExec.execute
(ProtocolExec.java:186)
at org.apache.http.impl.execchain.RetryExec.execute (RetryExec.java:89)
at org.apache.http.impl.execchain.RedirectExec.execute
(RedirectExec.java:110)
at org.apache.http.impl.client.InternalHttpClient.doExecute
(InternalHttpClient.java:185)
at org.apache.http.impl.client.CloseableHttpClient.execute
(CloseableHttpClient.java:72)
at org.apache.http.impl.client.CloseableHttpClient.execute
(CloseableHttpClient.java:221)
at org.apache.http.impl.client.CloseableHttpClient.execute
(CloseableHttpClient.java:165)
at
com.googlecode.download.maven.plugin.internal.HttpFileRequester.download
(HttpFileRequester.java:56)
at com.googlecode.download.maven.plugin.internal.WGet.doGet
(WGet.java:576)
at com.googlecode.download.maven.plugin.internal.WGet.execute
(WGet.java:434)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:370)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:351)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:215)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:171)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:163)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
at
[GitHub] [iotdb] bigreybear opened a new pull request, #8902: Update SchemaFile to be compatible with MeasurementSchema.props
bigreybear opened a new pull request, #8902: URL: https://github.com/apache/iotdb/pull/8902 Previously, `SchemaFile` did not store `MeasurementSchema.Props` as it is a variable length and relatively less efficient field to store into persistent media. To support full capability of metadata under high cardinality circumstance, `SchemaFile` will store/restore this `Map` after then. This update will cost at least 4 bytes more per measurement record in `SchemaFile`, and malicious long property key or value may cause overflow exception withou decent guradian statements for property's assignment. Well-optimized access methods for constrained property set is expected in further development. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8891: [IOTDB-5425] Consolidate all ConfigNodeClient to be managed by clientManager
sonarcloud[bot] commented on PR #8891: URL: https://github.com/apache/iotdb/pull/8891#issuecomment-1386615367 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8891) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8891=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8891=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8891=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8891=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8891=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8891=new_duplicated_lines_density=list) [5.6% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8891=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8895: [To rel/1.0][IOTDB-5061] Add message in RatisRequestFailed
OneSizeFitsQuorum merged PR #8895: URL: https://github.com/apache/iotdb/pull/8895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8894: [To rel/1.0][IOTDB-5176] Change ratis snapshot dir with datadir
OneSizeFitsQuorum merged PR #8894: URL: https://github.com/apache/iotdb/pull/8894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8893: [To rel/1.0][IOTDB-5153] Fix dead lock in confignode
OneSizeFitsQuorum merged PR #8893: URL: https://github.com/apache/iotdb/pull/8893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8897: [To rel/1.0][IOTDB-5429] Disable first election in RatisConsensus UT to avoid inconsistency states
OneSizeFitsQuorum merged PR #8897: URL: https://github.com/apache/iotdb/pull/8897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8896: [IOTDB-5429] Disable first election in RatisConsensus UT to avoid inconsistency states
OneSizeFitsQuorum merged PR #8896: URL: https://github.com/apache/iotdb/pull/8896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #8900: Fix files with unapporved license error after running OpenIdAuthorizerTest
HTHou merged PR #8900: URL: https://github.com/apache/iotdb/pull/8900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #8892: Add distance-based outlier detection funtion
JackieTien97 merged PR #8892: URL: https://github.com/apache/iotdb/pull/8892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Caideyipi opened a new pull request, #8901: [IOTDB-5287] Added status “Discouraged” to RegionGroup
Caideyipi opened a new pull request, #8901: URL: https://github.com/apache/iotdb/pull/8901 ## IOTDB-5287 ### New status "Discouraged“ Use new status "Discouraged" to solve this problem. The partition allocation IT is added as well. The document link is as follows: https://apache-iotdb.feishu.cn/docx/doxcnMQppTJCURUuWZ5LfWA5dK6 ### Region Migration fix Now the Regions with type Unknown are not supported to migrate. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [ ] concurrent read and write - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. - [ ] added or updated version, __license__, or notice information - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage. - [ ] added integration tests. - [ ] been tested in a test IoTDB cluster. # Key changed/added classes (or packages if there are too many classes) in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Caideyipi closed pull request #8872: [IOTDB-5287] Added status “Discouraged” to RegionGroup
Caideyipi closed pull request #8872: [IOTDB-5287] Added status “Discouraged” to RegionGroup URL: https://github.com/apache/iotdb/pull/8872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8900: Fix files with unapporved license error after running OpenIdAuthorizerTest
sonarcloud[bot] commented on PR #8900: URL: https://github.com/apache/iotdb/pull/8900#issuecomment-1386456099 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8900) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8900=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8900=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8900=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8900=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8900=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8900=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8900=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8900=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8900=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8900=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8900=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8900=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8900=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8900=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8900=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] HTHou opened a new pull request, #8900: Fix files with unapporved license error after running OpenIdAuthorizerTest
HTHou opened a new pull request, #8900: URL: https://github.com/apache/iotdb/pull/8900 ## Description  The issue caused by OpenIdAuthorizerTest didn't call EnvironmentUtils.envSetUp() before tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] xingtanzjr opened a new pull request, #8899: [to rc/1.0.1] [IOTDB-5266] Refine the code of cross selector and fix the bug when using FileTImeIndex
xingtanzjr opened a new pull request, #8899: URL: https://github.com/apache/iotdb/pull/8899 ## Description * refine the code of cross selector * fix the bug that some seq files may be lost when selecting cross compaction task if the seq file using FileTimeIndex See this issue for details https://issues.apache.org/jira/browse/IOTDB-5266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #8898: Revert "[IOTDB-5415] Move parameters into correct ConfigClass (#8867)"
qiaojialin merged PR #8898: URL: https://github.com/apache/iotdb/pull/8898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] ericpai merged pull request #8890: [IOTDB-5423] Disable reusing same JVM and processing in random order in tests
ericpai merged PR #8890: URL: https://github.com/apache/iotdb/pull/8890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8898: Revert "[IOTDB-5415] Move parameters into correct ConfigClass (#8867)"
sonarcloud[bot] commented on PR #8898: URL: https://github.com/apache/iotdb/pull/8898#issuecomment-1385653880 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8898) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8898=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8898=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8898=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8898=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8898=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8898=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8898=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8898=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8898=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8898=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8898=false=CODE_SMELL) [265 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8898=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8898=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8898=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8898=new_duplicated_lines_density=list) [1.1% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8898=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #8870: [IOTDB-5382]Support DIFF as built-in scalar function in IoTDB
JackieTien97 merged PR #8870: URL: https://github.com/apache/iotdb/pull/8870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] lancelly commented on a diff in pull request #8892: Add distance-based outlier detection funtion
lancelly commented on code in PR #8892: URL: https://github.com/apache/iotdb/pull/8892#discussion_r1072091783 ## library-udf/src/main/java/org/apache/iotdb/library/anomaly/UDTFOutlier.java: ## @@ -0,0 +1,77 @@ +package org.apache.iotdb.library.anomaly; Review Comment: Add license for this file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] SzyWilliam opened a new pull request, #8897: [To rel/1.0][IOTDB-5429] Disable first election in RatisConsensus to avoid inconsistency states
SzyWilliam opened a new pull request, #8897: URL: https://github.com/apache/iotdb/pull/8897 cherry pick of https://github.com/apache/iotdb/pull/8896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] SzyWilliam opened a new pull request, #8896: [IOTDB-5429] Disable first election in RatisConsensus to avoid inconsistency states
SzyWilliam opened a new pull request, #8896: URL: https://github.com/apache/iotdb/pull/8896 First election in CI env is causing frequent elections that will interrupt the normal operations of Raft progressing. To make matters worse, together with a recently spotted bug in matchIndex https://github.com/apache/ratis/pull/805, it may cause permanent inconsistency issues. The erroneous event sequence are as follows, 1. Member 1 becomes the leader. 2. Leader 1 initializes the state, writes the first log (index=0) as an configuration entry. 3. This entry is mistakenly committed and be applied to Leader 1's StateMachine due to incorrect matchIndex. Before 1 could appendEntries to 2/3, 2 & 3 both timeout and started election. 4. 2‘s requestVote has a higher term and forces Leader 1 down. 5. 2 becomes the new Leader, also writing the first log (index = 0) as an configuration entry. Inconsistent appendEntries occurred when 2 tries to sync log to 1. And the group cannot automatically recover from this inconsistency. NOTICE: Disable first elections will not TOTALLY resolve this CI issue, but to reduce its reproduce possibility to a minimal. The total resolution depends on Ratis new releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] SzyWilliam opened a new pull request, #8895: [To rel/1.0][IOTDB-5061] cherry pick of pull 8449
SzyWilliam opened a new pull request, #8895: URL: https://github.com/apache/iotdb/pull/8895 cherry pick of https://github.com/apache/iotdb/pull/8449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] SzyWilliam opened a new pull request, #8894: [To rel/1.0][IOTDB-5176] Cherry pick of pull 8489
SzyWilliam opened a new pull request, #8894: URL: https://github.com/apache/iotdb/pull/8894 cherry pick of https://github.com/apache/iotdb/pull/8489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] SzyWilliam opened a new pull request, #8893: [To rel/1.0][IOTDB-5153] Cherry pick of pull/8470
SzyWilliam opened a new pull request, #8893: URL: https://github.com/apache/iotdb/pull/8893 Cherry pick of https://github.com/apache/iotdb/pull/8470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8890: [IOTDB-5423] Disable reusing same JVM and processing in random order in tests
sonarcloud[bot] commented on PR #8890: URL: https://github.com/apache/iotdb/pull/8890#issuecomment-1384980248 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8890) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8890=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8890=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8890=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8890=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8890=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8890=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8891: [IOTDB-5425] Consolidate all ConfigNodeClient to be managed by clientManager
sonarcloud[bot] commented on PR #8891: URL: https://github.com/apache/iotdb/pull/8891#issuecomment-1384976192 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8891) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8891=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8891=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8891=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8891=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8891=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8891=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8891=new_duplicated_lines_density=list) [5.6% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8891=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] liuminghui233 merged pull request #8889: research/LSM-quantile Add quantile summary for tsfile
liuminghui233 merged PR #8889: URL: https://github.com/apache/iotdb/pull/8889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] iotdb-lsmod opened a new pull request, #8892: Add outlier function statements in docs
iotdb-lsmod opened a new pull request, #8892: URL: https://github.com/apache/iotdb/pull/8892 Add the statements about outlier function in docs/User-Guide/Operators-Functions/Anomaly-Detection.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum opened a new pull request, #8891: [IOTDB-5425] Consolidate all ConfigNodeClient to be managed by clientManager
OneSizeFitsQuorum opened a new pull request, #8891: URL: https://github.com/apache/iotdb/pull/8891 see [jira5425](https://issues.apache.org/jira/browse/IOTDB-5425) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8890: [IOTDB-5423] Disable reusing same JVM and processing in random order in tests
sonarcloud[bot] commented on PR #8890: URL: https://github.com/apache/iotdb/pull/8890#issuecomment-1384944748 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8890) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8890=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8890=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8890=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8890=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8890=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8890=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] ericpai opened a new pull request, #8890: [IOTDB-5423] Disable reusing same JVM and processing in random order in tests
ericpai opened a new pull request, #8890: URL: https://github.com/apache/iotdb/pull/8890 See JIRA: https://issues.apache.org/jira/browse/IOTDB-5423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] czllgzmzl opened a new pull request, #8889: research/LSM-quantile Add quantile summary for tsfile
czllgzmzl opened a new pull request, #8889: URL: https://github.com/apache/iotdb/pull/8889 ## Description add quantile summary for tsfile ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [ ] concurrent read and write - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. - [ ] added or updated version, __license__, or notice information - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage. - [ ] added integration tests. - [ ] been tested in a test IoTDB cluster. # Key changed/added classes (or packages if there are too many classes) in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] czllgzmzl closed pull request #8888: Research/lsm quantile Hierarchical quantile summaries for TSFile
czllgzmzl closed pull request #: Research/lsm quantile Hierarchical quantile summaries for TSFile URL: https://github.com/apache/iotdb/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] czllgzmzl opened a new pull request, #8888: Research/lsm quantile Hierarchical quantile summaries for TSFile
czllgzmzl opened a new pull request, #: URL: https://github.com/apache/iotdb/pull/ ## Description Add hierarchical quantile summaries for TSFile. Hierarchical quantile summaries are built in LSM compaction (merge) events. Research only. ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [ ] concurrent read and write - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. - [ ] added or updated version, __license__, or notice information - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage. - [ ] added integration tests. - [ ] been tested in a test IoTDB cluster. # Key changed/added classes (or packages if there are too many classes) in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Wei-hao-Li commented on a diff in pull request #8870: [IOTDB-5382]Support DIFF as built-in scalar function in IoTDB
Wei-hao-Li commented on code in PR #8870: URL: https://github.com/apache/iotdb/pull/8870#discussion_r1071708871 ## docs/zh/UserGuide/Operators-Functions/Overview.md: ## @@ -216,6 +216,11 @@ OR, |, || | DERIVATIVE | INT32 / INT64 / FLOAT / DOUBLE | DOUBLE | 统计序列中某数据点相对于前一数据点的变化率，数量上等同于 DIFFERENCE / TIME_DIFFERENCE。范围内第一个数据点没有对应的结果输出。 | | NON_NEGATIVE_DERIVATIVE | INT32 / INT64 / FLOAT / DOUBLE | DOUBLE | 统计序列中某数据点相对于前一数据点的变化率的绝对值，数量上等同于 NON_NEGATIVE_DIFFERENCE / TIME_DIFFERENCE。范围内第一个数据点没有对应的结果输出。 | + +| 函数名 | 输入序列类型 | 参数 | 输出序列类型 | 功能描述 | Review Comment: > Does english doc have overview section? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #8870: [IOTDB-5382]Support DIFF as built-in scalar function in IoTDB
JackieTien97 commented on code in PR #8870:
URL: https://github.com/apache/iotdb/pull/8870#discussion_r1071694767
##
integration-test/src/test/java/org/apache/iotdb/db/it/builtinfunction/scalar/IoTDBDiffFunctionIT.java:
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.it.builtinfunction.scalar;
+
+import org.apache.iotdb.it.env.EnvFactory;
+import org.apache.iotdb.it.framework.IoTDBTestRunner;
+import org.apache.iotdb.itbase.category.ClusterIT;
+import org.apache.iotdb.itbase.category.LocalStandaloneIT;
+
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.runner.RunWith;
+
+import static org.apache.iotdb.db.it.utils.TestUtils.prepareData;
+import static org.apache.iotdb.db.it.utils.TestUtils.resultSetEqualTest;
+import static org.apache.iotdb.itbase.constant.TestConstant.TIMESTAMP_STR;
+
+@RunWith(IoTDBTestRunner.class)
+@Category({LocalStandaloneIT.class, ClusterIT.class})
+public class IoTDBDiffFunctionIT {
Review Comment:
add more test case as we discussed
[here](https://apache-iotdb.feishu.cn/docx/CPbIddG8joqt0QxmPrrcMMw4nae)
##
server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/ExpressionAnalyzer.java:
##
@@ -1267,4 +1268,36 @@ public static Expression bindTypeForTimeSeriesOperand(
"unsupported expression type: " + predicate.getExpressionType());
}
}
+
+ public static boolean isDeviceViewNeedSpecialProcess(Expression predicate) {
Review Comment:
```suggestion
public static boolean isDeviceViewNeedSpecialProcess(Expression
expression) {
```
##
node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/BuiltinScalarFunction.java:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.commons.udf.builtin;
+
+import com.google.common.collect.ImmutableSet;
+
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+public enum BuiltinScalarFunction {
+ DIFF("diff"),
+ ;
+
+ private final String functionName;
+
+ BuiltinScalarFunction(String functionName) {
+this.functionName = functionName;
+ }
+
+ public String getFunctionName() {
+return functionName;
+ }
+
+ private static final Set NATIVE_FUNCTION_NAMES =
+ new HashSet<>(
+ Arrays.stream(BuiltinScalarFunction.values())
+ .map(BuiltinScalarFunction::getFunctionName)
+ .collect(Collectors.toList()));
+
+ public static final Set DEVICE_VIEW_SPECIAL_PROCESS_FUNCTIONS =
ImmutableSet.of("diff");
Review Comment:
add some comments to explain this field, like
we shouldn't apply these functions to each DataRegion for one device,
because these functions need all data to calculate correct result. So we need
to collect all data for one device in one DataRegion, and then apply these
functions to only that one DataRegion.
##
docs/zh/UserGuide/Operators-Functions/Overview.md:
##
@@ -216,6 +216,11 @@ OR, |, ||
| DERIVATIVE | INT32 / INT64 / FLOAT / DOUBLE |
DOUBLE | 统计序列中某数据点相对于前一数据点的变化率，数量上等同于 DIFFERENCE /
TIME_DIFFERENCE。范围内第一个数据点没有对应的结果输出。 |
| NON_NEGATIVE_DERIVATIVE | INT32 / INT64 / FLOAT / DOUBLE |
DOUBLE
[GitHub] [iotdb] qiaojialin merged pull request #8887: Fix IDEA DataNode cannot start bug
qiaojialin merged PR #8887: URL: https://github.com/apache/iotdb/pull/8887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #8886: [IOTDB-5424] Fix FI memory allocation limit calculation
JackieTien97 merged PR #8886: URL: https://github.com/apache/iotdb/pull/8886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8821: [IOTDB-5381] Formatting variables output
sonarcloud[bot] commented on PR #8821: URL: https://github.com/apache/iotdb/pull/8821#issuecomment-1384282093 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8821) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8821=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8821=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8821=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8821=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8821=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8821=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8821=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8821=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8821=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8821=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8821=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8821=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8821=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8821=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8821=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8821=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] SpriCoder merged pull request #8874: [To rel/0.13][IOTDB-5407] metrics for .mods file count
SpriCoder merged PR #8874: URL: https://github.com/apache/iotdb/pull/8874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8886: [IOTDB-5424] Fix FI memory allocation limit calculation
sonarcloud[bot] commented on PR #8886: URL: https://github.com/apache/iotdb/pull/8886#issuecomment-1383849093 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8886) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8886=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8886=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8886=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8886=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8886=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8886=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8886=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8886=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8886=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8886=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8886=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8886=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8886=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8886=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8886=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8886=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Beyyes merged pull request #8884: [To rel/1.0][IOTDB-5266] Refine the code of cross selector and fix the bug when using FileTImeIndex
Beyyes merged PR #8884: URL: https://github.com/apache/iotdb/pull/8884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] ericpai opened a new pull request, #8886: [IOTDB-5424] Fix FI memory allocation limit calculation
ericpai opened a new pull request, #8886: URL: https://github.com/apache/iotdb/pull/8886 See JIRA: https://issues.apache.org/jira/browse/IOTDB-5424 This PR also includes a logging enhancement, and IT fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] liuminghui233 merged pull request #8885: Add Distance-based Outlier Detection Function
liuminghui233 merged PR #8885: URL: https://github.com/apache/iotdb/pull/8885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] iotdb-lsmod opened a new pull request, #8885: Add Distance-based Outlier Detection Function
iotdb-lsmod opened a new pull request, #8885: URL: https://github.com/apache/iotdb/pull/8885 ## Add Distance-based Outlier Detection Function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] ericpai merged pull request #8883: [To rel/1.0][IOTDB-5417] Fix missing hasNext() before next() in TagAggregationOperator
ericpai merged PR #8883: URL: https://github.com/apache/iotdb/pull/8883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8884: [IOTDB-5266] Refine the code of cross selector and fix the bug when using FileTImeIndex
sonarcloud[bot] commented on PR #8884: URL: https://github.com/apache/iotdb/pull/8884#issuecomment-1383614738 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8884) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8884=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8884=false=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8884=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8884=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8884=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8884=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8884=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8884=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8884=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8884=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8884=false=CODE_SMELL) [269 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8884=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8884=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8884=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8884=new_duplicated_lines_density=list) [0.6% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8884=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] xingtanzjr opened a new pull request, #8884: [IOTDB-5266] Refine the code of cross selector and fix the bug when using FileTImeIndex
xingtanzjr opened a new pull request, #8884: URL: https://github.com/apache/iotdb/pull/8884 ## Description * refine the code of cross selector * fix the bug that some seq files may be lost when selecting cross compaction task if the seq file using FileTimeIndex See this issue for details https://issues.apache.org/jira/browse/IOTDB-5266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8883: [To rel/1.0][IOTDB-5417] Fix missing hasNext() before next() in TagAggregationOperator
sonarcloud[bot] commented on PR #8883: URL: https://github.com/apache/iotdb/pull/8883#issuecomment-1383570822 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8883) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8883=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8883=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8883=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8883=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8883=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8883=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8883=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8883=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8883=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8883=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8883=false=CODE_SMELL) [264 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8883=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8883=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8883=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8883=new_duplicated_lines_density=list) [0.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8883=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] ericpai opened a new pull request, #8883: [To rel/1.0][IOTDB-5417] Fix missing hasNext() before next() in TagAggregationOperator
ericpai opened a new pull request, #8883: URL: https://github.com/apache/iotdb/pull/8883 A cherry-pick of #8882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #8882: [IOTDB-5417] Fix missing hasNext() before next() in TagAggregationOperator
JackieTien97 merged PR #8882: URL: https://github.com/apache/iotdb/pull/8882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8882: [IOTDB-5417] Fix missing hasNext() before next() in TagAggregationOperator
sonarcloud[bot] commented on PR #8882: URL: https://github.com/apache/iotdb/pull/8882#issuecomment-1383478802 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8882) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8882=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8882=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8882=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8882=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8882=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8882=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8882=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8882=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8882=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8882=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8882=false=CODE_SMELL) [151 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8882=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8882=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8882=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8882=new_duplicated_lines_density=list) [2.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8882=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] ericpai opened a new pull request, #8882: [IOTDB-5417] Fix missing hasNext() before next() in TagAggregationOperator
ericpai opened a new pull request, #8882: URL: https://github.com/apache/iotdb/pull/8882 See JIRA: https://issues.apache.org/jira/browse/IOTDB-5417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #8867: [IOTDB-5415] Move parameters into correct ConfigClass
qiaojialin merged PR #8867: URL: https://github.com/apache/iotdb/pull/8867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] github-actions[bot] commented on issue #8881: Can expression be instanceof AndFilter?
github-actions[bot] commented on issue #8881: URL: https://github.com/apache/iotdb/issues/8881#issuecomment-1383265849 Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] luciferz2021 opened a new issue, #8881: Can expression be instanceof AndFilter?
luciferz2021 opened a new issue, #8881: URL: https://github.com/apache/iotdb/issues/8881 https://github.com/apache/iotdb/blob/0f5ffdf96c48776ee9ef7f6bcde265da08ed637d/server/src/main/java/org/apache/iotdb/db/query/timegenerator/ServerTimeGenerator.java#L131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] LeiRui opened a new pull request, #8880: Add sampling attributes for M4
LeiRui opened a new pull request, #8880: URL: https://github.com/apache/iotdb/pull/8880 Previously, the M4 function supports two types of attribute inputs (actually two types of sliding windows): (1) Control the sliding **size** window using attributes `windowSize` and `slidingStep`. For example: `select M4(s1,'windowSize'='10','slidingStep'='10') as samples from root.vehicle.d1`. (2) Control the sliding **time** window using attributes `windowInterval`, `slidingStep`, `displayWindowBegin` and `displayWindowEnd`. For example: `select M4(s1,'windowInterval'='25','slidingStep'='25','displayWindowBegin'='0','displayWindowEnd'='100') as samples from root.vehicle.d1`. Motivated by real use cases, this pr enables controlling M4 using sampling attributes: `samplingInterval`, `samplingThreshold`, `displayWindowBegin`, `displayWindowEnd`. For example: `select M4(s1,'samplingInterval'='5','samplingThreshold'='100','displayWindowBegin'='0','displayWindowEnd'='150') as samples from root.vehicle.d1`. + `samplingInterval`: The sampling time interval length. Long data type. **Required**. + `samplingThreshold`: The upper limit of the number of sampling points. Long data type. Optional. If not set, default to 1. + `displayWindowBegin`: The starting position of the window (included). Long data type. **Required**. + `displayWindowEnd`: End time limit (excluded, essentially playing the same role as `WHERE time < displayWindowEnd`). Long data type. **Required**. The user-defined sampling time window is a special kind of sliding time window, which is special in that: 1. There is a conversion relationship between the length of the sliding time window `windowInterval` and the sampling time interval `samplingInterval`, see below for details. 2. The sliding step of the sliding time window `slidingStep` is fixed to be equal to the window length `windowInterval` here, so there is no need for the user to input the `slidingStep` parameter. 3. `displayWindowBegin` and `displayWindowEnd` are required parameters here. For simplicity, let $L=displayWindowEnd-displayWindowBegin$, $T=samplingInterval$, $t=windowInterval$, $M=samplingThreshold$. The conversion relationship between the length $t$ of the sliding time window and the sampling time interval $T$ is as follows: Consider two aspects: (1) M4 samples 4 points in a sliding time window, and (2) the upper limit of the number of sampling points must be satisfied. It is easy to know that given the sampling time interval $T$ specified by the user, the maximum number of sampling points is $\lceil L/T \rceil$; given the sliding time window length $t$, the maximum number of M4 sampling points is $\lceil L/t\rceil *4$. Therefore, the conversion idea is: if the length of the sliding time window set to be four times the sampling time interval (i.e., $t=4T $) can meet the upper limit of the number of sampling points, then set accordingly, otherwise adjust the length $t$ of the sliding time window to meet the upper limit of the number of sampling points. Formally: 1. If $\lceil L/T\rceil \le M-4$, then set $t=4*T$. At this time $L/T\le \lceil L/T\rceil\le M-4$, so $\lceil L/t\rceil *4=\lceil L/4T\rceil *4<(L/4T+1 )*4\le M$, that is, the maximum number of M4 sampling points does not exceed the upper limit of sampling points $M$. 2. Otherwise $\lceil L/T\rceil > M-4$, then set $t=\lceil 4L/(M-4) \rceil$. At this time $t=\lceil 4L/(M-4) \rceil\ge 4L/(M-4)$, so $\lceil L/t\rceil *4<(L/t+1)*4\le M$, that is, the maximum number of M4 sampling points does not exceed the upper limit of sampling points $M$. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Beyyes closed pull request #8797: [IOTDB-5310] Added removing status to region migration
Beyyes closed pull request #8797: [IOTDB-5310] Added removing status to region migration URL: https://github.com/apache/iotdb/pull/8797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Beyyes commented on pull request #8797: [IOTDB-5310] Added removing status to region migration
Beyyes commented on PR #8797: URL: https://github.com/apache/iotdb/pull/8797#issuecomment-1382682880 Follow up work: https://issues.apache.org/jira/browse/IOTDB-5419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] BUAAserein commented on a diff in pull request #8846: [IOTDB-5284] Fix some sonar bugs
BUAAserein commented on code in PR #8846:
URL: https://github.com/apache/iotdb/pull/8846#discussion_r1070222002
##
example/session/src/main/java/org/apache/iotdb/SessionExample.java:
##
@@ -828,18 +828,19 @@ private static void nonQuery() throws
IoTDBConnectionException, StatementExecuti
session.executeNonQueryStatement("insert into root.sg1.d1(timestamp,s1)
values(200, 1)");
}
- private static void setTimeout() throws StatementExecutionException {
-Session tempSession = new Session(LOCAL_HOST, 6667, "root", "root", 1,
2);
-tempSession.setQueryTimeout(6);
+ private static void setTimeout() throws StatementExecutionException,
IoTDBConnectionException {
+try (Session tempSession = new Session(LOCAL_HOST, 6667, "root", "root",
1, 2)) {
+ tempSession.setQueryTimeout(6);
+}
}
private static void createClusterSession() throws IoTDBConnectionException {
Review Comment:
ok
##
tsfile/src/main/java/org/apache/iotdb/tsfile/read/TsFileRestorableReader.java:
##
@@ -61,11 +61,12 @@ private void checkAndRepair() throws IOException {
if (!isComplete()) {
// Try to close it
logger.info("File {} has no correct tail magic, try to repair...", file);
- RestorableTsFileIOWriter rWriter =
- new
RestorableTsFileIOWriter(FSFactoryProducer.getFSFactory().getFile(file));
- TsFileWriter writer = new TsFileWriter(rWriter);
- // This writes the right magic string
- writer.close();
+ try (RestorableTsFileIOWriter rWriter =
+ new
RestorableTsFileIOWriter(FSFactoryProducer.getFSFactory().getFile(file))) {
+TsFileWriter writer = new TsFileWriter(rWriter);
+// This writes the right magic string
+writer.close();
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] MarcosZyk merged pull request #8878: [IOTDB-5396] Iterative interface for query about TagManager
MarcosZyk merged PR #8878: URL: https://github.com/apache/iotdb/pull/8878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #8877: [IOTDB-5412]Print Help Message when loading empty tsfile
HTHou merged PR #8877: URL: https://github.com/apache/iotdb/pull/8877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8867: [IOTDB-5415] Move parameters into correct ConfigClass
sonarcloud[bot] commented on PR #8867: URL: https://github.com/apache/iotdb/pull/8867#issuecomment-1382129781 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8867) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8867=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8867=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8867=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=CODE_SMELL) [151 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_duplicated_lines_density=list) [2.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8867: [IOTDB-5415] Move parameters into correct ConfigClass
sonarcloud[bot] commented on PR #8867: URL: https://github.com/apache/iotdb/pull/8867#issuecomment-1381942366 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8867) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8867=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8867=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8867=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=CODE_SMELL) [151 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_duplicated_lines_density=list) [2.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #8866: [IOTDB-5372] Support data type cast in SELECT INTO
JackieTien97 merged PR #8866: URL: https://github.com/apache/iotdb/pull/8866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] SpriCoder commented on pull request #8879: [IOTDB-5140] Add metrics for compaction deserializing pages or writing chunks
SpriCoder commented on PR #8879: URL: https://github.com/apache/iotdb/pull/8879#issuecomment-1381762247 Please check the bug that sonarCloud report -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8879: [IOTDB-5140] Add metrics for compaction deserializing pages or writing chunks
sonarcloud[bot] commented on PR #8879: URL: https://github.com/apache/iotdb/pull/8879#issuecomment-1381702871 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8879) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8879=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8879=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8879=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=CODE_SMELL) [38 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8879=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8879=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8879=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8879=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8879=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] SpriCoder merged pull request #8876: [To rel/1.0][IOTDB-5324] Fix wal cann't be deleted in destDataNode after region migration when data_replication_factor is 1 in IoTConsensus
SpriCoder merged PR #8876: URL: https://github.com/apache/iotdb/pull/8876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] THUMarkLau opened a new pull request, #8879: [IOTDB-5140] Add metrics for compaction deserializing pages or writing chunks
THUMarkLau opened a new pull request, #8879: URL: https://github.com/apache/iotdb/pull/8879 See [IOTDB-5140](https://issues.apache.org/jira/browse/IOTDB-5140). This PR add serveral metrics for compaction execution, especially for the method that the chunk is processed. There are three types of chunk process method, which are directly-flush, merged, and deserialized into points. Monitoring the method the chunk is compacted can benifit the tuning of compaction. https://user-images.githubusercontent.com/37140360/212306545-578c639f-9858-41ad-afca-e58277840428.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Cpaulyz opened a new pull request, #8878: [IOTDB-5396] Iterative interface for query about TagManager
Cpaulyz opened a new pull request, #8878: URL: https://github.com/apache/iotdb/pull/8878 ## Description * The current query interface relating to TagManager returns a collection of type list. For better adaptation to SchemaReader, iterator should be returned. * Delete useless code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #8840: Fix an issue regarding to data partition update
qiaojialin merged PR #8840: URL: https://github.com/apache/iotdb/pull/8840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8867: [IOTDB-5415] Move parameters into correct ConfigClass
sonarcloud[bot] commented on PR #8867: URL: https://github.com/apache/iotdb/pull/8867#issuecomment-1381555050 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8867) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8867=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8867=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8867=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=CODE_SMELL) [151 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_duplicated_lines_density=list) [2.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8867: [IOTDB-5415] Move parameters into correct ConfigClass
sonarcloud[bot] commented on PR #8867: URL: https://github.com/apache/iotdb/pull/8867#issuecomment-1381528758 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8867) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8867=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8867=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8867=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=CODE_SMELL) [151 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8867=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_duplicated_lines_density=list) [2.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8867=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #8875: [IOTDB-5412][To rel/1.0]Print Help Message when loading empty tsfile
HTHou merged PR #8875: URL: https://github.com/apache/iotdb/pull/8875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] zhengshubin commented on issue #8869: [Bug] iotdb 1.0 ,Not enough memory to execute current fragment instance
zhengshubin commented on issue #8869:
URL: https://github.com/apache/iotdb/issues/8869#issuecomment-1381521657
看了源码
private void checkMemory(Operator root, FragmentInstanceStateMachine
stateMachine)
throws MemoryNotEnoughException {
if
(!IoTDBDescriptor.getInstance().getConfig().isEnableQueryMemoryEstimation()) {
return;
}
long estimatedMemorySize = root.calculateMaxPeekMemory();
synchronized (this) {
if (estimatedMemorySize > freeMemoryForOperators) {
throw new MemoryNotEnoughException(
String.format(
"There is not enough memory to execute current fragment
instance, current remaining free memory is %d, estimated memory usage for
current fragment instance is %d",
freeMemoryForOperators, estimatedMemorySize),
TSStatusCode.MPP_MEMORY_NOT_ENOUGH.getStatusCode());
} else {
freeMemoryForOperators -= estimatedMemorySize;
每检查一次内存，freeMemoryForOperators 都会减少，当减少到
freeMemoryForOperators
[GitHub] [iotdb] Beyyes commented on a diff in pull request #8872: [IOTDB-5287] Added status “Discouraged” to RegionGroup
Beyyes commented on code in PR #8872:
URL: https://github.com/apache/iotdb/pull/8872#discussion_r1069118451
##
confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/RegionGroupStatus.java:
##
@@ -29,12 +29,19 @@ public enum RegionGroupStatus {
*/
Available("Available"),
+ /**
+ * All Regions in RegionGroup are in the Running, Unknown or ReadOnly
status, and at least 1 node
+ * is in ReadOnly status, the number of Regions in the Unknown or ReadOnly
status is less than
+ * half
+ */
+ Discouraged("Discouraged"),
+
/**
* The following cases will lead to Disabled RegionGroup:
*
- * 1. There is a Region in ReadOnly or Removing status
+ * 1. There is a Region in Removing status
Review Comment:
Maybe not exactly, if user is migrating one region, is the RegionGroup
Disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] ericpai merged pull request #8860: [IOTDB-5410] Refine IT: Refine Session and SessionPool IT
ericpai merged PR #8860: URL: https://github.com/apache/iotdb/pull/8860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] liuminghui233 merged pull request #8853: Add query metrics doc
liuminghui233 merged PR #8853: URL: https://github.com/apache/iotdb/pull/8853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] yschengzi opened a new pull request, #8877: [IOTDB-5412]Print Help Message when loading empty tsfile
yschengzi opened a new pull request, #8877: URL: https://github.com/apache/iotdb/pull/8877 Print Help Message when loading empty tsfile when tsfile is empty Msg: 701: TsFile E:\IoTDB\data\load\mpp_load\[IOTDB-5412](https://issues.apache.org/jira/browse/IOTDB-5412)\1-0-0-0.tsfile is empty, please check it be flushed to disk correctly. when tsfile is incomplete. Msg: 701: TsFile E:\IoTDB\data\load\mpp_load\[IOTDB-5412](https://issues.apache.org/jira/browse/IOTDB-5412)\1-0-0-0.tsfile is empty or incomplete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8846: [IOTDB-5284] Fix some sonar bugs
OneSizeFitsQuorum commented on code in PR #8846:
URL: https://github.com/apache/iotdb/pull/8846#discussion_r1069036807
##
example/session/src/main/java/org/apache/iotdb/SessionExample.java:
##
@@ -828,18 +828,19 @@ private static void nonQuery() throws
IoTDBConnectionException, StatementExecuti
session.executeNonQueryStatement("insert into root.sg1.d1(timestamp,s1)
values(200, 1)");
}
- private static void setTimeout() throws StatementExecutionException {
-Session tempSession = new Session(LOCAL_HOST, 6667, "root", "root", 1,
2);
-tempSession.setQueryTimeout(6);
+ private static void setTimeout() throws StatementExecutionException,
IoTDBConnectionException {
+try (Session tempSession = new Session(LOCAL_HOST, 6667, "root", "root",
1, 2)) {
+ tempSession.setQueryTimeout(6);
+}
}
private static void createClusterSession() throws IoTDBConnectionException {
Review Comment:
do not remove `setTimeout`, remove `createClusterSession`
##
tsfile/src/main/java/org/apache/iotdb/tsfile/read/TsFileRestorableReader.java:
##
@@ -61,11 +61,12 @@ private void checkAndRepair() throws IOException {
if (!isComplete()) {
// Try to close it
logger.info("File {} has no correct tail magic, try to repair...", file);
- RestorableTsFileIOWriter rWriter =
- new
RestorableTsFileIOWriter(FSFactoryProducer.getFSFactory().getFile(file));
- TsFileWriter writer = new TsFileWriter(rWriter);
- // This writes the right magic string
- writer.close();
+ try (RestorableTsFileIOWriter rWriter =
+ new
RestorableTsFileIOWriter(FSFactoryProducer.getFSFactory().getFile(file))) {
+TsFileWriter writer = new TsFileWriter(rWriter);
+// This writes the right magic string
+writer.close();
Review Comment:
Who not remove `TsFileWriter writer = new TsFileWriter(rWriter);` into
`try-with-resource` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #8809: [To rel/1.0] Separate SYNC_CONNECTION_ERROR and DISPATCH_ERROR
HTHou merged PR #8809: URL: https://github.com/apache/iotdb/pull/8809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] Wei-hao-Li closed pull request #8870: [IOTDB-5382]Support DIFF as built-in scalar function in IoTDB
Wei-hao-Li closed pull request #8870: [IOTDB-5382]Support DIFF as built-in scalar function in IoTDB URL: https://github.com/apache/iotdb/pull/8870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8876: [To rel/1.0][IOTDB-5324] Fix wal cann't be deleted in destDataNode after region migration when data_replication_factor is 1 in IoTCons
sonarcloud[bot] commented on PR #8876: URL: https://github.com/apache/iotdb/pull/8876#issuecomment-1381416839 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8876) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8876=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8876=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8876=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8876=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8876=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8876=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8876=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8876=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8876=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8876=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8876=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8876=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8876=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8876=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] liuminghui233 merged pull request #8852: Add docs for Data Repairing
liuminghui233 merged PR #8852: URL: https://github.com/apache/iotdb/pull/8852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] liuminghui233 commented on pull request #8852: Add docs for Data Repairing
liuminghui233 commented on PR #8852: URL: https://github.com/apache/iotdb/pull/8852#issuecomment-1381416215 The function code will be contributed to master branch later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum opened a new pull request, #8876: [IOTDB-5324] Fix wal cann't be deleted in destDataNode after region migration when data_replication_factor is 1 in IoTConsensus
OneSizeFitsQuorum opened a new pull request, #8876: URL: https://github.com/apache/iotdb/pull/8876 cherry-pick [pull/8836](https://github.com/apache/iotdb/pull/8836) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8853: Add query metrics doc
sonarcloud[bot] commented on PR #8853: URL: https://github.com/apache/iotdb/pull/8853#issuecomment-1381407369 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8853) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8853=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8853=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8853=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8853=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8853=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8853=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8853=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8853=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8853=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8853=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8853=false=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8853=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8853=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8853=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8853=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8853=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] yschengzi opened a new pull request, #8875: [IOTDB-5412][To rel/1.0]Print Help Message when loading empty tsfile
yschengzi opened a new pull request, #8875: URL: https://github.com/apache/iotdb/pull/8875 Print Help Message when loading empty tsfile when tsfile is empty Msg: 701: TsFile E:\IoTDB\data\load\mpp_load\IOTDB-5412\1-0-0-0.tsfile is empty, please check it be flushed to disk correctly. when tsfile is incomplete. Msg: 701: TsFile E:\IoTDB\data\load\mpp_load\IOTDB-5412\1-0-0-0.tsfile is empty or incomplete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8860: [IOTDB-5410] Refine IT: Refine Session and SessionPool IT
sonarcloud[bot] commented on PR #8860: URL: https://github.com/apache/iotdb/pull/8860#issuecomment-1381402422 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8860) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8860=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8860=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8860=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8860=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8860=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8860=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8860=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8860=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8860=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8860=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8860=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8860=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8860=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8860=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8860=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] SpriCoder merged pull request #8854: [To rel/1.0][IOTDB-5400] IoTConsensus loses data when replica number change from 1 to several
SpriCoder merged PR #8854: URL: https://github.com/apache/iotdb/pull/8854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8866: [IOTDB-5372] Support data type cast in SELECT INTO
sonarcloud[bot] commented on PR #8866: URL: https://github.com/apache/iotdb/pull/8866#issuecomment-1381394151 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb=8866) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8866=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8866=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8866=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8866=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8866=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8866=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8866=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8866=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb=8866=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8866=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8866=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=8866=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8866=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8866=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8866=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=8866=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] lpf4254302 opened a new pull request, #8874: [To rel/0.13][IOTDB-5407] metrics for .mods file count
lpf4254302 opened a new pull request, #8874: URL: https://github.com/apache/iotdb/pull/8874 ## Description Too many.mods files may indicate abnormal service deletion, so add.mods file count metrics -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8857: [IOTDB-5289] Add Metric Doc about ConfigNode Dashboard
OneSizeFitsQuorum merged PR #8857: URL: https://github.com/apache/iotdb/pull/8857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
