[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #465: [IOTDB-261]Check path validity in session

2019-10-21 Thread GitBox 
jixuan1989 commented on a change in pull request #465: [IOTDB-261]Check path 
validity in session
URL: https://github.com/apache/incubator-iotdb/pull/465#discussion_r337327371
 
 

 ##
 File path: session/src/test/java/org/apache/iotdb/session/IoTDBSessionIT.java
 ##
 @@ -280,4 +280,59 @@ private void insert_via_sql() throws TException, 
IoTDBRPCException {
 session.executeNonQueryStatement(
 "insert into root.sg1.d1(timestamp,s1, s2, s3) values(100, 1,2,3)");
   }
+
+  @Test
+  public void checkPathTest()
+  throws ClassNotFoundException, SQLException, IoTDBSessionException, 
TException, IoTDBRPCException {
+session = new Session("127.0.0.1", 6667, "root", "root");
+session.open();
+
+//test set sg
+checkSetSG(session, "root.vehicle", true);
+checkSetSG(session, "root.123456", true);
+checkSetSG(session, "root._1234", true);
+checkSetSG(session, "root._vehicle", true);
+checkSetSG(session, "root.\tvehicle", false);
 
 Review comment:
   how about `"root.\\tvehicle"`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #465: [IOTDB-261]Check path validity in session

2019-10-21 Thread GitBox 
jixuan1989 commented on a change in pull request #465: [IOTDB-261]Check path 
validity in session
URL: https://github.com/apache/incubator-iotdb/pull/465#discussion_r337327371
 
 

 ##
 File path: session/src/test/java/org/apache/iotdb/session/IoTDBSessionIT.java
 ##
 @@ -280,4 +280,59 @@ private void insert_via_sql() throws TException, 
IoTDBRPCException {
 session.executeNonQueryStatement(
 "insert into root.sg1.d1(timestamp,s1, s2, s3) values(100, 1,2,3)");
   }
+
+  @Test
+  public void checkPathTest()
+  throws ClassNotFoundException, SQLException, IoTDBSessionException, 
TException, IoTDBRPCException {
+session = new Session("127.0.0.1", 6667, "root", "root");
+session.open();
+
+//test set sg
+checkSetSG(session, "root.vehicle", true);
+checkSetSG(session, "root.123456", true);
+checkSetSG(session, "root._1234", true);
+checkSetSG(session, "root._vehicle", true);
+checkSetSG(session, "root.\tvehicle", false);
 
 Review comment:
   how about root.\\tvehicle


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services