[GitHub] [incubator-iotdb] jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support
jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929#issuecomment-610773022 Hi, yes I noticed the error. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support
jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929#issuecomment-610739421 > @jixuan1989 I think have fixed the ci error, but it's strange that the ci build not automatic triggered. Yeah it is quite strange... I manually trigger it and let's wait for the result.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support
jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929#issuecomment-610457942 Besides, I see there are some CI failed because of the mqtt dependency is not found from maven repo. It is strange that the "IoTDB-Flink Examples" failed because of that issue. However, it inspires me that you should claim the mqtt maven repo address on mqtt-example module, too. It is because some users may just compile the example module (and skip compiling the server module). Then, On their local repo folder, there is no such a jar, and error will occurs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support
jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929#issuecomment-605978813 > Hi, I have read the codes. > > 1. If we are using session API, I think we can keep it as a middleware, just like IoTDB-Grafana-Connector. > 2. As a middleware, maybe the backend IoTDB instance is restarted, while the middleware is alive as usual. In this case, the session connection may be broken. So, an auto-retry will be a good experience for users because after restarting the IoTDB instance, they do not need to restart this middleware. >You can use a simple SessionWrapper `org.apache.iotdb.session.pool.SessionPool` to implement it. And I have no other opinions. The code is beautiful. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support
jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929#issuecomment-604199287 > Thanks @qiaojialin @jixuan1989 > I agree with you that MQTT broker should be launched as an internal service of iotdb server, and we can add a switch in the server config file. I will refactor the code moving the logic to server module later. Hi, I'd like to explain more about the idea: 1. if you are using session API to send MQTT data to IoTDB instance, then the module looks like a middle-ware. If so, it plays a similar role with IoTDB-Grafana-Connector. Then, do not integrate it into the server module. 2. If you are using TsServiceImpl API to handle MQTT data directly, then put it into the server module. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support
jixuan1989 commented on issue #929: [IOTDB-565] MQTT Protocol Support URL: https://github.com/apache/incubator-iotdb/pull/929#issuecomment-602310735 > Good work! The only one we may need to discuss is whether the MQTT broker should be launched as an internal service of iotdb server, just like the JDBC or the HTTP service. Hi, I have not reviewed the codes, but I think we can add a switch to enable or disable some features like new API when starting an IoTDB instance. Actually, I am considering whether we can enable or disable some features when compiling IoTDB. Then we can get an embedded version for edge-side. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
