Caideyipi commented on code in PR #12114:
URL: https://github.com/apache/iotdb/pull/12114#discussion_r1514024700
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/plugin/dataregion/PipeDataRegionProcessorConstructor.java:
##
@@ -36,6 +37,10 @@ protected void initConstructors() {
pluginConstructors.put(
BuiltinPipePlugin.DO_NOTHING_PROCESSOR.getPipePluginName(),
DoNothingProcessor::new);
pluginConstructors.put(
-BuiltinPipePlugin.DOWN_SAMPLING_PROCESSOR.getPipePluginName(),
DownSamplingProcessor::new);
+BuiltinPipePlugin.DOWN_SAMPLING_PROCESSOR.getPipePluginName(),
+TumblingTimeSamplingProcessor::new);
+pluginConstructors.put(
+BuiltinPipePlugin.STD_FILTER_PROCESSOR.getPipePluginName(),
Review Comment:
SDT_FILTER
##
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/plugin/builtin/processor/downsampling/TumblingTimeProcessor.java:
##
@@ -27,4 +27,4 @@
* pipe agent in the server module will replace this class with the real
implementation when
* initializing the Down Sampling processor.
*/
-public class DownSamplingProcessor extends PlaceHolderProcessor {}
+public class TumblingTimeProcessor extends PlaceHolderProcessor {}
Review Comment:
Look at the "Down Sampling Processor" above
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/processor/downsampling/PartialPathLastObjectCache.java:
##
@@ -30,21 +30,16 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/**
- * Map-like component to look up for the last chosen time of a timeSeries. It
has max size and
- * timeSeries may fail to find its last time and must design the logic to
handle this.
- */
-public class PartialPathLastTimeCache implements AutoCloseable {
-
- private static final Logger LOGGER =
LoggerFactory.getLogger(PartialPathLastTimeCache.class);
+public class PartialPathLastObjectCache implements AutoCloseable {
Review Comment:
Consider re-writing the comments
##
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/plugin/builtin/processor/downsampling/SwingingDoorTrendingFilterProcessor.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.commons.pipe.plugin.builtin.processor.downsampling;
+
+import
org.apache.iotdb.commons.pipe.plugin.builtin.processor.PlaceHolderProcessor;
+
+public class SwingingDoorTrendingFilterProcessor extends PlaceHolderProcessor
{}
Review Comment:
Java docs?
##
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/plugin/builtin/BuiltinPipePlugin.java:
##
@@ -50,7 +51,8 @@ public enum BuiltinPipePlugin {
// processors
DO_NOTHING_PROCESSOR("do-nothing-processor", DoNothingProcessor.class),
- DOWN_SAMPLING_PROCESSOR("down-sampling-processor",
DownSamplingProcessor.class),
+ DOWN_SAMPLING_PROCESSOR("tumbling-time-processor",
TumblingTimeProcessor.class),
+ STD_FILTER_PROCESSOR("sdt-filter-processor",
SwingingDoorTrendingFilterProcessor.class),
Review Comment:
SDT_FILTER
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
