Re: [PR] Enhance DataNode startup probing logic [iotdb]

2024-01-23 Thread via GitHub 


OneSizeFitsQuorum merged PR #11957:
URL: https://github.com/apache/iotdb/pull/11957


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Enhance DataNode startup probing logic [iotdb]

2024-01-22 Thread via GitHub 


codecov-commenter commented on PR #11957:
URL: https://github.com/apache/iotdb/pull/11957#issuecomment-1905458624

   ## 
[Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   Attention: `7 lines` in your changes are missing coverage. Please review.
   > Comparison is base 
[(`8885df3`)](https://app.codecov.io/gh/apache/iotdb/commit/8885df31144105714f33e82136d071a2136b0180?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 48.99% compared to head 
[(`dc48f2a`)](https://app.codecov.io/gh/apache/iotdb/pull/11957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 49.00%.
   > Report is 4 commits behind head on master.
   
   | 
[Files](https://app.codecov.io/gh/apache/iotdb/pull/11957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...ain/java/org/apache/iotdb/db/service/DataNode.java](https://app.codecov.io/gh/apache/iotdb/pull/11957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc2VydmljZS9EYXRhTm9kZS5qYXZh)
 | 0.00% | [4 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/11957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[...apache/iotdb/commons/client/ClientPoolFactory.java](https://app.codecov.io/gh/apache/iotdb/pull/11957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvY2xpZW50L0NsaWVudFBvb2xGYWN0b3J5LmphdmE=)
 | 0.00% | [3 Missing :warning: 
](https://app.codecov.io/gh/apache/iotdb/pull/11957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   Additional details and impacted files
   
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #11957  +/-   ##
   
   + Coverage 48.99%   49.00%   +0.01% 
   + Complexity2581225810   -2 
   
 Files  2916 2916  
 Lines182759   182673  -86 
 Branches  2191321912   -1 
   
   - Hits  8953889522  -16 
   + Misses9322193151  -70 
   ```
   
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/iotdb/pull/11957?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Enhance DataNode startup probing logic [iotdb]

2024-01-22 Thread via GitHub 


sonarcloud[bot] commented on PR #11957:
URL: https://github.com/apache/iotdb/pull/11957#issuecomment-1905421857

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11957) 
**Quality Gate failed**  
   Failed conditions
   
   [B Maintainability Rating on New 
Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11957) 
(required ≥ A)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11957)
   
   
   
   
![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png
 'idea') Catch issues before they fail your Quality Gate with our IDE extension 
![SonarLint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png
 'SonarLint') 
[SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org