Re: [PR] Fix read chunk compaction performer null pointer exception [iotdb]

[via GitHub]

HTHou merged PR #11960:
URL: https://github.com/apache/iotdb/pull/11960


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix read chunk compaction performer null pointer exception [iotdb]

[via GitHub]

caozj1011 commented on code in PR #11960:
URL: https://github.com/apache/iotdb/pull/11960#discussion_r1463068193


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/readchunk/ReadChunkAlignedSeriesCompactionExecutor.java:
##
@@ -188,6 +195,9 @@ private void compactWithAlignedChunk(
   }
   pointNum += chunkMetadata.getStatistics().getCount();
   ChunkLoader valueChunk = getChunkLoader(reader, (ChunkMetadata) 
chunkMetadata);
+  if 
(!measurementSchemaListIndexMap.containsKey(chunkMetadata.getMeasurementUid())) 
{
+System.out.println();

Review Comment:
   remove it , too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix read chunk compaction performer null pointer exception [iotdb]

[via GitHub]

HTHou commented on code in PR #11960:
URL: https://github.com/apache/iotdb/pull/11960#discussion_r1463067707


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/readchunk/ReadChunkAlignedSeriesCompactionExecutor.java:
##
@@ -188,6 +195,9 @@ private void compactWithAlignedChunk(
   }
   pointNum += chunkMetadata.getStatistics().getCount();
   ChunkLoader valueChunk = getChunkLoader(reader, (ChunkMetadata) 
chunkMetadata);
+  if 
(!measurementSchemaListIndexMap.containsKey(chunkMetadata.getMeasurementUid())) 
{
+System.out.println();
+  }

Review Comment:
   remove this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix read chunk compaction performer null pointer exception [iotdb]

[via GitHub]

HTHou commented on code in PR #11960:
URL: https://github.com/apache/iotdb/pull/11960#discussion_r1463066578


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/readchunk/ReadChunkAlignedSeriesCompactionExecutor.java:
##
@@ -92,6 +97,9 @@ public ReadChunkAlignedSeriesCompactionExecutor(
 this.writer = writer;
 this.targetResource = targetResource;
 this.summary = summary;
+if (device.contains("d_0")) {
+  System.out.println();
+}

Review Comment:
   remove this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org