Re: [PR] Refactor IQueryExecution to support Table Model in the future [iotdb]

2024-03-13 Thread via GitHub 


JackieTien97 merged PR #12157:
URL: https://github.com/apache/iotdb/pull/12157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Refactor IQueryExecution to support Table Model in the future [iotdb]

2024-03-13 Thread via GitHub 


JackieTien97 commented on code in PR #12157:
URL: https://github.com/apache/iotdb/pull/12157#discussion_r1522603954


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/Analysis.java:
##
@@ -63,7 +69,7 @@
 import static com.google.common.base.Preconditions.checkArgument;
 
 /** Analysis used for planning a query. TODO: This class may need to store 
more info for a query. */
-public class Analysis {
+public class Analysis implements IAnalysis {

Review Comment:
   sure~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Refactor IQueryExecution to support Table Model in the future [iotdb]

2024-03-12 Thread via GitHub 


Beyyes commented on code in PR #12157:
URL: https://github.com/apache/iotdb/pull/12157#discussion_r1522469186


##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/Analysis.java:
##
@@ -63,7 +69,7 @@
 import static com.google.common.base.Preconditions.checkArgument;
 
 /** Analysis used for planning a query. TODO: This class may need to store 
more info for a query. */
-public class Analysis {
+public class Analysis implements IAnalysis {

Review Comment:
   If renamed to TreeModelAnalysis?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Refactor IQueryExecution to support Table Model in the future [iotdb]

2024-03-12 Thread via GitHub 


sonarcloud[bot] commented on PR #12157:
URL: https://github.com/apache/iotdb/pull/12157#issuecomment-1991647595

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb=12157) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12157=new_coverage=list)
 (required ≥ 80%)  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [4.3% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12157=new_duplicated_lines_density=list)
 (required ≤ 3%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=12157)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Refactor IQueryExecution to support Table Model in the future [iotdb]

2024-03-12 Thread via GitHub 


sonarcloud[bot] commented on PR #12157:
URL: https://github.com/apache/iotdb/pull/12157#issuecomment-1991179607

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb=12157) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12157=new_coverage=list)
 (required ≥ 80%)  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [4.3% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12157=new_duplicated_lines_density=list)
 (required ≤ 3%)  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=12157)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org