[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1452: Fix logic of creating MTree snapshot
sonarcloud[bot] commented on pull request #1452: URL: https://github.com/apache/incubator-iotdb/pull/1452#issuecomment-652993552 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1452=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1452=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1452=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1452=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1452=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1452=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1452=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1452=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1452=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1452=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1452=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1452) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1452=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1452=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1451: [IOTDB-787] set thrift and antlr as two independent module
qiaojialin commented on a change in pull request #1451:
URL: https://github.com/apache/incubator-iotdb/pull/1451#discussion_r448978462
##
File path:
jdbc/src/test/java/org/apache/iotdb/jdbc/manualtest/CompleteFutureTest.java
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc.manualtest;
+
+
+
+public class CompleteFutureTest {
Review comment:
?
##
File path:
jdbc/src/test/java/org/apache/iotdb/jdbc/manualtest/JDBCRegisterManyTimeSeries.java
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.jdbc.manualtest;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.ResultSet;
+import java.sql.ResultSetMetaData;
+import java.sql.SQLException;
+import java.sql.Statement;
+import org.apache.iotdb.jdbc.IoTDBSQLException;
+
+public class JDBCRegisterManyTimeSeries {
+
+ public static void main(String[] args) throws ClassNotFoundException,
SQLException {
Review comment:
put this to example?
##
File path:
session/src/test/java/org/apache/iotdb/session/CompleteFutureTest.java
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.session;
+
+
+
+public class CompleteFutureTest {
Review comment:
remove
##
File path: antlr/src/pypi/README.md
##
@@ -0,0 +1,61 @@
+
+
+# Apache IoTDB
+
+[](https://www.travis-ci.org/apache/incubator-iotdb)
+[](https://codecov.io/gh/thulab/incubator-iotdb)
+[![GitHub
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1451: [IOTDB-787] set thrift and antlr as two independent module
sonarcloud[bot] removed a comment on pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451#issuecomment-652885518 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1451: [IOTDB-787] set thrift and antlr as two independent module
sonarcloud[bot] commented on pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451#issuecomment-652989109 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1411: [IOTDB-706] Introduce virtual memtable for larger Chunk
sonarcloud[bot] commented on pull request #1411: URL: https://github.com/apache/incubator-iotdb/pull/1411#issuecomment-652983061 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=VULNERABILITY) [15 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=CODE_SMELL) [44 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1411) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1411=new_duplicated_lines_density=list) [4.6% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1411=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1411: [IOTDB-706] Introduce virtual memtable for larger Chunk
sonarcloud[bot] removed a comment on pull request #1411: URL: https://github.com/apache/incubator-iotdb/pull/1411#issuecomment-652403428 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=VULNERABILITY) [15 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=CODE_SMELL) [44 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1411=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1411) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1411=new_duplicated_lines_density=list) [4.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1411=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1453: [IoTDB-786]refactor the thrift rpc service to reduce duplicate codes of RPC and Sync module
sonarcloud[bot] commented on pull request #1453: URL: https://github.com/apache/incubator-iotdb/pull/1453#issuecomment-653008693 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=CODE_SMELL) [18 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1453) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1453=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1453=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1451: [IOTDB-787] set thrift and antlr as two independent module
jixuan1989 commented on a change in pull request #1451:
URL: https://github.com/apache/incubator-iotdb/pull/1451#discussion_r449023058
##
File path:
jdbc/src/test/java/org/apache/iotdb/jdbc/manualtest/JDBCRegisterManyTimeSeries.java
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.jdbc.manualtest;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.ResultSet;
+import java.sql.ResultSetMetaData;
+import java.sql.SQLException;
+import java.sql.Statement;
+import org.apache.iotdb.jdbc.IoTDBSQLException;
+
+public class JDBCRegisterManyTimeSeries {
+
+ public static void main(String[] args) throws ClassNotFoundException,
SQLException {
Review comment:
Will remove this..
##
File path:
jdbc/src/test/java/org/apache/iotdb/jdbc/manualtest/CompleteFutureTest.java
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.jdbc.manualtest;
+
+
+
+public class CompleteFutureTest {
Review comment:
Will remove this...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] SilverNarcissus commented on a change in pull request #1448: [IOTDB-716] add lZ4 compress method
SilverNarcissus commented on a change in pull request #1448: URL: https://github.com/apache/incubator-iotdb/pull/1448#discussion_r449116645 ## File path: tsfile/pom.xml ## @@ -53,6 +53,11 @@ commons-io commons-io + +net.jpountz.lz4 +lz4 +1.3.0 + Review comment: Sure~ I will fix it~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] LebronAl opened a new pull request #1454: [Distributed] fix thrift_max_frame_size bug && add thrift_init_buffer_size config
LebronAl opened a new pull request #1454: URL: https://github.com/apache/incubator-iotdb/pull/1454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1451: [IOTDB-787] set thrift and antlr as two independent module
sonarcloud[bot] removed a comment on pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451#issuecomment-652989109 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1451: [IOTDB-787] set thrift and antlr as two independent module
sonarcloud[bot] commented on pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451#issuecomment-653093422 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1453: [IoTDB-786]refactor the thrift rpc service to reduce duplicate codes of RPC and Sync module
sonarcloud[bot] commented on pull request #1453: URL: https://github.com/apache/incubator-iotdb/pull/1453#issuecomment-653272694 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=CODE_SMELL) [18 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1453) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1453=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1453=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1453: [IoTDB-786]refactor the thrift rpc service to reduce duplicate codes of RPC and Sync module
sonarcloud[bot] removed a comment on pull request #1453: URL: https://github.com/apache/incubator-iotdb/pull/1453#issuecomment-653008693 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=CODE_SMELL) [18 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1453=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1453) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1453=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1453=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-652924550 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [6 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [167 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-653308979 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [6 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [164 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-653320476 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [6 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [167 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-653308979 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [6 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [164 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] Ring-k opened a new pull request #1457: delete timeseries when path is not found
Ring-k opened a new pull request #1457: URL: https://github.com/apache/incubator-iotdb/pull/1457 Problem >>> If the DeleteTimeseriesPlan is routed globally and the metadata is removed, and the other node needs to retrieve the full paths, then the metadata is nowhere to be found. Solution >>> In this implementation, the full paths will be retrieved before plan routing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-653361804 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [6 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [167 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-653320476 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [6 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [167 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] SailVR opened a new pull request #1455: [IOTDB-774]Fix "show timeseries" OOM problem
SailVR opened a new pull request #1455: URL: https://github.com/apache/incubator-iotdb/pull/1455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] SailVR closed pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem
SailVR closed pull request #1443: URL: https://github.com/apache/incubator-iotdb/pull/1443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1451: [IOTDB-787] set thrift and antlr as two independent module
qiaojialin merged pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] HTHou opened a new pull request #1456: Fix a stop upgrade service bug
HTHou opened a new pull request #1456: URL: https://github.com/apache/incubator-iotdb/pull/1456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1456: Fix a stop upgrade service bug
sonarcloud[bot] commented on pull request #1456: URL: https://github.com/apache/incubator-iotdb/pull/1456#issuecomment-653325983 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1456=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1456=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1456=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1456=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1456=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1456=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1456=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1456=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1456=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1456=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1456=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1456) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1456=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1456=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1457: delete timeseries when path is not found
sonarcloud[bot] commented on pull request #1457: URL: https://github.com/apache/incubator-iotdb/pull/1457#issuecomment-653336478 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1457=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1457=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1457=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1457=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1457=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1457=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1457=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1457=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1457=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1457=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1457=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1457) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1457=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1457=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] JackieTien97 merged pull request #1455: [IOTDB-774]Fix "show timeseries" OOM problem
JackieTien97 merged pull request #1455: URL: https://github.com/apache/incubator-iotdb/pull/1455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] jt2594838 merged pull request #1454: [Distributed] fix thrift_max_frame_size bug && add thrift_init_buffer_size config && fix instanceof insertplan
jt2594838 merged pull request #1454: URL: https://github.com/apache/incubator-iotdb/pull/1454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1326: premerge for the distributed version
sonarcloud[bot] removed a comment on pull request #1326: URL: https://github.com/apache/incubator-iotdb/pull/1326#issuecomment-652774640 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1326) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1326=new_duplicated_lines_density=list) [14.4% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1326=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1326: premerge for the distributed version
sonarcloud[bot] commented on pull request #1326: URL: https://github.com/apache/incubator-iotdb/pull/1326#issuecomment-653298176 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1326=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1326) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1326=new_duplicated_lines_density=list) [13.8% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1326=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-652924550 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [6 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [167 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster
sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-651717783 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [8 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) [4 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [151 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=460=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=460=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] SailVR edited a comment on pull request #1443: [IOTDB-774]Fix "show timeseries" OOM problem
SailVR edited a comment on pull request #1443: URL: https://github.com/apache/incubator-iotdb/pull/1443#issuecomment-652152738 > > Good job. > > However, what will happen if the user defined limit is larger than the fetch size? It seems that you didn't deal with this case in your code. > > We will consider it later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #1450: add insertStringRecord rpc method
qiaojialin opened a new pull request #1450: URL: https://github.com/apache/incubator-iotdb/pull/1450 Remove inferType in RPC and extract insertStringRecord from insertRecord This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #1451: [IOTDB-787] set thrift and antlr as two independent module
jixuan1989 opened a new pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451 As discussed in https://lists.apache.org/thread.html/rd776647235c16c67db732e104a7eedda8e7b654d2d368462e586adf6%40%3Cdev.iotdb.apache.org%3E We will extract the thrift.thrift and antlr.g4 into two independent modules. After that, just use `mvn generate-source -pl thrift,antlr` or `mvn compile -pl thrift,antlr` to generate codes. **OR:** ** JUST RIGHT CLICK the project on IDEA, and CHOOSE `maven -> Generate Sources and Update Folders`** Enjoy it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1448: [IOTDB-716] add lZ4 compress method
HTHou commented on a change in pull request #1448: URL: https://github.com/apache/incubator-iotdb/pull/1448#discussion_r448808695 ## File path: tsfile/pom.xml ## @@ -53,6 +53,11 @@ commons-io commons-io + +net.jpountz.lz4 +lz4 +1.3.0 + Review comment: I think we should update the LICENSE-binary as well. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1448: [IOTDB-716] add lZ4 compress method
HTHou commented on a change in pull request #1448: URL: https://github.com/apache/incubator-iotdb/pull/1448#discussion_r448808695 ## File path: tsfile/pom.xml ## @@ -53,6 +53,11 @@ commons-io commons-io + +net.jpountz.lz4 +lz4 +1.3.0 + Review comment: I think we should update the `LICENSE-binary` as well. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] jt2594838 merged pull request #1441: [distributed] change log to asynchronous & add thrift max frame size & fix the InterruptedException bug
jt2594838 merged pull request #1441: URL: https://github.com/apache/incubator-iotdb/pull/1441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #1453: [IoTDB-786]refactor the thrift rpc service to reduce duplicate codes of RPC and Sync module
jixuan1989 opened a new pull request #1453: URL: https://github.com/apache/incubator-iotdb/pull/1453 In this case, we do not need to maintain the two modules separately (to reduce the probability that one is fine but the other has bugs). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1400: [IOTDB-627]Support range deletion for timeseries
qiaojialin commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-iotdb/pull/1400#discussion_r448842280
##
File path:
server/src/main/java/org/apache/iotdb/db/engine/modification/io/LocalTextModificationAccessor.java
##
@@ -124,28 +124,42 @@ private static Modification decodeModification(String
src) throws IOException {
private static String encodeDeletion(Deletion del) {
return del.getType().toString() + SEPARATOR + del.getPathString()
+ SEPARATOR + del.getVersionNum() + SEPARATOR
-+ del.getTimestamp();
++ del.getStartTime() + SEPARATOR + del.getEndTime();
}
private static Deletion decodeDeletion(String[] fields) throws IOException {
-if (fields.length != 4) {
+if (fields.length != 5 && fields.length != 4) {
throw new IOException("Incorrect deletion fields number: " +
fields.length);
}
String path = fields[1];
long versionNum;
-long timestamp;
+long startTimestamp = Long.MIN_VALUE;
+long endTimestamp;
try {
versionNum = Long.parseLong(fields[2]);
} catch (NumberFormatException e) {
throw new IOException("Invalid version number: " + fields[2]);
}
-try {
- timestamp = Long.parseLong(fields[3]);
-} catch (NumberFormatException e) {
- throw new IOException("Invalid timestamp: " + fields[3]);
+if (fields.length == 4) {
+ try {
+endTimestamp = Long.parseLong(fields[3]);
+ } catch (NumberFormatException e) {
+throw new IOException("Invalid timestamp: " + fields[3]);
+ }
+} else {
+ try {
+startTimestamp = Long.parseLong(fields[3]);
+ } catch (NumberFormatException e) {
+throw new IOException("Invalid timestamp: " + fields[3]);
+ }
+ try {
+endTimestamp = Long.parseLong(fields[4]);
+ } catch (NumberFormatException e) {
+throw new IOException("Invalid timestamp: " + fields[4]);
+ }
Review comment:
You can combine the two parsing and put the whole deletion line into
IOException
##
File path:
server/src/main/java/org/apache/iotdb/db/qp/physical/crud/DeletePlan.java
##
@@ -45,7 +46,22 @@ public DeletePlan() {
*/
public DeletePlan(long deleteTime, Path path) {
super(false, Operator.OperatorType.DELETE);
-this.deleteTime = deleteTime;
+this.deleteStartTime = Long.MIN_VALUE;
+this.deleteEndTime = deleteTime;
+this.paths.add(path);
+ }
Review comment:
It's better to remove this constructor, it may misleading others that
this means delete time = deleteTime.
##
File path: docs/UserGuide/Operation Manual/DML Data Manipulation Language.md
##
@@ -783,6 +783,12 @@ The wf02 plant's wt02 device has many segments of errors
in its power supply sta
delete from root.ln.wf02.wt02.status where time<=2017-11-01T16:26:00;
```
+In case we hope to merely delete the data before 2017-11-01 16:26:00 in the
year of 2017, The SQL statement is:
+```
+delete from root.ln.wf02.wt02.status where time>=2017-01-01T00:00:00 and
time<=2017-11-01T16:26:00;
Review comment:
give more examples
put the sqls in pr here
##
File path: server/src/main/java/org/apache/iotdb/db/utils/QueryUtils.java
##
@@ -45,46 +49,52 @@ private QueryUtils() {
*/
public static void modifyChunkMetaData(List chunkMetaData,
List modifications) {
-int modIndex = 0;
+List sortedModifications = sortModifications(modifications);
for (int metaIndex = 0; metaIndex < chunkMetaData.size(); metaIndex++) {
ChunkMetadata metaData = chunkMetaData.get(metaIndex);
- for (int j = modIndex; j < modifications.size(); j++) {
-// iterate each modification to find the max deletion time
-Modification modification = modifications.get(j);
+ for (Modification modification : sortedModifications) {
if (modification.getVersionNum() > metaData.getVersion()) {
- // this modification is after the Chunk, try modifying the chunk
- // if this modification succeeds, update modIndex so in the next
loop the previous
- // modifications will not be examined
- modIndex = doModifyChunkMetaData(modification, metaData)? j :
modIndex;
-} else {
- // skip old modifications for next metadata
- modIndex++;
+ doModifyChunkMetaData(modification, metaData);
}
}
}
// remove chunks that are completely deleted
chunkMetaData.removeIf(metaData -> {
- if (metaData.getDeletedAt() >= metaData.getEndTime()) {
-return true;
- } else {
-if (metaData.getDeletedAt() >= metaData.getStartTime()) {
- metaData.setModified(true);
+ long lower = metaData.getStartTime();
+ long upper = metaData.getEndTime();
+ if (metaData.getDeleteIntervalList() != null) {
+for (Pair range :
[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #1452: Fix logic of creating MTree snapshot
samperson1997 commented on a change in pull request #1452:
URL: https://github.com/apache/incubator-iotdb/pull/1452#discussion_r448900901
##
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##
@@ -1785,27 +1785,25 @@ private void checkMTreeModified() {
// the logWriter is not initialized now, we skip the check once.
return;
}
-if (System.currentTimeMillis() - logFile.lastModified() >=
mtreeSnapshotThresholdTime
-&& logWriter.getLineNumber() > 0) {
- logger.info("Start creating MTree snapshot, because {} ms elapse.",
+if (System.currentTimeMillis() - logFile.lastModified() <
mtreeSnapshotThresholdTime) {
+ logger.info("MTree snapshot need not be created. Time from last
modification: {} ms.",
System.currentTimeMillis() - logFile.lastModified());
- createMTreeSnapshot();
-} else if (logWriter.getLineNumber() >= mtreeSnapshotInterval) {
- logger.info("Start creating MTree snapshot, because of {} new lines are
added.",
+} else if (logWriter.getLineNumber() < mtreeSnapshotInterval) {
+ logger.info("MTree snapshot need not be created. New mlog line number:
{}.",
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #1452: Fix logic of creating MTree snapshot
samperson1997 commented on a change in pull request #1452:
URL: https://github.com/apache/incubator-iotdb/pull/1452#discussion_r448900856
##
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##
@@ -1785,27 +1785,25 @@ private void checkMTreeModified() {
// the logWriter is not initialized now, we skip the check once.
return;
}
-if (System.currentTimeMillis() - logFile.lastModified() >=
mtreeSnapshotThresholdTime
-&& logWriter.getLineNumber() > 0) {
- logger.info("Start creating MTree snapshot, because {} ms elapse.",
+if (System.currentTimeMillis() - logFile.lastModified() <
mtreeSnapshotThresholdTime) {
+ logger.info("MTree snapshot need not be created. Time from last
modification: {} ms.",
Review comment:
Sure
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1452: Fix logic of creating MTree snapshot
jixuan1989 commented on a change in pull request #1452:
URL: https://github.com/apache/incubator-iotdb/pull/1452#discussion_r448898298
##
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##
@@ -1785,27 +1785,25 @@ private void checkMTreeModified() {
// the logWriter is not initialized now, we skip the check once.
return;
}
-if (System.currentTimeMillis() - logFile.lastModified() >=
mtreeSnapshotThresholdTime
-&& logWriter.getLineNumber() > 0) {
- logger.info("Start creating MTree snapshot, because {} ms elapse.",
+if (System.currentTimeMillis() - logFile.lastModified() <
mtreeSnapshotThresholdTime) {
+ logger.info("MTree snapshot need not be created. Time from last
modification: {} ms.",
System.currentTimeMillis() - logFile.lastModified());
- createMTreeSnapshot();
-} else if (logWriter.getLineNumber() >= mtreeSnapshotInterval) {
- logger.info("Start creating MTree snapshot, because of {} new lines are
added.",
+} else if (logWriter.getLineNumber() < mtreeSnapshotInterval) {
+ logger.info("MTree snapshot need not be created. New mlog line number:
{}.",
Review comment:
how about debug level
##
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##
@@ -1785,27 +1785,25 @@ private void checkMTreeModified() {
// the logWriter is not initialized now, we skip the check once.
return;
}
-if (System.currentTimeMillis() - logFile.lastModified() >=
mtreeSnapshotThresholdTime
-&& logWriter.getLineNumber() > 0) {
- logger.info("Start creating MTree snapshot, because {} ms elapse.",
+if (System.currentTimeMillis() - logFile.lastModified() <
mtreeSnapshotThresholdTime) {
+ logger.info("MTree snapshot need not be created. Time from last
modification: {} ms.",
Review comment:
how about debug level
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1450: add insertStringRecord rpc method
sonarcloud[bot] commented on pull request #1450: URL: https://github.com/apache/incubator-iotdb/pull/1450#issuecomment-652871934 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1450=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1450=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1450=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1450=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1450=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1450=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1450=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1450=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1450=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1450=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1450=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1450) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1450=new_duplicated_lines_density=list) [39.3% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1450=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1337: [IOTDB-746] Add async insertion interfaces in Session and SessionPool
HTHou commented on a change in pull request #1337: URL: https://github.com/apache/incubator-iotdb/pull/1337#discussion_r448860998 ## File path: docs/UserGuide/Client/Programming - Native API.md ## @@ -136,11 +145,11 @@ Here we show the commonly used interfaces and their parameters in the Native API List> measurementsList, List> valuesList) ``` -* Insert a Record，which contains multiple measurement value of a device at a timestamp. With type info the server has no need to do type inference, which leads a better performance +* Insert multiple Records asynchronously by providing additional asynchronous timeout and an exception callback Review comment: ```suggestion * Insert multiple records asynchronously by providing additional asynchronous timeout and an exception callback ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1337: [IOTDB-746] Add async insertion interfaces in Session and SessionPool
HTHou commented on a change in pull request #1337: URL: https://github.com/apache/incubator-iotdb/pull/1337#discussion_r448861261 ## File path: docs/UserGuide/Client/Programming - Native API.md ## @@ -150,6 +159,38 @@ Here we show the commonly used interfaces and their parameters in the Native API List> measurementsList, List> typesList, List> valuesList) ``` + +* Insert multiple Records asynchronously by providing additional asynchronous timeout and an exception callback. With type info the server has no need to do type inference, which leads a better performance Review comment: ```suggestion * Insert multiple records asynchronously by providing additional asynchronous timeout and an exception callback. With type info the server has no need to do type inference, which leads a better performance ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1451: [IOTDB-787] set thrift and antlr as two independent module
sonarcloud[bot] commented on pull request #1451: URL: https://github.com/apache/incubator-iotdb/pull/1451#issuecomment-652885518 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb=1451=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb=1451=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1400: [IOTDB-627]Support range deletion for timeseries
jt2594838 commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-iotdb/pull/1400#discussion_r448861552
##
File path:
server/src/test/java/org/apache/iotdb/db/engine/merge/MergeTaskTest.java
##
@@ -218,7 +218,7 @@ public void testPartialMerge3() throws Exception {
public void mergeWithDeletionTest() throws Exception {
try {
seqResources.get(0).getModFile().write(new Deletion(new
Path(deviceIds[0],
- measurementSchemas[0].getMeasurementId()), 1, 49));
+ measurementSchemas[0].getMeasurementId()), 1, 0,49));
Review comment:
Please mind the format.
##
File path: server/src/main/java/org/apache/iotdb/db/utils/QueryUtils.java
##
@@ -45,46 +49,52 @@ private QueryUtils() {
*/
public static void modifyChunkMetaData(List chunkMetaData,
List modifications) {
-int modIndex = 0;
+List sortedModifications = sortModifications(modifications);
for (int metaIndex = 0; metaIndex < chunkMetaData.size(); metaIndex++) {
ChunkMetadata metaData = chunkMetaData.get(metaIndex);
- for (int j = modIndex; j < modifications.size(); j++) {
-// iterate each modification to find the max deletion time
-Modification modification = modifications.get(j);
+ for (Modification modification : sortedModifications) {
if (modification.getVersionNum() > metaData.getVersion()) {
- // this modification is after the Chunk, try modifying the chunk
- // if this modification succeeds, update modIndex so in the next
loop the previous
- // modifications will not be examined
- modIndex = doModifyChunkMetaData(modification, metaData)? j :
modIndex;
-} else {
- // skip old modifications for next metadata
- modIndex++;
+ doModifyChunkMetaData(modification, metaData);
}
}
}
// remove chunks that are completely deleted
chunkMetaData.removeIf(metaData -> {
- if (metaData.getDeletedAt() >= metaData.getEndTime()) {
-return true;
- } else {
-if (metaData.getDeletedAt() >= metaData.getStartTime()) {
- metaData.setModified(true);
+ long lower = metaData.getStartTime();
+ long upper = metaData.getEndTime();
+ if (metaData.getDeleteIntervalList() != null) {
+for (Pair range : metaData.getDeleteIntervalList()) {
+ if (upper < range.left) {
+break;
+ }
+ if (range.left <= lower && lower <= range.right) {
+metaData.setModified(true);
+if (upper <= range.right) {
+ return true;
+}
+lower = range.right;
+ } else if (lower < range.left) {
+metaData.setModified(true);
+break;
+ }
}
-return false;
}
+ return false;
});
}
- private static boolean doModifyChunkMetaData(Modification modification,
ChunkMetadata metaData) {
+ private static LinkedList sortModifications(List
modifications) {
+return modifications.stream().filter(x -> x instanceof Deletion)
+.sorted(Comparator.comparingLong(mods -> ((Deletion)
mods).getStartTime()))
+.collect(Collectors.toCollection(LinkedList::new));
+ }
Review comment:
I wonder why LinkedList is preferred.
##
File path: session/src/main/java/org/apache/iotdb/session/Session.java
##
@@ -747,14 +747,37 @@ public void deleteData(String path, long time)
* delete data <= time in multiple timeseries
*
* @param paths data in which time series to delete
- * @param time data with time stamp less than or equal to time will be
deleted
+ * @param endTime data with time stamp less than or equal to time will be
deleted
*/
- public void deleteData(List paths, long time)
+ public void deleteData(List paths, long endTime)
throws IoTDBConnectionException, StatementExecutionException {
TSDeleteDataReq request = new TSDeleteDataReq();
request.setSessionId(sessionId);
request.setPaths(paths);
-request.setTimestamp(time);
+request.setStartTime(Long.MIN_VALUE);
+request.setEndTime(endTime);
+
Review comment:
It may simply be changed to a call of `deleteData(paths, Long.MIN_VALUE,
endtime)`.
##
File path:
server/src/main/java/org/apache/iotdb/db/utils/datastructure/TVList.java
##
@@ -531,6 +530,17 @@ public boolean hasNextTimeValuePair() {
return hasCachedPair;
}
+private boolean isPointDeleted(long timestamp) {
+ if (deletionList != null) {
+for (Pair del : deletionList) {
+ if (del.left <= timestamp && timestamp <= del.right) {
+return true;
+ }
+}
Review comment:
I think it is not necessary to start from the first of the deletions at
each call of `isPointDeleted()`, as this method is called with ordered
[GitHub] [incubator-iotdb] samperson1997 opened a new pull request #1452: Fix logic of creating MTree snapshot
samperson1997 opened a new pull request #1452: URL: https://github.com/apache/incubator-iotdb/pull/1452 Fix logic of creating MTree snapshot. The snapshot should only be created when `System.currentTimeMillis() - logFile.lastModified() >= mtreeSnapshotThresholdTime` AND `logWriter.getLineNumber() >= mtreeSnapshotInterval` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1450: add insertStringRecord rpc method
qiaojialin merged pull request #1450: URL: https://github.com/apache/incubator-iotdb/pull/1450 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
