[kudu-CR] remote bootstrap client: mild API changes

2016-07-28 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: remote_bootstrap_client: mild API changes
..


Patch Set 2: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/2684/

-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] KUDU-1517 Implement doc feedback from Sue M

2016-07-28 Thread Mike Percy (Code Review) 
Mike Percy has posted comments on this change.

Change subject: KUDU-1517 Implement doc feedback from Sue M
..


Patch Set 1:

(11 comments)

http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc
File docs/index.adoc:

PS1, Line 73: mechanism
s/mechanisms/syntax/


PS1, Line 74: any other table with HDFS or HBase persistenc
as any other Impala table, like those using HDFS or HBase for persistence.


PS1, Line 78: solutions
s/solutions/standards/


PS1, Line 78: to
s/to/with/


PS1, Line 79: FROM
I would say: you can specify complex joins with a FROM clause in a subquery

However, I am not sure if it's true that this works for updates with Impala and 
Kudu. Are you sure? I suppose this means you can do something like what is 
shown in this SO article: 
http://stackoverflow.com/questions/1293330/how-can-i-do-an-update-statement-with-join-in-sql


PS1, Line 89: within
s/within/used by/


PS1, Line 89: to
s/to/across/


Line 108: Data Compression:: Because a given column contains only one type of 
data, pattern-based compression can
nit: Would be nice to keep this line under 100 chars long


PS1, Line 185: when using
s/when using/in/


PS1, Line 236: and
nit: and and


http://gerrit.cloudera.org:8080/#/c/3638/1/docs/release_notes.adoc
File docs/release_notes.adoc:

Line 31: == Introduction
nit: I think this should be a 3rd-level heading


-- 
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] external mini cluster: adjust single master data directory

2016-07-28 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: external_mini_cluster: adjust single master data directory
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2681/

-- 
To view, visit http://gerrit.cloudera.org:8080/3810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1cfcd529b14cb2472a8673edbc28dbe66175a8a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] build-and-test: also clean up old failsafe reports

2016-07-28 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: build-and-test: also clean up old failsafe reports
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2683/

-- 
To view, visit http://gerrit.cloudera.org:8080/3812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3a5e0f55bab3bfb10bcc9cfdd19dbf330936027
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] build-and-test: also clean up old failsafe reports

2016-07-28 Thread Adar Dembo (Code Review) 
Adar Dembo has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3812

Change subject: build-and-test: also clean up old failsafe reports
..

build-and-test: also clean up old failsafe reports

With failsafe is running some Java tests, test output is showing up in
java/*/target/failsafe-reports. We weren't explicitly deleting this
directory so failures may sneak into subsequent LINT runs.

Change-Id: Ib3a5e0f55bab3bfb10bcc9cfdd19dbf330936027
---
M build-support/jenkins/build-and-test.sh
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/3812/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3a5e0f55bab3bfb10bcc9cfdd19dbf330936027
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo

[kudu-CR] c++ client: remove unnecessary code

2016-07-28 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: c++ client: remove unnecessary code
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2682/

-- 
To view, visit http://gerrit.cloudera.org:8080/3809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idda2cc15bc6224df992bfe2eec287c0222adced0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] remote bootstrap client: mild API changes

2016-07-28 Thread Adar Dembo (Code Review) 
Adar Dembo has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3811

Change subject: remote_bootstrap_client: mild API changes
..

remote_bootstrap_client: mild API changes

1. I removed the uuid argument from the constructor; it's always the uuid of
   the FsManager.
2. I made the TabletStatusListener argument to FetchAll() optional. I think
   that was the original intent (because the TabletMetadata OUT parameter in
   Start() is optional), but a CHECK_NOTNULL() got added at some point.

Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
---
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/tserver/remote_bootstrap_client-test.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_client.h
M src/kudu/tserver/ts_tablet_manager.cc
5 files changed, 30 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/3811/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo

[kudu-CR] external mini cluster: adjust single master data directory

2016-07-28 Thread Adar Dembo (Code Review) 
Adar Dembo has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3810

Change subject: external_mini_cluster: adjust single master data directory
..

external_mini_cluster: adjust single master data directory

If we stored single master data in "master-0" and not "master", it'd be
possible to reuse single master cluster data in a multi master cluster. This
should be a purely cosmetic change, but I've put it in its own patch to draw
more attention to it in case I'm wrong.

I snuck in a change to remove --enable_leader_failure_detection=true as
that's now the default value.

Change-Id: Ia1cfcd529b14cb2472a8673edbc28dbe66175a8a
---
M src/kudu/integration-tests/external_mini_cluster.cc
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3810/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1cfcd529b14cb2472a8673edbc28dbe66175a8a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo

[kudu-CR] external mini cluster: adjust single master data directory

2016-07-28 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: external_mini_cluster: adjust single master data directory
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2678/

-- 
To view, visit http://gerrit.cloudera.org:8080/3810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1cfcd529b14cb2472a8673edbc28dbe66175a8a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Adding some missing 0.10.0 release notes

2016-07-28 Thread Misty Stanley-Jones (Code Review) 
Misty Stanley-Jones has posted comments on this change.

Change subject: Adding some missing 0.10.0 release notes
..


Patch Set 1:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/3802/1/docs/release_notes.adoc
File docs/release_notes.adoc:

Line 71: - link:http://gerrit.cloudera.org:8080/3737[Gerrit #3737] The Java 
client was repackaged
s/was packaged/has been repackaged

Import statements for Kudu classes must be modified in order to compile 
against Wire compatibility is maintained.


Line 76: - link:https://gerrit.cloudera.org/#/c/3055/[Gerrit #3055] Changed the 
Java client's
The Java client's synchronous API methods now throw `KuduException` instead of 
`Exception`...

Introspection in an exception's messages may...

This change was made to allow thrown exceptions to be queried more easily 
using


Line 93:   write operations. It is disabled by default, and requires setting 
`--enable_exactly_once` on the
To enable 'exactly-once' semantics, set the `--enable_exactly_once` 
configuration flag when starting tablet servers.

This new functionality eliminates the need to ignore spurious duplicate row key 
errors...


Line 101: - link:https://issues.apache.org/jira/browse/KUDU-1516[KUDU-1516] 
Added improvements to the
The `kudu-ksck` tool has been improved and now detects problems such as when a 
tablet does not have a majority of replicas 

s/Thus//


Line 107: - link:https://gerrit.cloudera.org:8080/3477[Gerrit #3477] Reworked 
how operations are buffered in
The way operations are buffered in the client has been reworked. Previously...


Line 113: - link:https://gerrit.cloudera.org/#/c/3674/[Gerrit #3674] Added add 
LESS and GREATER options for
s/add//


Line 122:   The effect was that the RPC would not be sent, and users of the 
synchronous API would get
s/get/receive


Line 127:   a tablet server or master. This would exhibit itself the same way 
Gerrit #3541 did.
This would manifest in the same way as Gerrit #3541.


-- 
To view, visit http://gerrit.cloudera.org:8080/3802
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdc9fd57b05434874845ffa9c0ff905b5b8d0422
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Misty Stanley-Jones 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1542: in some cases apply will hang.

2016-07-28 Thread song bruce zhang (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3787

to look at the new patch set (#6).

Change subject: KUDU-1542: in some cases apply will hang.
..

KUDU-1542: in some cases apply will hang.

In current implementation, apply will retry
forever when met failure. It would be better to
have some deadline to stop it from hanging.

Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java
1 file changed, 18 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/3787/6
-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang

[kudu-CR] KUDU-1542: in some cases apply will hang.

2016-07-28 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1542: in some cases apply will hang.
..


Patch Set 5:

Build Started http://104.196.14.100/job/kudu-gerrit/2674/

-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang 
Gerrit-HasComments: No