[kudu-CR] [tools] command to reset authz cache in kudu CLI
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/13139 )
Change subject: [tools] command to reset authz cache in kudu CLI
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/CMakeLists.txt
File src/kudu/tools/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/CMakeLists.txt@45
PS1, Line 45: tool_action.cc
: table_scanner.cc
> Revert alphabetical order?
Done
http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/tool_action_master.cc
File src/kudu/tools/tool_action_master.cc:
http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/tool_action_master.cc@197
PS1, Line 197: t pri
> nit: the
Done
http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/tool_action_master.cc@202
PS1, Line 202: Operate on authz cache
> nit: how about "Operate on the authz cache of a Kudu Master"
Done
http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/tool_action_master.cc@195
PS1, Line 195: unique_ptr action_reset =
: ActionBuilder("reset", )
: .Description("Reset privileges cache")
: .AddRequiredParameter({ kMasterAddressArg,
kMasterAddressDesc })
: .Build();
:
: unique_ptr mode_authz_cache =
ModeBuilder("authz_cache")
: .Description("Operate on authz cache")
: .AddAction(std::move(action_reset))
: .Build();
: builder.AddMode(std::move(mode_authz_cache));
> Why bother separating this out?
Yeah, I guess we might need something like 'invalidate entries for particular
user' and listing the information in the cache as well, yep.
--
To view, visit http://gerrit.cloudera.org:8080/13139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If49f3ebdea22ea0df3aaec313b4db949dc834943
Gerrit-Change-Number: 13139
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 27 Apr 2019 05:55:00 +
Gerrit-HasComments: Yes
[kudu-CR] [tools] command to reset authz cache in kudu CLI
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13139 to look at the new patch set (#2). Change subject: [tools] command to reset authz cache in kudu CLI .. [tools] command to reset authz cache in kudu CLI Added command to reset authz privileges cache into kudu CLI. Synopsis: kudu master authz_cache reset Added corresponding tests as well. Change-Id: If49f3ebdea22ea0df3aaec313b4db949dc834943 --- M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_master.cc 3 files changed, 152 insertions(+), 63 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/13139/2 -- To view, visit http://gerrit.cloudera.org:8080/13139 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If49f3ebdea22ea0df3aaec313b4db949dc834943 Gerrit-Change-Number: 13139 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tools] command to reset authz cache in kudu CLI
Andrew Wong has posted comments on this change. (
http://gerrit.cloudera.org:8080/13139 )
Change subject: [tools] command to reset authz cache in kudu CLI
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/CMakeLists.txt
File src/kudu/tools/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/CMakeLists.txt@45
PS1, Line 45: tool_action.cc
: table_scanner.cc
Revert alphabetical order?
http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/tool_action_master.cc
File src/kudu/tools/tool_action_master.cc:
http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/tool_action_master.cc@197
PS1, Line 197: t pri
nit: the
http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/tool_action_master.cc@202
PS1, Line 202: Operate on authz cache
nit: how about "Operate on the authz cache of a Kudu Master"
http://gerrit.cloudera.org:8080/#/c/13139/1/src/kudu/tools/tool_action_master.cc@195
PS1, Line 195: unique_ptr action_reset =
: ActionBuilder("reset", )
: .Description("Reset privileges cache")
: .AddRequiredParameter({ kMasterAddressArg,
kMasterAddressDesc })
: .Build();
:
: unique_ptr mode_authz_cache =
ModeBuilder("authz_cache")
: .Description("Operate on authz cache")
: .AddAction(std::move(action_reset))
: .Build();
: builder.AddMode(std::move(mode_authz_cache));
Why bother separating this out?
My guess is this is in preparation for further tooling? Perhaps a `kudu master
authz_cache list` tool or somesuch?
--
To view, visit http://gerrit.cloudera.org:8080/13139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If49f3ebdea22ea0df3aaec313b4db949dc834943
Gerrit-Change-Number: 13139
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 27 Apr 2019 04:58:54 +
Gerrit-HasComments: Yes
[kudu-CR] [tools] command to reset authz cache in kudu CLI
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13139 Change subject: [tools] command to reset authz cache in kudu CLI .. [tools] command to reset authz cache in kudu CLI Added command to reset authz privileges cache into kudu CLI. The synopsis for the command is kudu master authz_cache reset Added corresponding tests as well. Change-Id: If49f3ebdea22ea0df3aaec313b4db949dc834943 --- M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_master.cc 4 files changed, 153 insertions(+), 64 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/13139/1 -- To view, visit http://gerrit.cloudera.org:8080/13139 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If49f3ebdea22ea0df3aaec313b4db949dc834943 Gerrit-Change-Number: 13139 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] WIP [master sentry-itest] a couple of yet disabled tests
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13138 ) Change subject: WIP [master_sentry-itest] a couple of yet disabled tests .. Patch Set 1: Verified+1 unrelated flakes: * org.apache.kudu.client.TestTimeouts * org.apache.kudu.client.TestSecurity * org.apache.kudu.spark.kudu.DefaultSourceTest * org.apache.kudu.client.TestAuthTokenReacquire -- To view, visit http://gerrit.cloudera.org:8080/13138 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic446160e775eb0d349d3d265969cb3ddb95bf979 Gerrit-Change-Number: 13138 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Comment-Date: Sat, 27 Apr 2019 01:15:36 + Gerrit-HasComments: No
[kudu-CR] WIP [master sentry-itest] a couple of yet disabled tests
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13138 ) Change subject: WIP [master_sentry-itest] a couple of yet disabled tests .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13138 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Ic446160e775eb0d349d3d265969cb3ddb95bf979 Gerrit-Change-Number: 13138 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao
[kudu-CR] hms: mark latency flag as hidden
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13135 ) Change subject: hms: mark latency flag as hidden .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75 Gerrit-Change-Number: 13135 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 27 Apr 2019 01:02:07 + Gerrit-HasComments: No
[kudu-CR] hms: mark latency flag as hidden
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13135 ) Change subject: hms: mark latency flag as hidden .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75 Gerrit-Change-Number: 13135 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 27 Apr 2019 01:00:16 + Gerrit-HasComments: No
[kudu-CR] WIP [master sentry-itest] a couple of yet disabled tests
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13138 Change subject: WIP [master_sentry-itest] a couple of yet disabled tests .. WIP [master_sentry-itest] a couple of yet disabled tests Added a couple of test scenarios that are supposed to pass, but they currently do not. It's necessary to figure out what's wrong with them. WIP: clarify on the test failures when tests are enabled Change-Id: Ic446160e775eb0d349d3d265969cb3ddb95bf979 --- M src/kudu/integration-tests/master_sentry-itest.cc 1 file changed, 132 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/13138/1 -- To view, visit http://gerrit.cloudera.org:8080/13138 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic446160e775eb0d349d3d265969cb3ddb95bf979 Gerrit-Change-Number: 13138 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] hms: mark latency flag as hidden
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13135 ) Change subject: hms: mark latency flag as hidden .. Patch Set 1: Verified+1 Seems like a test failed due to NTP issues. It's unrelated. master_main.cc:80] Check failed: _s.ok() Bad status: Runtime error: Cannot initialize clock: failed to wait for clock sync using command '/usr/sbin/ntp-wait -s 1 -n 60': /usr/sbin/ntp-wait: process exited with non-zero status 1 -- To view, visit http://gerrit.cloudera.org:8080/13135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75 Gerrit-Change-Number: 13135 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 27 Apr 2019 00:22:19 + Gerrit-HasComments: No
[kudu-CR] hms: mark latency flag as hidden
Andrew Wong has removed a vote on this change. Change subject: hms: mark latency flag as hidden .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75 Gerrit-Change-Number: 13135 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [master sentry-itest] a bit more concise signature for functions
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13137 ) Change subject: [master_sentry-itest] a bit more concise signature for functions .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0465b19cc14b3f3ee9160c80bb9283d3f36f3db5 Gerrit-Change-Number: 13137 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Hao Hao Gerrit-Comment-Date: Sat, 27 Apr 2019 00:04:28 + Gerrit-HasComments: No
[kudu-CR] [master sentry-itest] a bit more concise signature for functions
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13137 ) Change subject: [master_sentry-itest] a bit more concise signature for functions .. Patch Set 1: Verified+1 Unrelated flakes in: * org.apache.kudu.spark.kudu.DefaultSourceTest * org.apache.kudu.client.TestTimeouts -- To view, visit http://gerrit.cloudera.org:8080/13137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0465b19cc14b3f3ee9160c80bb9283d3f36f3db5 Gerrit-Change-Number: 13137 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Hao Hao Gerrit-Comment-Date: Fri, 26 Apr 2019 23:37:39 + Gerrit-HasComments: No
[kudu-CR] [master sentry-itest] a bit more concise signature for functions
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13137 ) Change subject: [master_sentry-itest] a bit more concise signature for functions .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I0465b19cc14b3f3ee9160c80bb9283d3f36f3db5 Gerrit-Change-Number: 13137 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Hao Hao
[kudu-CR] [master sentry-itest] a bit more concise signature for functions
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13137 Change subject: [master_sentry-itest] a bit more concise signature for functions .. [master_sentry-itest] a bit more concise signature for functions This patch updates the signatures of the privileges and action test functions. I also did additional minor grooming of the code in the master_sentry-itest.cc file. This changelist does not contain any functional modifications. Change-Id: I0465b19cc14b3f3ee9160c80bb9283d3f36f3db5 --- M src/kudu/integration-tests/master_sentry-itest.cc 1 file changed, 123 insertions(+), 112 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/13137/1 -- To view, visit http://gerrit.cloudera.org:8080/13137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0465b19cc14b3f3ee9160c80bb9283d3f36f3db5 Gerrit-Change-Number: 13137 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] hms: mark latency flag as hidden
Andrew Wong has removed a vote on this change. Change subject: hms: mark latency flag as hidden .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75 Gerrit-Change-Number: 13135 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] hms: mark latency flag as hidden
Andrew Wong has removed a vote on this change. Change subject: hms: mark latency flag as hidden .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75 Gerrit-Change-Number: 13135 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] hms: mark latency flag as hidden
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13135 ) Change subject: hms: mark latency flag as hidden .. Patch Set 1: Retriggered. Looks like the failures are NTP-related. -- To view, visit http://gerrit.cloudera.org:8080/13135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75 Gerrit-Change-Number: 13135 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 23:06:37 + Gerrit-HasComments: No
[kudu-CR] hms: remove experimental tag from hms flags
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/3/src/kudu/master/hms_notification_log_listener.cc File src/kudu/master/hms_notification_log_listener.cc: http://gerrit.cloudera.org:8080/#/c/13124/3/src/kudu/master/hms_notification_log_listener.cc@60 PS3, Line 60: DEFINE_uint32(hive_metastore_notification_log_poll_inject_latency_ms, 0, > +1 https://gerrit.cloudera.org/c/13135/ done -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 22:48:42 + Gerrit-HasComments: Yes
[kudu-CR] hms: mark latency flag as hidden
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13135 Change subject: hms: mark latency flag as hidden .. hms: mark latency flag as hidden Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75 --- M src/kudu/master/hms_notification_log_listener.cc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/13135/1 -- To view, visit http://gerrit.cloudera.org:8080/13135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75 Gerrit-Change-Number: 13135 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
[kudu-CR] sentry: remove experimental tag from sentry flags
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13133 ) Change subject: sentry: remove experimental tag from sentry flags .. sentry: remove experimental tag from sentry flags Like the HMS integration, the Sentry integration is shaping up to be usable, so to facilitate usage and testing, this patch tags the associated configurations as "evolving" (the default). Change-Id: I1a43a6d4b02402843af787479456954871ed07cd Reviewed-on: http://gerrit.cloudera.org:8080/13133 Tested-by: Kudu Jenkins Reviewed-by: Hao Hao Reviewed-by: Adar Dembo --- M src/kudu/master/sentry_privileges_fetcher.cc 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Kudu Jenkins: Verified Hao Hao: Looks good to me, approved Adar Dembo: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/13133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1a43a6d4b02402843af787479456954871ed07cd Gerrit-Change-Number: 13133 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] hms: remove experimental tag from hms flags
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. hms: remove experimental tag from hms flags The HMS integration has been in our codebase for a while now. While the behavior of integration may change (a la KUDU-2799), the configuration options themselves aren't likely to do so. This patch tags the necessary configuration flags as "evolving" (the default) to facilitate their usage and testing of the integration. Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Reviewed-on: http://gerrit.cloudera.org:8080/13124 Tested-by: Kudu Jenkins Reviewed-by: Hao Hao Reviewed-by: Adar Dembo --- M src/kudu/hms/hms_catalog.cc M src/kudu/master/hms_notification_log_listener.cc 2 files changed, 0 insertions(+), 10 deletions(-) Approvals: Kudu Jenkins: Verified Hao Hao: Looks good to me, approved Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] sentry: remove experimental tag from sentry flags
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13133 ) Change subject: sentry: remove experimental tag from sentry flags .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13133/1/src/kudu/master/sentry_privileges_fetcher.cc File src/kudu/master/sentry_privileges_fetcher.cc: http://gerrit.cloudera.org:8080/#/c/13133/1/src/kudu/master/sentry_privileges_fetcher.cc@116 PS1, Line 116: DEFINE_uint32(sentry_privileges_cache_capacity_mb, 256, > Not related to this patch, but we should validate that this is less than th There is a task for that in the scope of kudu-authz project (no upstream JIRA issue for that, though). -- To view, visit http://gerrit.cloudera.org:8080/13133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a43a6d4b02402843af787479456954871ed07cd Gerrit-Change-Number: 13133 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 22:07:08 + Gerrit-HasComments: Yes
[kudu-CR] hms: remove experimental tag from hms flags
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/3/src/kudu/master/hms_notification_log_listener.cc File src/kudu/master/hms_notification_log_listener.cc: http://gerrit.cloudera.org:8080/#/c/13124/3/src/kudu/master/hms_notification_log_listener.cc@60 PS3, Line 60: DEFINE_uint32(hive_metastore_notification_log_poll_inject_latency_ms, 0, > Not your fault, but this should be tagged as hidden. Separate patch is fine +1 -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 22:05:47 + Gerrit-HasComments: Yes
[kudu-CR] hms: remove experimental tag from hms flags
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/3/src/kudu/master/hms_notification_log_listener.cc File src/kudu/master/hms_notification_log_listener.cc: http://gerrit.cloudera.org:8080/#/c/13124/3/src/kudu/master/hms_notification_log_listener.cc@60 PS3, Line 60: DEFINE_uint32(hive_metastore_notification_log_poll_inject_latency_ms, 0, Not your fault, but this should be tagged as hidden. Separate patch is fine if you prefer. -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 21:22:24 + Gerrit-HasComments: Yes
[kudu-CR] [backup] Ensure the last metadata is restored
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13132 ) Change subject: [backup] Ensure the last metadata is restored .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13132/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13132/1//COMMIT_MSG@9 PS1, Line 9: metdata metadata http://gerrit.cloudera.org:8080/#/c/13132/1//COMMIT_MSG@12 PS1, Line 12: metdata metadata http://gerrit.cloudera.org:8080/#/c/13132/1//COMMIT_MSG@12 PS1, Line 12: This is the first step to allow table alterations. Follow on patches will take care of metdata validation and alteration Wrapping got weird here. -- To view, visit http://gerrit.cloudera.org:8080/13132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08dce740d6e5063708cce7f690718f895348fc54 Gerrit-Change-Number: 13132 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Fri, 26 Apr 2019 21:29:01 + Gerrit-HasComments: Yes
[kudu-CR] [master] add RPC to reset AuthzProvider's cache
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13063 ) Change subject: [master] add RPC to reset AuthzProvider's cache .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a5c1f84172acf5751f68edfb8a9bb25df6b3f6 Gerrit-Change-Number: 13063 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 21:23:37 + Gerrit-HasComments: No
[kudu-CR] sentry: remove experimental tag from sentry flags
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13133 ) Change subject: sentry: remove experimental tag from sentry flags .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/13133/1/src/kudu/master/sentry_privileges_fetcher.cc File src/kudu/master/sentry_privileges_fetcher.cc: http://gerrit.cloudera.org:8080/#/c/13133/1/src/kudu/master/sentry_privileges_fetcher.cc@116 PS1, Line 116: DEFINE_uint32(sentry_privileges_cache_capacity_mb, 256, Not related to this patch, but we should validate that this is less than the memory limit, and maybe even less than the memory limit + the block cache capacity. -- To view, visit http://gerrit.cloudera.org:8080/13133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a43a6d4b02402843af787479456954871ed07cd Gerrit-Change-Number: 13133 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 21:21:16 + Gerrit-HasComments: Yes
[kudu-CR] [master] add RPC to reset AuthzProvider's cache
Hao Hao has posted comments on this change. (
http://gerrit.cloudera.org:8080/13063 )
Change subject: [master] add RPC to reset AuthzProvider's cache
..
Patch Set 6: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13063/5/src/kudu/integration-tests/master_sentry-itest.cc
File src/kudu/integration-tests/master_sentry-itest.cc:
http://gerrit.cloudera.org:8080/#/c/13063/5/src/kudu/integration-tests/master_sentry-itest.cc@203
PS5, Line 203: AlterTabl
> It was used in the new code exploiting {Create,Drop}Table(). Since it was
Thanks for the explanation, LGTM.
http://gerrit.cloudera.org:8080/#/c/13063/5/src/kudu/integration-tests/master_sentry-itest.cc@759
PS5, Line 759: _alterer(
> CreateTable doesn't work in such a scenario: it fails. I have that in my r
LGTM.
--
To view, visit http://gerrit.cloudera.org:8080/13063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9a5c1f84172acf5751f68edfb8a9bb25df6b3f6
Gerrit-Change-Number: 13063
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Hao Hao
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 26 Apr 2019 21:04:42 +
Gerrit-HasComments: Yes
[kudu-CR] hms: remove experimental tag from hms flags
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 20:58:52 + Gerrit-HasComments: No
[kudu-CR] [backup] Add more metadata fields
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13130 ) Change subject: [backup] Add more metadata fields .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13130/1/java/kudu-backup/src/main/protobuf/backup.proto File java/kudu-backup/src/main/protobuf/backup.proto: http://gerrit.cloudera.org:8080/#/c/13130/1/java/kudu-backup/src/main/protobuf/backup.proto@120 PS1, Line 120: // A map of column name to internal column id. : // This is useful for detecting dropped and added columns. > Can you doc why column IDs are here and not in ColumnMetadataPB? You could > always build a map at runtime after loading the protobuf. I kept them separate because they are for separate things. Once is primarily for recreating the columns, while the other is primarily for validation. If someone were hand crafting a json file for the sake of creating a table, they don't need the ids. > Also, should we track all column IDs that ever existed? Or the max column ID? > Would either be useful to backup/restore? I don't have a reason for this yet. We can add it if we do. http://gerrit.cloudera.org:8080/#/c/13130/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java File java/kudu-client/src/main/java/org/apache/kudu/Schema.java: PS1: > Do you remember off-hand when the master supplies a schema with column IDs I am not positive off-hand, but I was under the impression Schemas from the server always have Ids. Schemas constructed by users client side don't. http://gerrit.cloudera.org:8080/#/c/13130/1/java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java File java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java: PS1: > Hmm, why isn't this in src/test/java? It's used in application code for non unit testing reasons like the DistributedDataGenerator. -- To view, visit http://gerrit.cloudera.org:8080/13130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42458f598a523596acb9f18558e6f518719a969b Gerrit-Change-Number: 13130 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Fri, 26 Apr 2019 20:59:21 + Gerrit-HasComments: Yes
[kudu-CR] sentry: remove experimental tag from sentry flags
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13133 Change subject: sentry: remove experimental tag from sentry flags .. sentry: remove experimental tag from sentry flags Like the HMS integration, the Sentry integration is shaping up to be usable, so to facilitate usage and testing, this patch tags the associated configurations as "evolving" (the default). Change-Id: I1a43a6d4b02402843af787479456954871ed07cd --- M src/kudu/master/sentry_privileges_fetcher.cc 1 file changed, 0 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/13133/1 -- To view, visit http://gerrit.cloudera.org:8080/13133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1a43a6d4b02402843af787479456954871ed07cd Gerrit-Change-Number: 13133 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
[kudu-CR] hms: remove experimental tag from hms flags
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13124 to look at the new patch set (#3). Change subject: hms: remove experimental tag from hms flags .. hms: remove experimental tag from hms flags The HMS integration has been in our codebase for a while now. While the behavior of integration may change (a la KUDU-2799), the configuration options themselves aren't likely to do so. This patch tags the necessary configuration flags as "evolving" (the default) to facilitate their usage and testing of the integration. Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e --- M src/kudu/hms/hms_catalog.cc M src/kudu/master/hms_notification_log_listener.cc 2 files changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/13124/3 -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] hms: remove experimental tag from hms flags
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/2/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/13124/2/src/kudu/hms/hms_catalog.cc@71 PS2, Line 71: DEFINE_string(hive_metastore_kerberos_principal, "hive", : "The service principal of the Hive Metastore server. Must match " : "the primary (user) portion of hive.metastore.kerberos.principal option " : "in the Hive Metastore configuration."); > Of the first three, should this be 'advanced'? Or do you also expect it to I opted to keep it since it seems like a configuration that a user might want to touch, depending on their setup. The ones below seem like they'd require slightly deeper knowledge of the HMS thrift client and the rest of the integration. -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 19:41:07 + Gerrit-HasComments: Yes
[kudu-CR] [backup] Add more metadata fields
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13130 ) Change subject: [backup] Add more metadata fields .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/13130/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13130/1//COMMIT_MSG@9 PS1, Line 9: This patch adds more metadata fields to the metdata metadata http://gerrit.cloudera.org:8080/#/c/13130/1//COMMIT_MSG@13 PS1, Line 13: - table_id: Can be used in the future to handle dropped Nit: indentation http://gerrit.cloudera.org:8080/#/c/13130/1//COMMIT_MSG@15 PS1, Line 15: - comment: Used to backup and restore column coments. comments http://gerrit.cloudera.org:8080/#/c/13130/1/java/kudu-backup/src/main/protobuf/backup.proto File java/kudu-backup/src/main/protobuf/backup.proto: http://gerrit.cloudera.org:8080/#/c/13130/1/java/kudu-backup/src/main/protobuf/backup.proto@120 PS1, Line 120: // A map of column name to internal column id. : // This is useful for detecting dropped and added columns. Can you doc why column IDs are here and not in ColumnMetadataPB? You could always build a map at runtime after loading the protobuf. Also, should we track all column IDs that ever existed? Or the max column ID? Would either be useful to backup/restore? http://gerrit.cloudera.org:8080/#/c/13130/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java File java/kudu-client/src/main/java/org/apache/kudu/Schema.java: PS1: Do you remember off-hand when the master supplies a schema with column IDs vs. without? http://gerrit.cloudera.org:8080/#/c/13130/1/java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java File java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java: PS1: Hmm, why isn't this in src/test/java? -- To view, visit http://gerrit.cloudera.org:8080/13130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42458f598a523596acb9f18558e6f518719a969b Gerrit-Change-Number: 13130 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Fri, 26 Apr 2019 19:03:40 + Gerrit-HasComments: Yes
[kudu-CR] hms: remove experimental tag from hms flags
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/2/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/13124/2/src/kudu/hms/hms_catalog.cc@71 PS2, Line 71: DEFINE_string(hive_metastore_kerberos_principal, "hive", : "The service principal of the Hive Metastore server. Must match " : "the primary (user) portion of hive.metastore.kerberos.principal option " : "in the Hive Metastore configuration."); Of the first three, should this be 'advanced'? Or do you also expect it to be used semi-frequently? -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 18:33:14 + Gerrit-HasComments: Yes
[kudu-CR] Add PySpark info to Developing Doc
a...@phdata.io has posted comments on this change. ( http://gerrit.cloudera.org:8080/13102 ) Change subject: Add PySpark info to Developing Doc .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13102/2/docs/developing.adoc File docs/developing.adoc: http://gerrit.cloudera.org:8080/#/c/13102/2/docs/developing.adoc@224 PS2, Line 224: # Launch pyspark with the corresponding kudu spark jar : pyspark --jars kudu-spark2_2.11-1.9.0.jar > nit: if I'm not mistaken, that's for command-line shell, not for Python, ri Correct, I can put in a shell code block. -- To view, visit http://gerrit.cloudera.org:8080/13102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I352978d22300bba16f6011c86350b49474e73d73 Gerrit-Change-Number: 13102 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 18:29:12 + Gerrit-HasComments: Yes
[kudu-CR] Add PySpark info to Developing Doc
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13102 ) Change subject: Add PySpark info to Developing Doc .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13102/2/docs/developing.adoc File docs/developing.adoc: http://gerrit.cloudera.org:8080/#/c/13102/2/docs/developing.adoc@224 PS2, Line 224: # Launch pyspark with the corresponding kudu spark jar : pyspark --jars kudu-spark2_2.11-1.9.0.jar nit: if I'm not mistaken, that's for command-line shell, not for Python, right? If so, maybe separate this into a separate shell source section? -- To view, visit http://gerrit.cloudera.org:8080/13102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I352978d22300bba16f6011c86350b49474e73d73 Gerrit-Change-Number: 13102 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Jordan Birdsell Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 18:21:48 + Gerrit-HasComments: Yes
[kudu-CR] [docs] Fix formatting in administration
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13129 ) Change subject: [docs] Fix formatting in administration .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I189cb7ce3dfd04442452932cd39a83d5041ac42e Gerrit-Change-Number: 13129 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 26 Apr 2019 18:02:43 + Gerrit-HasComments: No
[kudu-CR] Make HiveMetastoreConfig class public
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13128 ) Change subject: Make HiveMetastoreConfig class public .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e7e9eaeba65512a2bcce6dc7f1202215f60266e Gerrit-Change-Number: 13128 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 26 Apr 2019 17:29:54 + Gerrit-HasComments: No
[kudu-CR] Make HiveMetastoreConfig class public
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13128 ) Change subject: Make HiveMetastoreConfig class public .. Patch Set 1: Verified+1 Test Result (1 failure / +1) RemoteKsckTest.TestClusterWithLocation -- To view, visit http://gerrit.cloudera.org:8080/13128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e7e9eaeba65512a2bcce6dc7f1202215f60266e Gerrit-Change-Number: 13128 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 26 Apr 2019 17:29:49 + Gerrit-HasComments: No
[kudu-CR] Make HiveMetastoreConfig class public
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13128 ) Change subject: Make HiveMetastoreConfig class public .. Make HiveMetastoreConfig class public Commit 2c572cbd4 introduced the Java client APIs to fetch HMS integration configuration. This patch makes the org.apache.kudu.client.HiveMetastoreConfig class, which contains the Hive Metastore configuration of a Kudu cluster, public. So that it can be accessed from outside package, e.g. org.apache.impala. Change-Id: I6e7e9eaeba65512a2bcce6dc7f1202215f60266e Reviewed-on: http://gerrit.cloudera.org:8080/13128 Reviewed-by: Todd Lipcon Reviewed-by: Alexey Serbin Tested-by: Andrew Wong Reviewed-by: Andrew Wong --- M java/kudu-client/src/main/java/org/apache/kudu/client/HiveMetastoreConfig.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Todd Lipcon: Looks good to me, approved Alexey Serbin: Looks good to me, approved Andrew Wong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6e7e9eaeba65512a2bcce6dc7f1202215f60266e Gerrit-Change-Number: 13128 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Make HiveMetastoreConfig class public
Andrew Wong has removed a vote on this change. Change subject: Make HiveMetastoreConfig class public .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I6e7e9eaeba65512a2bcce6dc7f1202215f60266e Gerrit-Change-Number: 13128 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] hms: remove experimental tag from hms flags
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 2: Verified+1 Test Result (2 failures / +1) MultiThreadedHybridClockTabletTest/5.UpdateNoMergeCompaction KuduTsCliTest.TestDumpTablet -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 17:29:07 + Gerrit-HasComments: No
[kudu-CR] hms: remove experimental tag from hms flags
Andrew Wong has removed a vote on this change. Change subject: hms: remove experimental tag from hms flags .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [backup] Add more metadata fields
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13130 Change subject: [backup] Add more metadata fields .. [backup] Add more metadata fields This patch adds more metadata fields to the metdata file for each backup. The following was added: - table_id: Can be used in the future to handle dropped or renamed tables gracefully. - comment: Used to backup and restore column coments. - column_ids: Can be used in the future to handle dropped or renamed columns gracefully. Change-Id: I42458f598a523596acb9f18558e6f518719a969b --- M java/kudu-backup/src/main/protobuf/backup.proto M java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala M java/kudu-client/src/main/java/org/apache/kudu/Schema.java M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java 5 files changed, 42 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/13130/1 -- To view, visit http://gerrit.cloudera.org:8080/13130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I42458f598a523596acb9f18558e6f518719a969b Gerrit-Change-Number: 13130 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
[kudu-CR] hms: remove experimental tag from hms flags
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 16:05:39 + Gerrit-HasComments: No
[kudu-CR] Make HiveMetastoreConfig class public
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13128 ) Change subject: Make HiveMetastoreConfig class public .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e7e9eaeba65512a2bcce6dc7f1202215f60266e Gerrit-Change-Number: 13128 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 26 Apr 2019 16:04:16 + Gerrit-HasComments: No
[kudu-CR] [docs] Fix formatting in administration
Hello Will Berkeley, Alex Rodoni, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13129 to review the following change. Change subject: [docs] Fix formatting in administration .. [docs] Fix formatting in administration Change-Id: I189cb7ce3dfd04442452932cd39a83d5041ac42e --- M docs/administration.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/13129/1 -- To view, visit http://gerrit.cloudera.org:8080/13129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I189cb7ce3dfd04442452932cd39a83d5041ac42e Gerrit-Change-Number: 13129 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Will Berkeley
[kudu-CR] Make HiveMetastoreConfig class public
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13128 ) Change subject: Make HiveMetastoreConfig class public .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e7e9eaeba65512a2bcce6dc7f1202215f60266e Gerrit-Change-Number: 13128 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 26 Apr 2019 06:53:49 + Gerrit-HasComments: No
[kudu-CR] hms: remove experimental tag from hms flags
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13124 ) Change subject: hms: remove experimental tag from hms flags .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13124/1/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/13124/1/src/kudu/hms/hms_catalog.cc@a83 PS1, Line 83: > Adar's suggestion sounds reasonable to me as well. BTW, maybe tag the rest Done. I don't think I'll tag these first three "advanced" though. Usage of the HMS integration will require the user to think about those flags, which kind of goes against the "advanced" description: they're also likely to be used only rarely and should be relegated to more detailed sections of documentation. I.e. I don't think we expect them to be used rarely, whereas we probably don't expect users to have to tune the HMS thrift client configurations very often. -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Apr 2019 06:51:42 + Gerrit-HasComments: Yes
[kudu-CR] hms: remove experimental tag from hms flags
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13124 to look at the new patch set (#2). Change subject: hms: remove experimental tag from hms flags .. hms: remove experimental tag from hms flags The HMS integration has been in our codebase for a while now. While the behavior of integration may change (a la KUDU-2799), the configuration options themselves aren't likely to do so. This patch tags the necessary configuration flags as "evolving" (the default) to facilitate their usage and testing of the integration. Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e --- M src/kudu/hms/hms_catalog.cc 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/13124/2 -- To view, visit http://gerrit.cloudera.org:8080/13124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e Gerrit-Change-Number: 13124 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Make HiveMetastoreConfig class public
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13128 Change subject: Make HiveMetastoreConfig class public .. Make HiveMetastoreConfig class public Commit 2c572cbd4 introduced the Java client APIs to fetch HMS integration configuration. This patch makes the org.apache.kudu.client.HiveMetastoreConfig class, which contains the Hive Metastore configuration of a Kudu cluster, public. So that it can be accessed from outside package, e.g. org.apache.impala. Change-Id: I6e7e9eaeba65512a2bcce6dc7f1202215f60266e --- M java/kudu-client/src/main/java/org/apache/kudu/client/HiveMetastoreConfig.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/13128/1 -- To view, visit http://gerrit.cloudera.org:8080/13128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6e7e9eaeba65512a2bcce6dc7f1202215f60266e Gerrit-Change-Number: 13128 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao
