Hongjiang Zhang has posted comments on this change. (
http://gerrit.cloudera.org:8080/17773 )
Change subject: KUDU-1260: Fix prefetching bug on Java scanner
..
Patch Set 16:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17773/11//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17773/11//COMMIT_MSG@10
PS11, Line 10: The writing thread records the timestamp of
: its write, and the scanner thread creates two scanners (w and
w/o prefetching),
: by comparing the scan result of the two scanners, we can verify
the
: prefetching result.
> It's great that this test does a lot of things, but in order to drill into
I compared the results of the two scanners in order to debug the issue. If we
only have one scanner with prefetching, the test case is simplified, but it
lost many context for debugging.
http://gerrit.cloudera.org:8080/#/c/17773/11//COMMIT_MSG@24
PS11, Line 24:
> This description is confusing. In fact, this issue is addressed by this pat
Done
--
To view, visit http://gerrit.cloudera.org:8080/17773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I853a041d86c75ec196d7d4ff45af4673c5c5f5cd
Gerrit-Change-Number: 17773
Gerrit-PatchSet: 16
Gerrit-Owner: Hongjiang Zhang
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Hongjiang Zhang
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 11 Oct 2021 03:36:23 +
Gerrit-HasComments: Yes