[kudu-CR] KUDU-1260: Fix prefetching bug on Java scanner

2021-10-10 Thread Hongjiang Zhang (Code Review)
Hongjiang Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17773 )

Change subject: KUDU-1260: Fix prefetching bug on Java scanner
..


Patch Set 16:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17773/11//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17773/11//COMMIT_MSG@10
PS11, Line 10: The writing thread records the timestamp of
 : its write, and the scanner thread creates two scanners (w and 
w/o prefetching),
 : by comparing the scan result of the two scanners, we can verify 
the
 : prefetching result.
> It's great that this test does a lot of things, but in order to drill into 
I compared the results of the two scanners in order to debug the issue. If we 
only have one scanner with prefetching, the test case is simplified, but it 
lost many context for debugging.


http://gerrit.cloudera.org:8080/#/c/17773/11//COMMIT_MSG@24
PS11, Line 24:
> This description is confusing. In fact, this issue is addressed by this pat
Done



--
To view, visit http://gerrit.cloudera.org:8080/17773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I853a041d86c75ec196d7d4ff45af4673c5c5f5cd
Gerrit-Change-Number: 17773
Gerrit-PatchSet: 16
Gerrit-Owner: Hongjiang Zhang 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hongjiang Zhang 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 11 Oct 2021 03:36:23 +
Gerrit-HasComments: Yes


[kudu-CR] [tool] Add a '-list statistics' flag to the 'kudu table list'.

2021-10-10 Thread yejiabao (Code Review)
yejiabao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/17912


Change subject: [tool] Add a '-list_statistics' flag to the 'kudu table list'.
..

[tool] Add a '-list_statistics' flag to the 'kudu table list'.

'-list_statistics' flag can help to list table's statistics
such as tablet number, replica number, and record number

Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f
---
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
6 files changed, 94 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/17912/1
--
To view, visit http://gerrit.cloudera.org:8080/17912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04e9fba724648cd2b774d031e884c5a25cc4084f
Gerrit-Change-Number: 17912
Gerrit-PatchSet: 1
Gerrit-Owner: yejiabao