[kudu-CR] [www] Add CSP header to web UI
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18285 ) Change subject: [www] Add CSP header to web UI .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I411d8f4ca079bfd5584f563aeeaa867833eb1106 Gerrit-Change-Number: 18285 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 02 Mar 2022 18:24:32 + Gerrit-HasComments: No
[kudu-CR] [www] Add CSP header to web UI
Attila Bukor has removed a vote on this change. Change subject: [www] Add CSP header to web UI .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/18285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I411d8f4ca079bfd5584f563aeeaa867833eb1106 Gerrit-Change-Number: 18285 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18275 ) Change subject: [docs] Add release notes for 1.16.0 .. [docs] Add release notes for 1.16.0 Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32 Reviewed-on: http://gerrit.cloudera.org:8080/18275 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin Reviewed-by: Andrew Wong --- M docs/release_notes.adoc 1 file changed, 146 insertions(+), 8 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.16.x Gerrit-MessageType: merged Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32 Gerrit-Change-Number: 18275 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hongjiang Zhang Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Will Berkeley Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: yejiabao
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 ) Change subject: [docs] Add release notes for 1.16.0 .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/18275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.16.x Gerrit-MessageType: comment Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32 Gerrit-Change-Number: 18275 Gerrit-PatchSet: 9 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hongjiang Zhang Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Will Berkeley Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: yejiabao Gerrit-Comment-Date: Wed, 02 Mar 2022 17:50:19 + Gerrit-HasComments: No
[kudu-CR] [www] Add CSP header to web UI
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/18285 to review the following change. Change subject: [www] Add CSP header to web UI .. [www] Add CSP header to web UI CSP (Content Security Policy) headers provide a way to tell the browser where assets can be loaded from to prevent XSS attacks. Kudu's web UI is read-only, at least for now, so it's not susceptible for XSS attacks, but some security scanners still flag it as vulnerable due to not having this header. This patch adds a CSP header that allows loading assets on the same host, and some inline styles and images in jQuery. It also removes all inline style definitions from first-party files and moves them to kudu.css. There's no good way to write a unit test for this, as it requires a GUI browser (curl doesn't load external resources and doesn't use JavaScript), but I tested it manually both through HTTP and HTTPS and confirmed there are no related errors in the JS console. Change-Id: I411d8f4ca079bfd5584f563aeeaa867833eb1106 --- M src/kudu/server/webserver.cc M www/kudu.css M www/startup.mustache 3 files changed, 21 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/18285/1 -- To view, visit http://gerrit.cloudera.org:8080/18285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I411d8f4ca079bfd5584f563aeeaa867833eb1106 Gerrit-Change-Number: 18285 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong
[kudu-CR](branch-1.16.x) [docs] Add release notes for 1.16.0
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18275 ) Change subject: [docs] Add release notes for 1.16.0 .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/18275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.16.x Gerrit-MessageType: comment Gerrit-Change-Id: I0beb2e182af261ce785cfe21c7de34ca953e6a32 Gerrit-Change-Number: 18275 Gerrit-PatchSet: 9 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hongjiang Zhang Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Khazar Mammadli Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Will Berkeley Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: yejiabao Gerrit-Comment-Date: Wed, 02 Mar 2022 17:33:06 + Gerrit-HasComments: No
[kudu-CR] KUDU-3197 [tserver] optimal Schema's memory used, using std::shared ptr
Hello Yingchun Lai, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18255 to look at the new patch set (#11). Change subject: KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr .. KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr Change TabletMeta's variable Schema* to std::shared_ptr to reduce memory used when alter schema. Because TabletMeta save old_schemas to reserve the elder schemas when alter schema, maybe they have been used by scanners or compaction jobs. As jira KUDU-3197 said, frequently alter schema will lead to tserver's memory becomes very large, just like memory leak, especially column's number is very large. The jira issued by wangningito, and I continue his work, and now use std::shared_ptr instead of scoped_refptr, because scoped_refptr causes too many changes, just as: https://gerrit.cloudera.org/c/18098/ Conflicts: src/kudu/master/sys_catalog.cc src/kudu/tablet/tablet.cc src/kudu/tablet/tablet_metadata.cc src/kudu/tserver/tablet_service.cc Change-Id: Ic284dde108c49130419d876c6698b40c195e9b35 --- M src/kudu/client/client-test.cc M src/kudu/common/schema.h M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/all_types-scan-correctness-test.cc M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/cfile_set.h M src/kudu/tablet/diff_scan-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/ops/alter_schema_op.cc M src/kudu/tablet/ops/alter_schema_op.h M src/kudu/tablet/ops/op.h M src/kudu/tablet/ops/write_op.h M src/kudu/tablet/rowset_metadata.h M src/kudu/tablet/tablet-schema-test.cc M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_metadata.cc M src/kudu/tablet/tablet_metadata.h M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_fs.cc M src/kudu/tools/tool_action_local_replica.cc M src/kudu/tserver/scanners.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tserver_path_handlers.cc 30 files changed, 161 insertions(+), 149 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/18255/11 -- To view, visit http://gerrit.cloudera.org:8080/18255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic284dde108c49130419d876c6698b40c195e9b35 Gerrit-Change-Number: 18255 Gerrit-PatchSet: 11 Gerrit-Owner: Yuqi Du Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du
[kudu-CR] KUDU-3197 [tserver] optimal Schema's memory used, using std::shared ptr
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18255 ) Change subject: KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/18255/8/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: http://gerrit.cloudera.org:8080/#/c/18255/8/src/kudu/tablet/tablet_metadata.h@379 PS8, Line 379: Sch > nit: maybe remove the Set here, so it's just SwapSchemaUnlocked Done http://gerrit.cloudera.org:8080/#/c/18255/8/src/kudu/tablet/tablet_metadata.h@447 PS8, Line 447: SchemaPtr schema_; > nit: I'm not sure what this means. There doesn't seem to be much of a diff This is an old comment. I will remove it. -- To view, visit http://gerrit.cloudera.org:8080/18255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic284dde108c49130419d876c6698b40c195e9b35 Gerrit-Change-Number: 18255 Gerrit-PatchSet: 9 Gerrit-Owner: Yuqi Du Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du Gerrit-Comment-Date: Wed, 02 Mar 2022 14:20:09 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-3197 [tserver] optimal Schema's memory used, using std::shared ptr
Hello Yingchun Lai, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18255 to look at the new patch set (#10). Change subject: KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr .. KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr Change TabletMeta's variable Schema* to std::shared_ptr to reduce memory used when alter schema. Because TabletMeta save old_schemas to reserve the elder schemas when alter schema, maybe they have been used by scanners or compaction jobs. As jira KUDU-3197 said, frequently alter schema will lead to tserver's memory becomes very large, just like memory leak, especially column's number is very large. The jira issued by wangningito, and I continue his work, and now use std::shared_ptr instead of scoped_refptr, because scoped_refptr causes too many changes, just as: https://gerrit.cloudera.org/c/18098/ Conflicts: src/kudu/master/sys_catalog.cc src/kudu/tablet/tablet.cc src/kudu/tablet/tablet_metadata.cc src/kudu/tserver/tablet_service.cc Change-Id: Ic284dde108c49130419d876c6698b40c195e9b35 --- M src/kudu/client/client-test.cc M src/kudu/common/schema.h M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/all_types-scan-correctness-test.cc M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/cfile_set.h M src/kudu/tablet/diff_scan-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/ops/alter_schema_op.cc M src/kudu/tablet/ops/alter_schema_op.h M src/kudu/tablet/ops/op.h M src/kudu/tablet/ops/write_op.h M src/kudu/tablet/rowset_metadata.h M src/kudu/tablet/tablet-schema-test.cc M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_metadata.cc M src/kudu/tablet/tablet_metadata.h M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_fs.cc M src/kudu/tools/tool_action_local_replica.cc M src/kudu/tserver/scanners.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tserver_path_handlers.cc 30 files changed, 161 insertions(+), 149 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/18255/10 -- To view, visit http://gerrit.cloudera.org:8080/18255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic284dde108c49130419d876c6698b40c195e9b35 Gerrit-Change-Number: 18255 Gerrit-PatchSet: 10 Gerrit-Owner: Yuqi Du Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du
[kudu-CR] KUDU-3197 [tserver] optimal Schema's memory used, using std::shared ptr
Hello Yingchun Lai, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18255 to look at the new patch set (#9). Change subject: KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr .. KUDU-3197 [tserver] optimal Schema's memory used, using std::shared_ptr Change TabletMeta's variable Schema* to std::shared_ptr to reduce memory used when alter schema. Because TabletMeta save old_schemas to reserve the elder schemas when alter schema, maybe they have been used by scanners or compaction jobs. As jira KUDU-3197 said, frequently alter schema will lead to tserver's memory becomes very large, just like memory leak, especially column's number is very large. The jira issued by wangningito, and I continue his work, and now use std::shared_ptr instead of scoped_refptr, because scoped_refptr causes too many changes, just as: https://gerrit.cloudera.org/c/18098/ Conflicts: src/kudu/master/sys_catalog.cc src/kudu/tablet/tablet.cc src/kudu/tablet/tablet_metadata.cc src/kudu/tserver/tablet_service.cc Change-Id: Ic284dde108c49130419d876c6698b40c195e9b35 --- M src/kudu/client/client-test.cc M src/kudu/common/schema.h M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/all_types-scan-correctness-test.cc M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/cfile_set.h M src/kudu/tablet/diff_scan-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/ops/alter_schema_op.cc M src/kudu/tablet/ops/alter_schema_op.h M src/kudu/tablet/ops/op.h M src/kudu/tablet/ops/write_op.h M src/kudu/tablet/rowset_metadata.h M src/kudu/tablet/tablet-schema-test.cc M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_metadata.cc M src/kudu/tablet/tablet_metadata.h M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_fs.cc M src/kudu/tools/tool_action_local_replica.cc M src/kudu/tserver/scanners.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tserver_path_handlers.cc 30 files changed, 161 insertions(+), 149 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/18255/9 -- To view, visit http://gerrit.cloudera.org:8080/18255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic284dde108c49130419d876c6698b40c195e9b35 Gerrit-Change-Number: 18255 Gerrit-PatchSet: 9 Gerrit-Owner: Yuqi Du Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Yuqi Du
