[kudu-CR] [rpc] fix typo in branch prediction
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21044 ) Change subject: [rpc] fix typo in branch prediction .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5af612277dc5b03bdee597212885d47c823a6025 Gerrit-Change-Number: 21044 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 21 Feb 2024 07:36:47 + Gerrit-HasComments: No
[kudu-CR] [rpc] fix typo in branch prediction
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21044 Change subject: [rpc] fix typo in branch prediction .. [rpc] fix typo in branch prediction This is a follow-up to 3f0c434143ad6daa8ed4f39d8ceacbe58604dd29 Change-Id: I5af612277dc5b03bdee597212885d47c823a6025 --- M src/kudu/rpc/service_pool.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/21044/1 -- To view, visit http://gerrit.cloudera.org:8080/21044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5af612277dc5b03bdee597212885d47c823a6025 Gerrit-Change-Number: 21044 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [Java] Fix concurrent problem while traversing the traces of KuduRpc.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21041 ) Change subject: [Java] Fix concurrent problem while traversing the traces of KuduRpc. .. Patch Set 8: (2 comments) Thank you for the fix! http://gerrit.cloudera.org:8080/#/c/21041/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21041/8//COMMIT_MSG@10 PS8, Line 10: HashedWheelTimeout HashedWheelTimer http://gerrit.cloudera.org:8080/#/c/21041/8//COMMIT_MSG@12 PS8, Line 12: which leads to : exception in timeout task Could you add an example of such a trace into the commit description? It could help people to identify the problem if they hit it. BTW, what is the other actors that might be modifying the collection of traces during that time? Are those only related to late responses that arrive past the timeout or that might be something else? -- To view, visit http://gerrit.cloudera.org:8080/21041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a642d93d01ebcfa05b01fe263023b5580d2542b Gerrit-Change-Number: 21041 Gerrit-PatchSet: 8 Gerrit-Owner: Song Jiacheng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Feb 2024 17:13:58 + Gerrit-HasComments: Yes
[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21030 to look at the new patch set (#4). Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 .. [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 Work in progress. The gradle wrapper has been upgraded to 7.6.4, however the publishing plugin has been disabled. Remaining tasks: * clean up code * rewrite the publishing gradle task with maven-publishing plugin * fix/confirm java test failures * prep for gradle 8 upgrade * test distTest Change-Id: I915dab011aba633d55a79c72ea6f459d703d7f47 --- M java/build.gradle M java/buildSrc/build.gradle M java/gradle/artifacts.gradle M java/gradle/dependencies.gradle M java/gradle/publishing.gradle M java/gradle/quality.gradle D java/gradle/scopes.gradle M java/gradle/shadow.gradle M java/gradle/wrapper/gradle-wrapper.properties M java/gradlew M java/kudu-backup-common/build.gradle M java/kudu-backup-tools/build.gradle M java/kudu-backup/build.gradle M java/kudu-client/build.gradle M java/kudu-hive/build.gradle M java/kudu-jepsen/build.gradle M java/kudu-proto/build.gradle M java/kudu-spark-tools/build.gradle M java/kudu-spark/build.gradle M java/kudu-subprocess/build.gradle M java/kudu-test-utils/build.gradle 21 files changed, 442 insertions(+), 402 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/21030/4 -- To view, visit http://gerrit.cloudera.org:8080/21030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I915dab011aba633d55a79c72ea6f459d703d7f47 Gerrit-Change-Number: 21030 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Chovan Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Java] Fix concurrent problem while traversing the traces of KuduRpc.
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21041 to look at the new patch set (#8). Change subject: [Java] Fix concurrent problem while traversing the traces of KuduRpc. .. [Java] Fix concurrent problem while traversing the traces of KuduRpc. When the RPC request which is sent by java client times out, the RpcTimeoutTask is called by HashedWheelTimeout. During the running of this task, KuduRpc#toString() is called. This method will traverse the traces(a synchronizedList) without any protection, which leads to exception in timeout task and then the callback will not be triggered. So make a copy of the traces and then traverse the copy. This method is mostly called when some exceptions are raised, so the influence on performance should be acceptable. Change-Id: I1a642d93d01ebcfa05b01fe263023b5580d2542b --- M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/21041/8 -- To view, visit http://gerrit.cloudera.org:8080/21041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1a642d93d01ebcfa05b01fe263023b5580d2542b Gerrit-Change-Number: 21041 Gerrit-PatchSet: 8 Gerrit-Owner: Song Jiacheng Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Java] Fix concurrent problem while traverse the traces of KuduRpc.
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21041 to look at the new patch set (#7). Change subject: [Java] Fix concurrent problem while traverse the traces of KuduRpc. .. [Java] Fix concurrent problem while traverse the traces of KuduRpc. When the RPC request which is sent by java client times out, the RpcTimeoutTask is called by HashedWheelTimeout. During the running of this task, KuduRpc#toString() is called. This method will traverse the traces(a synchronizedList) without any protection, which leads to exception in timeout task and then the callback will not be triggered. So make a copy of the traces and then traverse the copy. This method is mostly called when some exceptions are raised, so the influence on performance should be acceptable. Change-Id: I1a642d93d01ebcfa05b01fe263023b5580d2542b --- M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/21041/7 -- To view, visit http://gerrit.cloudera.org:8080/21041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1a642d93d01ebcfa05b01fe263023b5580d2542b Gerrit-Change-Number: 21041 Gerrit-PatchSet: 7 Gerrit-Owner: Song Jiacheng Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [wip][build] KUDU-3551 Upgrade gradle to 7.6.4
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21030 to look at the new patch set (#3). Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 .. [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 Work in progress. The gradle wrapper has been upgraded to 7.6.4, however the publishing plugin has been disabled. Remaining tasks: * clean up code * rewrite the publishing gradle task with maven-publishing plugin * fix/confirm java test failures * prep for gradle 8 upgrade * test distTest Change-Id: I915dab011aba633d55a79c72ea6f459d703d7f47 --- M java/build.gradle M java/buildSrc/build.gradle M java/gradle/artifacts.gradle M java/gradle/dependencies.gradle M java/gradle/publishing.gradle M java/gradle/quality.gradle M java/gradle/scopes.gradle M java/gradle/shadow.gradle M java/gradle/wrapper/gradle-wrapper.properties M java/gradlew M java/kudu-backup-common/build.gradle M java/kudu-backup-tools/build.gradle M java/kudu-backup/build.gradle M java/kudu-client/build.gradle M java/kudu-hive/build.gradle M java/kudu-jepsen/build.gradle M java/kudu-proto/build.gradle M java/kudu-spark-tools/build.gradle M java/kudu-spark/build.gradle M java/kudu-subprocess/build.gradle M java/kudu-test-utils/build.gradle 21 files changed, 500 insertions(+), 383 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/21030/3 -- To view, visit http://gerrit.cloudera.org:8080/21030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I915dab011aba633d55a79c72ea6f459d703d7f47 Gerrit-Change-Number: 21030 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Chovan Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Java] Fix concurrent problem while traverse the traces of KuduRpc.
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21041 to look at the new patch set (#6). Change subject: [Java] Fix concurrent problem while traverse the traces of KuduRpc. .. [Java] Fix concurrent problem while traverse the traces of KuduRpc. When the RPC request which is sent by java client times out, the RpcTimeoutTask is called by HashedWheelTimeout. During the running of this task, KuduRpc#toString() is called. This method will traverse the traces(a synchronizedList) without any protection, which lead to exception in timeout task and then the callback will not be triggered. So make a copy of the traces and then traverse the copy. This method is mostly called when some exceptions are raised, so the influence on performance should be acceptable. Change-Id: I1a642d93d01ebcfa05b01fe263023b5580d2542b --- M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/21041/6 -- To view, visit http://gerrit.cloudera.org:8080/21041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1a642d93d01ebcfa05b01fe263023b5580d2542b Gerrit-Change-Number: 21041 Gerrit-PatchSet: 6 Gerrit-Owner: Song Jiacheng Gerrit-Reviewer: Kudu Jenkins (120)
