[kudu-CR] [gutil] fix compilation with clang 15
Alexey Serbin has removed a vote on this change. Change subject: [gutil] fix compilation with clang 15 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I3329427c3babd57418c83ab2401b7c4d29e14020 Gerrit-Change-Number: 21206 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [gutil] fix compilation with clang 15
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21206 ) Change subject: [gutil] fix compilation with clang 15 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3329427c3babd57418c83ab2401b7c4d29e14020 Gerrit-Change-Number: 21206 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 30 Mar 2024 03:57:25 + Gerrit-HasComments: No
[kudu-CR] [rpc] fix rare race in GetPendingConnectionsNum
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21224 ) Change subject: [rpc] fix rare race in GetPendingConnectionsNum .. [rpc] fix rare race in GetPendingConnectionsNum A Kudu server might start its shutdown sequence while other thread is collecting the server's metrics. If that happens, a data race might manifest itself while fetching the 'rpc_pending_connections' metric. Running one of the tests under TSAN reproduced such a race with the report below. This patch addresses the data race issue. In addition, I took the liberty of optimizing the instantiation and initialization of DiagnosticSocket instances used to retrieve the information on number of pending RPC connections, so now the diagnostic sockets are instantiated and initialized once per AcceptorPool instance. This is a follow-up to c0c44a8acd8d6366987af687d5665f751249a95a. WARNING: ThreadSanitizer: data race Read of size 8 at 0x7b4c2f78 by thread T63 (mutexes: write M558018781209703984): #0 std::__1::vector, std::__1::allocator > >::begin() thirdparty/installed/tsan/include/c++/v1/vector:1520:30 (libkrpc.so+0x1642b9) #1 kudu::rpc::Messenger::GetPendingConnectionsNum() src/kudu/rpc/messenger.cc:171:22 (libkrpc.so+0x15f6fb) ... #14 kudu::MetricRegistry::WriteAsJson(kudu::JsonWriter*, kudu::MetricJsonOptions const&) const src/kudu/util/metrics.cc:566:7 (libkudu_util.so+0x3ab82c) ... #17 kudu::server::DiagnosticsLog::Start()::$_0::operator()() const src/kudu/server/diagnostics_log.cc:145:46 (libserver_process.so+0x118361) ... Previous write of size 8 at 0x7b4c2f78 by main thread (mutexes: write M4638925457023032): #0 memset sanitizer_common/sanitizer_common_interceptors.inc:780:3 (kudu+0x454d16) #1 memset sanitizer_common/sanitizer_common_interceptors.inc:778:1 (kudu+0x454d16) #2 std::__1::vector, std::__1::allocator > >::__move_assign(std::__1::vector, std::__1::allocator > >&, std::__1::integral_constant) thirdparty/installed/tsan/include/c++/v1/vector:1392:18 (libkrpc.so+0x16a840) ... #4 kudu::rpc::Messenger::ShutdownInternal(kudu::rpc::Messenger::ShutdownMode) src/kudu/rpc/messenger.cc:213:23 (libkrpc.so+0x15f509) ... Change-Id: I6aaf3373944eac86664ac62db3b7e6151c874539 Reviewed-on: http://gerrit.cloudera.org:8080/21224 Tested-by: Alexey Serbin Reviewed-by: Abhishek Chennaka --- M src/kudu/rpc/acceptor_pool.cc M src/kudu/rpc/acceptor_pool.h M src/kudu/rpc/messenger.cc M src/kudu/util/net/diagnostic_socket.cc M src/kudu/util/net/diagnostic_socket.h 5 files changed, 39 insertions(+), 17 deletions(-) Approvals: Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21224 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6aaf3373944eac86664ac62db3b7e6151c874539 Gerrit-Change-Number: 21224 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rpc] fix rare race in GetPendingConnectionsNum
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21224 ) Change subject: [rpc] fix rare race in GetPendingConnectionsNum .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21224 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6aaf3373944eac86664ac62db3b7e6151c874539 Gerrit-Change-Number: 21224 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 29 Mar 2024 18:14:31 + Gerrit-HasComments: No
[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 6: Do you think a performance analysis is required to ensure there is no significant regression? -- To view, visit http://gerrit.cloudera.org:8080/21127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c02dc3b9444599ef680fa9b29ae7a4d39dd382 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Fri, 29 Mar 2024 14:35:57 + Gerrit-HasComments: No
[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/21127/6/src/kudu/tablet/concurrent_btree.h File src/kudu/tablet/concurrent_btree.h: http://gerrit.cloudera.org:8080/#/c/21127/6/src/kudu/tablet/concurrent_btree.h@139 PS6, Line 139: * nit: add space http://gerrit.cloudera.org:8080/#/c/21127/6/src/kudu/tablet/concurrent_btree.h@378 PS6, Line 378: StableVersionAcquire Just for my understanding, what is the difference between StableVersionAcquire and VersionAcquire? -- To view, visit http://gerrit.cloudera.org:8080/21127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c02dc3b9444599ef680fa9b29ae7a4d39dd382 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Fri, 29 Mar 2024 13:47:34 + Gerrit-HasComments: Yes
