[kudu-CR] [tests] fix a misprint
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21229 Change subject: [tests] fix a misprint .. [tests] fix a misprint Tests should use ASSERT_NE(), not DCHECK_NE(). This is a follow-up to e54c80cf9ba129b943eed6af3266899753b1b4ac. Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1 --- M src/kudu/integration-tests/disk_reservation-itest.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/21229/1 -- To view, visit http://gerrit.cloudera.org:8080/21229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1 Gerrit-Change-Number: 21229 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21212 ) Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes .. [rpc] relax settings for MeasureAcceptorDispatchTimes On some nodes, RpcAcceptorBench.MeasureAcceptorDispatchTimes might run out of file descriptors if run with 16 concurrent client threads, failing the test. This patch modifies the default settings for the scenario to run with just a single client thread by default. That's enough to provide good coverage for the related metrics while easing the load on a test node. Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f Reviewed-on: http://gerrit.cloudera.org:8080/21212 Reviewed-by: Mahesh Reddy Reviewed-by: Abhishek Chennaka Tested-by: Alexey Serbin --- M src/kudu/rpc/rpc-bench.cc 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Mahesh Reddy: Looks good to me, but someone else must approve Abhishek Chennaka: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/21212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f Gerrit-Change-Number: 21212 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Alexey Serbin has removed a vote on this change. Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f Gerrit-Change-Number: 21212 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21212 ) Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes .. Patch Set 2: Verified+1 unrelated test failures -- To view, visit http://gerrit.cloudera.org:8080/21212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f Gerrit-Change-Number: 21212 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Comment-Date: Mon, 01 Apr 2024 19:13:13 + Gerrit-HasComments: No
[kudu-CR] [gutil] fix compilation with clang 15
Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/21206 )
Change subject: [gutil] fix compilation with clang 15
..
[gutil] fix compilation with clang 15
std::{binary,unary}_function have been deprecated since C++11 and
removed in C++17 [1], and it seems that CLANG 15 which comes with
Xcode 15.3 on macOS enforces this particular part of the C++17 standard.
In this instance, it's easy to address the issue because nothing
essential was used from std::unary_function and std::binary_function
but just typedefs which are no longer needed by the new standard library
anyway. Since Kudu switched to C++17 a long time ago [2], the solution
is to stop inheriting from the deprecated classes.
[1] https://en.cppreference.com/w/cpp/utility/functional/unary_function
[2]
https://github.com/apache/kudu/commit/e432e637e282ba87d41c02088a801f0838571edc
Change-Id: I3329427c3babd57418c83ab2401b7c4d29e14020
Reviewed-on: http://gerrit.cloudera.org:8080/21206
Tested-by: Alexey Serbin
Reviewed-by: Mahesh Reddy
Reviewed-by: Abhishek Chennaka
---
M src/kudu/gutil/stl_util.h
M src/kudu/gutil/strings/human_readable.h
M src/kudu/gutil/strings/numbers.h
M src/kudu/gutil/strings/util.h
4 files changed, 13 insertions(+), 25 deletions(-)
Approvals:
Alexey Serbin: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3329427c3babd57418c83ab2401b7c4d29e14020
Gerrit-Change-Number: 21206
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Abhishek Chennaka
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy
Gerrit-Reviewer: Marton Greber
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR](branch-1.17.x) KUDU-3562 fix integer overflow in available space metrics
Alexey Serbin has uploaded this change for review. (
http://gerrit.cloudera.org:8080/21228
Change subject: KUDU-3562 fix integer overflow in available space metrics
..
KUDU-3562 fix integer overflow in available space metrics
This patch addresses KUDU-3562. The problem was in implicit casting
of 64-bit integers down to 32-bit ones when introducing a helper
variable in CalculateAvailableSpace(). A new test scenario is added
to cover the fixed issue and catch regressions in future, if any.
In addition, this patch corrects the type of the related metrics in
disk_failure-itest.cc. It also clarifies on the description and tags
of the --fs_{data_dirs,wal_dir}_available_space_cache_seconds flags.
Change-Id: I974aea822626e4648886388c0de3741ac459f2ec
Reviewed-on: http://gerrit.cloudera.org:8080/21227
Reviewed-by: Abhishek Chennaka
Tested-by: Abhishek Chennaka
Reviewed-by: Mahesh Reddy
(cherry picked from commit e54c80cf9ba129b943eed6af3266899753b1b4ac)
---
M src/kudu/fs/data_dirs.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/server/server_base.cc
4 files changed, 108 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/21228/1
--
To view, visit http://gerrit.cloudera.org:8080/21228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I974aea822626e4648886388c0de3741ac459f2ec
Gerrit-Change-Number: 21228
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin
[kudu-CR] KUDU-3562 fix integer overflow in available space metrics
Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/21227 )
Change subject: KUDU-3562 fix integer overflow in available space metrics
..
KUDU-3562 fix integer overflow in available space metrics
This patch addresses KUDU-3562. The problem was in implicit casting
of 64-bit integers down to 32-bit ones when introducing a helper
variable in CalculateAvailableSpace(). A new test scenario is added
to cover the fixed issue and catch regressions in future, if any.
In addition, this patch corrects the type of the related metrics in
disk_failure-itest.cc. It also clarifies on the description and tags
of the --fs_{data_dirs,wal_dir}_available_space_cache_seconds flags.
Change-Id: I974aea822626e4648886388c0de3741ac459f2ec
Reviewed-on: http://gerrit.cloudera.org:8080/21227
Reviewed-by: Abhishek Chennaka
Tested-by: Abhishek Chennaka
Reviewed-by: Mahesh Reddy
---
M src/kudu/fs/data_dirs.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/server/server_base.cc
4 files changed, 109 insertions(+), 14 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved; Verified
Mahesh Reddy: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/21227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I974aea822626e4648886388c0de3741ac459f2ec
Gerrit-Change-Number: 21227
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Abhishek Chennaka
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy
Gerrit-Reviewer: Yingchun Lai
[kudu-CR] KUDU-3562 fix integer overflow in available space metrics
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21227 ) Change subject: KUDU-3562 fix integer overflow in available space metrics .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I974aea822626e4648886388c0de3741ac459f2ec Gerrit-Change-Number: 21227 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 01 Apr 2024 19:05:09 + Gerrit-HasComments: No
[kudu-CR] [gutil] fix compilation with clang 15
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21206 ) Change subject: [gutil] fix compilation with clang 15 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3329427c3babd57418c83ab2401b7c4d29e14020 Gerrit-Change-Number: 21206 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 01 Apr 2024 18:48:28 + Gerrit-HasComments: No
[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21226 ) Change subject: KUDU-3561 skip tablet entities in Prometheus format .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21226/1/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/21226/1/src/kudu/util/metrics.cc@436 PS1, Line 436: metricsa nit: metrics http://gerrit.cloudera.org:8080/#/c/21226/1/src/kudu/util/metrics.cc@442 PS1, Line 442: metricsa nit: metrics -- To view, visit http://gerrit.cloudera.org:8080/21226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 01 Apr 2024 18:41:41 + Gerrit-HasComments: Yes
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Abhishek Chennaka has posted comments on this change. (
http://gerrit.cloudera.org:8080/21212 )
Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes
..
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21212/1/src/kudu/rpc/rpc-bench.cc
File src/kudu/rpc/rpc-bench.cc:
http://gerrit.cloudera.org:8080/#/c/21212/1/src/kudu/rpc/rpc-bench.cc@354
PS1, Line 354: for (auto i = 0; i < threads_num; ++i) {
> As you could see from the commit description, the change in the default set
Ah, okay thanks for the explanation.
--
To view, visit http://gerrit.cloudera.org:8080/21212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f
Gerrit-Change-Number: 21212
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Abhishek Chennaka
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy
Gerrit-Comment-Date: Mon, 01 Apr 2024 18:37:16 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3562 fix integer overflow in available space metrics
Abhishek Chennaka has removed a vote on this change. Change subject: KUDU-3562 fix integer overflow in available space metrics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I974aea822626e4648886388c0de3741ac459f2ec Gerrit-Change-Number: 21227 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai
[kudu-CR] KUDU-3562 fix integer overflow in available space metrics
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21227 ) Change subject: KUDU-3562 fix integer overflow in available space metrics .. Patch Set 2: Verified+1 Code-Review+2 Thanks for fixing this -- To view, visit http://gerrit.cloudera.org:8080/21227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I974aea822626e4648886388c0de3741ac459f2ec Gerrit-Change-Number: 21227 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 01 Apr 2024 18:35:38 + Gerrit-HasComments: No
[kudu-CR] [rpc] relax settings for MeasureAcceptorDispatchTimes
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21212 ) Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f Gerrit-Change-Number: 21212 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Comment-Date: Mon, 01 Apr 2024 18:32:02 + Gerrit-HasComments: No
[kudu-CR] [gutil] fix compilation with clang 15
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21206 ) Change subject: [gutil] fix compilation with clang 15 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3329427c3babd57418c83ab2401b7c4d29e14020 Gerrit-Change-Number: 21206 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 01 Apr 2024 17:50:54 + Gerrit-HasComments: No
[kudu-CR] KUDU-3562 fix integer overflow in available space metrics
Hello Yingchun Lai, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21227
to look at the new patch set (#2).
Change subject: KUDU-3562 fix integer overflow in available space metrics
..
KUDU-3562 fix integer overflow in available space metrics
This patch addresses KUDU-3562. The problem was in implicit casting
of 64-bit integers down to 32-bit ones when introducing a helper
variable in CalculateAvailableSpace(). A new test scenario is added
to cover the fixed issue and catch regressions in future, if any.
In addition, this patch corrects the type of the related metrics in
disk_failure-itest.cc. It also clarifies on the description and tags
of the --fs_{data_dirs,wal_dir}_available_space_cache_seconds flags.
Change-Id: I974aea822626e4648886388c0de3741ac459f2ec
---
M src/kudu/fs/data_dirs.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/server/server_base.cc
4 files changed, 109 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21227/2
--
To view, visit http://gerrit.cloudera.org:8080/21227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I974aea822626e4648886388c0de3741ac459f2ec
Gerrit-Change-Number: 21227
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Abhishek Chennaka
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai
[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3561 skip tablet entities in Prometheus format .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai
[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21226 ) Change subject: KUDU-3561 skip tablet entities in Prometheus format .. Patch Set 1: Verified+1 unrelated test failures -- To view, visit http://gerrit.cloudera.org:8080/21226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 01 Apr 2024 16:50:27 + Gerrit-HasComments: No
[kudu-CR] KUDU-3562 fix integer overflow in available space metrics
Alexey Serbin has uploaded this change for review. (
http://gerrit.cloudera.org:8080/21227
Change subject: KUDU-3562 fix integer overflow in available space metrics
..
KUDU-3562 fix integer overflow in available space metrics
This patch addresses KUDU-3562. The problem was in implicit casting
of 64-bit integers down to 32-bit ones when introducing a helper
variable CalculateAvailableSpace(). A new test scenario is added
to cover the fixed issue and catch regressions in future, if any.
In addition, the patch corrects the type of the related metrics in
disk_failure-itest.cc and clarifies on the description and tags
for the --fs_{data_dirs,wal_dir}_available_space_cache_seconds flags.
Change-Id: I974aea822626e4648886388c0de3741ac459f2ec
---
M src/kudu/fs/data_dirs.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/server/server_base.cc
4 files changed, 109 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/21227/1
--
To view, visit http://gerrit.cloudera.org:8080/21227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I974aea822626e4648886388c0de3741ac459f2ec
Gerrit-Change-Number: 21227
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin
[kudu-CR] [codegen] use std::atomic instead of AtomicInt
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21225 ) Change subject: [codegen] use std::atomic instead of AtomicInt .. [codegen] use std::atomic instead of AtomicInt The chromium-based atomics are deprecated in favor of std::atomic from the STL: this patch switches from AtomicInt to std::atomic for the codegen's compilation manager. I changes the corresponding metrics from int64_t to uint64_t type. This patch doesn't contain any functional modifications. Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92 Reviewed-on: http://gerrit.cloudera.org:8080/21225 Reviewed-by: Yingchun Lai Tested-by: Alexey Serbin --- M src/kudu/codegen/compilation_manager.cc M src/kudu/codegen/compilation_manager.h 2 files changed, 36 insertions(+), 29 deletions(-) Approvals: Yingchun Lai: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/21225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92 Gerrit-Change-Number: 21225 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [codegen] use std::atomic instead of AtomicInt
Alexey Serbin has removed a vote on this change. Change subject: [codegen] use std::atomic instead of AtomicInt .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92 Gerrit-Change-Number: 21225 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [codegen] use std::atomic instead of AtomicInt
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21225 ) Change subject: [codegen] use std::atomic instead of AtomicInt .. Patch Set 2: Verified+1 unrelated test failures -- To view, visit http://gerrit.cloudera.org:8080/21225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92 Gerrit-Change-Number: 21225 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 01 Apr 2024 06:21:31 + Gerrit-HasComments: No
[kudu-CR] KUDU-3561 skip tablet entities in Prometheus format
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21226 Change subject: KUDU-3561 skip tablet entities in Prometheus format .. KUDU-3561 skip tablet entities in Prometheus format Currently, the Prometheus metrics writer outputs only server-level metrics. Prior to this patch, the Prometheus metrics writer would output a warning message for every tablet it encounters while iterating through all the existing metric entities. This patch addresses the issue: the tablet entries are now silently skipped, as they should. I also added a few TODOs to address them in future. Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 --- M src/kudu/util/metrics.cc 1 file changed, 31 insertions(+), 20 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/21226/1 -- To view, visit http://gerrit.cloudera.org:8080/21226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
