[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 10: (1 comment) > (1 comment) > > I realized that, the only proper way to add a 2-way load barrier is > with > std::atomic_thread_fence(std::memory_order_acquire), which is more > strict, than > the 1-way std::atomic::load(std::memory_order_acquire); > > I made some performance test. I used TestScanPerformance from > cbtree-test and > TestMemRowSetUpdatePerformance from memrowset-test. I also added 2 > more > performance tests, one using basic arena, one using > ThreadSafeMemoryTrackingArena (we only use the 2nd in production). > I will add g++ tests too (as soon as it compiles). > See the branches sheet for name resolution. For some reason, I assumed you were going to add those tests into this patch or as a separate patch, but it seems by 'adding > https://docs.google.com/spreadsheets/d/1whl8h7S0DcjVYp0jksR87P9v4U8TQH9nS1C9N0D-lUo/edit?usp=sharing > (1 comment) > > I realized that, the only proper way to add a 2-way load barrier is > with > std::atomic_thread_fence(std::memory_order_acquire), which is more > strict, than > the 1-way std::atomic::load(std::memory_order_acquire); > > I made some performance test. I used TestScanPerformance from > cbtree-test and > TestMemRowSetUpdatePerformance from memrowset-test. I also added 2 > more > performance tests, one using basic arena, one using > ThreadSafeMemoryTrackingArena (we only use the 2nd in production). > I will add g++ tests too (as soon as it compiles). > See the branches sheet for name resolution. For some reason, I assumed you were going to add your new tests as a part of this changelist as well, but it seems you just meant adding results from running those tests into the spreadsheet :) OK, maybe it makes sense to add your new tests into Kudu as well? Feel free to post that as a separate changelist. Also, it would be great if you could address other feedback items (nits, questions of other reviewers, etc.) and post a follow-up revision, if necessary. Thanks! > https://docs.google.com/spreadsheets/d/1whl8h7S0DcjVYp0jksR87P9v4U8TQH9nS1C9N0D-lUo/edit?usp=sharing http://gerrit.cloudera.org:8080/#/c/21127/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21127/6//COMMIT_MSG@33 PS6, Line 33: The following 6 barriers need to be more strict: > See the google sheet. Thanks for posting the numbers. A few questions: * What were the machines that x86_64 and ARM tests were run at? How close they are in terms of processing power (frequency, number of CPU cores)? * Do I understand correctly that both the x86_64 and ARM machines were the same for all the tests, just different binaries were run? * I'm not sure I understand what 'x86_master_clang_2' at the Summary tab is for? How is it different from 'x86_master_clang'? * The numbers posted at the Summary tab: are those seconds of test runtime or that's some completely different (e.g., number scanned/inserted keys), or for different tests they are of different units? * The numbers posted at the Summary tab for the 'TestMemRowSetUpdatePerformance' test: what are those? Are those just total runtime or some particular timing report part (inserting, counting, updating) of the test? Also, could you run existing corresponding Kudu tests (you can run you new tests as well, of course) prior and post your gerrit patch under the 'perf' utility (say, 10 runs) and report the results. No need to put them into a spreadsheet, just present the output from the 'perf stat' utility. You can browse 'git log' and search for the examples how running those tests is usually done. You might also be interested in perf-mem and may be in perf-lock, but reports just from generic 'perf' would be great already. Thanks a lot! https://man7.org/linux/man-pages/man1/perf.1.html -- To view, visit http://gerrit.cloudera.org:8080/21127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c02dc3b9444599ef680fa9b29ae7a4d39dd382 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 10 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Sat, 04 May 2024 03:06:59 + Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [blog] Fix typo in blogpost
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21378 ) Change subject: [blog] Fix typo in blogpost .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Iec743b5151ac9c139d3b3513f99d0369cfe0fc93 Gerrit-Change-Number: 21378 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Comment-Date: Sat, 04 May 2024 01:43:10 + Gerrit-HasComments: No
[kudu-CR] KUDU-3216 fix flakiness in LeadershipChangeOnTskGeneration
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21397 Change subject: KUDU-3216 fix flakiness in LeadershipChangeOnTskGeneration .. KUDU-3216 fix flakiness in LeadershipChangeOnTskGeneration Before this patch, the LeadershipChangeOnTskGeneration scenario from CatalogManagerTskITest would fail once in about 50 runs, DEBUG build. With this patch, the test scenario hasn't had a single failure in about 300 runs, DEBUG build. Change-Id: I139e46627206fc13490ca405bb62dc29934dc4be --- M src/kudu/integration-tests/catalog_manager_tsk-itest.cc 1 file changed, 22 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/21397/1 -- To view, visit http://gerrit.cloudera.org:8080/21397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I139e46627206fc13490ca405bb62dc29934dc4be Gerrit-Change-Number: 21397 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] [tablet] update the severity level of some tablet metrics
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21384 ) Change subject: [tablet] update the severity level of some tablet metrics .. Patch Set 2: Build Started http://jenkins.kudu.apache.org/job/pre_commit/103/ -- To view, visit http://gerrit.cloudera.org:8080/21384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If468eeef8488f4a28bdc23a2fc45073e4a3592d4 Gerrit-Change-Number: 21384 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 04 May 2024 00:41:33 + Gerrit-HasComments: No
[kudu-CR] KUDU-3216 fix flakiness in LeadershipChangeOnTskGeneration
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21397 ) Change subject: KUDU-3216 fix flakiness in LeadershipChangeOnTskGeneration .. Patch Set 1: Build Started http://jenkins.kudu.apache.org/job/pre_commit/102/ -- To view, visit http://gerrit.cloudera.org:8080/21397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I139e46627206fc13490ca405bb62dc29934dc4be Gerrit-Change-Number: 21397 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 04 May 2024 00:40:23 + Gerrit-HasComments: No
[kudu-CR] KUDU-613: Cleanup of cache code
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21018 ) Change subject: KUDU-613: Cleanup of cache code .. Patch Set 9: Verified+1 Build Successful http://jenkins.kudu.apache.org/job/pre_commit/98/ : SUCCESS -- To view, visit http://gerrit.cloudera.org:8080/21018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I506d4577c0ae873b01d7fa4f53846d6fd0f664cf Gerrit-Change-Number: 21018 Gerrit-PatchSet: 9 Gerrit-Owner: Mahesh Reddy Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 03 May 2024 22:26:22 + Gerrit-HasComments: No
[kudu-CR] KUDU-613: Integrate SLRU cache into block cache
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21390 to look at the new patch set (#2). Change subject: KUDU-613: Integrate SLRU cache into block cache .. KUDU-613: Integrate SLRU cache into block cache This patch integrates the new SLRU cache into the block cache. It adds several flags to make the SLRU cache configurable for capacity and lookups as well as adding an eviction_policy flag to give users the option to use the new SLRU cache. The default value is still the old LRU cache. Change-Id: I04411ab2756045f15a272f3397d46d871b087b03 --- M src/kudu/cfile/block_cache.cc M src/kudu/cfile/block_cache.h 2 files changed, 139 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/21390/2 -- To view, visit http://gerrit.cloudera.org:8080/21390 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I04411ab2756045f15a272f3397d46d871b087b03 Gerrit-Change-Number: 21390 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-613: Introduce SLRU cache
Hello Tidy Bot, Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20607 to look at the new patch set (#16). Change subject: KUDU-613: Introduce SLRU cache .. KUDU-613: Introduce SLRU cache This patch introduces the SLRU cache that has two internal segments, the probationary and protected, to protect the cache from long/random reads. The SLRU cache has a parameter named 'lookups_threshold_' that determines the minimum amount of times an entry can be accessed before it's upgraded to the protected segment. Any random scans would then only evict entries from the probationary segment. Both the protected and probationary segment have their own configurable capacities. When the protected segment is at capacity, any entries evicted will be added to the MRU end of the probationary segment. Here are some benchmark numbers for SLRU cache: Test case | Algorithm | Lookups/sec | Hit rate ZIPFIAN ratio=1.00x | LRU | 6.37M | 99.3% ZIPFIAN ratio=1.00x | SLRU | 5.81M | 99.9% ZIPFIAN ratio=3.00x | LRU | 6.15M | 95.9% ZIPFIAN ratio=3.00x | SLRU | 5.49M | 99.0% UNIFORM ratio=1.00x | LRU | 6.76M | 99.7% UNIFORM ratio=1.00x | SLRU | 7.03M | 100.0% UNIFORM ratio=3.00x | LRU | 3.84M | 33.4% UNIFORM ratio=3.00x | SLRU | 3.60M | 36.5% Change-Id: I45531534a2049dd38c002f4dc7982df9fd46e0bb --- M src/kudu/util/CMakeLists.txt M src/kudu/util/cache-bench.cc M src/kudu/util/cache.cc M src/kudu/util/cache.h M src/kudu/util/nvm_cache.cc M src/kudu/util/nvm_cache.h A src/kudu/util/slru_cache-test.cc A src/kudu/util/slru_cache.cc A src/kudu/util/slru_cache.h 9 files changed, 1,569 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/20607/16 -- To view, visit http://gerrit.cloudera.org:8080/20607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I45531534a2049dd38c002f4dc7982df9fd46e0bb Gerrit-Change-Number: 20607 Gerrit-PatchSet: 16 Gerrit-Owner: Mahesh Reddy Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-613: Introduce new BlockCache metrics
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Introduce new BlockCache metrics .. Patch Set 2: Build Started http://jenkins.kudu.apache.org/job/pre_commit/101/ -- To view, visit http://gerrit.cloudera.org:8080/21389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c8181ec6bea301605aaef7db0003c3eaef3072d Gerrit-Change-Number: 21389 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 18:12:26 + Gerrit-HasComments: No
[kudu-CR] KUDU-613: Introduce SLRU cache
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 16: Build Started http://jenkins.kudu.apache.org/job/pre_commit/99/ -- To view, visit http://gerrit.cloudera.org:8080/20607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45531534a2049dd38c002f4dc7982df9fd46e0bb Gerrit-Change-Number: 20607 Gerrit-PatchSet: 16 Gerrit-Owner: Mahesh Reddy Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 03 May 2024 18:12:28 + Gerrit-HasComments: No
[kudu-CR] KUDU-613: Cleanup of cache code
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21018 ) Change subject: KUDU-613: Cleanup of cache code .. Patch Set 9: Build Started http://jenkins.kudu.apache.org/job/pre_commit/98/ -- To view, visit http://gerrit.cloudera.org:8080/21018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I506d4577c0ae873b01d7fa4f53846d6fd0f664cf Gerrit-Change-Number: 21018 Gerrit-PatchSet: 9 Gerrit-Owner: Mahesh Reddy Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 03 May 2024 18:12:27 + Gerrit-HasComments: No
[kudu-CR] KUDU-613: Integrate SLRU cache into block cache
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21390 ) Change subject: KUDU-613: Integrate SLRU cache into block cache .. Patch Set 2: Build Started http://jenkins.kudu.apache.org/job/pre_commit/100/ -- To view, visit http://gerrit.cloudera.org:8080/21390 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04411ab2756045f15a272f3397d46d871b087b03 Gerrit-Change-Number: 21390 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 18:12:27 + Gerrit-HasComments: No
[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21396 ) Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. [g++11] Fix DecrementIntCell for g++10 and g++11 There seems to be a compiler bug, that optimizes out the safety check for INT_MIN in the DecrementIntCell function. It appears on RHEL 9.2 with g++ 11.4.1. Only in Release build. For more infoi, see: https://stackoverflow.com/questions/78424303/g-optimizes-away-check-for-int-min-in-release-build The issue seems to be fixed in g++12 and not yet present in g++9. Solution: Slightly change the function to ensure it is compiled correctly. This modification should not alter the correct optimized code. Basically, any change where the compiler cannot perform the two optimization steps (in this order) should address the issue: + if (x == INT_MIN) x = INT_MAX; else x -= 1; > x -= 1 (this is equivalent on the x86 platform). + if (x - 1 < x) > if (true) (this equivalence holds only at the mathematical level). Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Reviewed-on: http://gerrit.cloudera.org:8080/21396 Tested-by: Alexey Serbin Reviewed-by: Alexey Serbin --- M src/kudu/common/key_util.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Gerrit-Change-Number: 21396 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21396 ) Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Gerrit-Change-Number: 21396 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 18:02:57 + Gerrit-HasComments: No
[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11
Alexey Serbin has removed a vote on this change. Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Gerrit-Change-Number: 21396 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21396 ) Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. Patch Set 3: Verified+1 unrelated test failures: * KUDU-3216 -- To view, visit http://gerrit.cloudera.org:8080/21396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Gerrit-Change-Number: 21396 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 18:01:27 + Gerrit-HasComments: No
[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21396 ) Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. Patch Set 3: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/97/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Gerrit-Change-Number: 21396 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 18:00:06 + Gerrit-HasComments: No
[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21396 ) Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. Patch Set 3: Build Started http://jenkins.kudu.apache.org/job/pre_commit/97/ -- To view, visit http://gerrit.cloudera.org:8080/21396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Gerrit-Change-Number: 21396 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 17:03:11 + Gerrit-HasComments: No
[kudu-CR] KUDU-3568 Fix budgeting constraint test by enabling preset factor
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/21360 )
Change subject: KUDU-3568 Fix budgeting constraint test by enabling preset
factor
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21360/2//COMMIT_MSG
Commit Message:
PS2:
Thank you for the write up -- I must admit I haven't read it yet to digest
everything, but I'm planning to do so when I can allocate more time for this.
The only feedback at this point from my side is that the test is still failing
even with this fix:
src/kudu/tablet/compaction-test.cc:910: Failure
Value of: JoinStrings(sink.logged_msgs(), "\n")
Expected: has substring "removed from compaction input due to memory
constraints"
Actual: "I20240503 09:52:40.236797 953582 compaction-test.cc:904]
CompactRowSetsOp complete. Timing: real 0.872s\tuser 0.844s\tsys 0.028s
Metrics:
{\"bytes_written\":4817,\"cfile_cache_hit\":90,\"cfile_cache_hit_bytes\":4310,\"cfile_cache_miss\":330,\"cfile_cache_miss_bytes\":3794180,\"cfile_init\":41,\"delta_iterators_relevant\":40,\"dirs.queue_time_us\":1303,\"dirs.run_cpu_time_us\":824,\"dirs.run_wall_time_us\":844,\"drs_written\":1,\"lbm_read_time_us\":4281,\"lbm_reads_lt_1ms\":494,\"lbm_write_time_us\":4794,\"lbm_writes_lt_1ms\":132,\"mutex_wait_us\":223,\"num_input_rowsets\":10,\"peak_mem_usage\":2147727,\"rows_written\":20,\"spinlock_wait_cycles\":83584,\"thread_start_us\":418,\"threads_started\":7}"
I20240503 09:52:40.240758 953582 test_util.cc:175]
---
I20240503 09:52:40.240803 953582 test_util.cc:176] Had fatal failures, leaving
test files at
/tmp/kudutest-0/compaction-test.TestCompaction.TestRowSetCompactionSkipWithBudgetingConstraints.1714755106413846-953582-0
--
To view, visit http://gerrit.cloudera.org:8080/21360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9df218cd2d8ef3709793db267d5a0d651421dbb6
Gerrit-Change-Number: 21360
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber
Gerrit-Reviewer: Zoltan Martonka
Gerrit-Comment-Date: Fri, 03 May 2024 16:57:19 +
Gerrit-HasComments: Yes
[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21396 ) Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. Patch Set 2: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/96/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Gerrit-Change-Number: 21396 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 16:11:06 + Gerrit-HasComments: No
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21393 ) Change subject: [tserver] limit number of trace metrics for TabletCopyClient .. [tserver] limit number of trace metrics for TabletCopyClient The trace metrics registry assumes that the number of entries is quite small, with the current threshold of 100. In its turn, a thread pool unconditionally registers and updates its trace metrics while executing submitted tasks. Since a tablet server might host thousands of tablet replicas, it's not a good idea to include the UUID of the tablet into the name of the download thread pool spawned by every TabletCopyClient instance. This is a follow-up to 0d95304fa46ee5d96bcaa934c7660369f2860e06. Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec Reviewed-on: http://gerrit.cloudera.org:8080/21393 Tested-by: Marton Greber Reviewed-by: Marton Greber --- M src/kudu/tserver/tablet_copy_client.cc 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Marton Greber: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec Gerrit-Change-Number: 21393 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21396 to look at the new patch set (#2). Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. [g++11] Fix DecrementIntCell for g++10 and g++11 There seems to be a compiler bug, that optimizes out the safety check for INT_MIN in the DecrementIntCell function. It appears on RHEL 9.2 with g++ 11.4.1. Only in Release build. For more infoi, see: https://stackoverflow.com/questions/78424303/g-optimizes-away-check-for-int-min-in-release-build The issue seems to be fixed in g++12 and not yet present in g++9. Solution: Slightly change the function to ensure it is compiled correctly. This modification should not alter the correct optimized code. Basically, any change where the compiler cannot perform the two optimization steps (in this order) should address the issue: + if (x == INT_MIN) x = INT_MAX; else x -= 1; > x -= 1 (this is equivalent on the x86 platform). + if (x - 1 < x) > if (true) (this equivalence holds only at the mathematical level). Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 --- M src/kudu/common/key_util.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/21396/2 -- To view, visit http://gerrit.cloudera.org:8080/21396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Gerrit-Change-Number: 21396 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21396 ) Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. Patch Set 2: Build Started http://jenkins.kudu.apache.org/job/pre_commit/96/ -- To view, visit http://gerrit.cloudera.org:8080/21396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Gerrit-Change-Number: 21396 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 14:51:31 + Gerrit-HasComments: No
[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21396 ) Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. Patch Set 1: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/95/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Gerrit-Change-Number: 21396 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 13:31:35 + Gerrit-HasComments: No
[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21396 Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. [g++11] Fix DecrementIntCell for g++10 and g++11 There seems to be a compiler bug, that optimizes out the safety check for INT_MIN in the DecrementIntCell function. It appears on RHEL 9.2 with g++ 11.4.1. Only in Release build. For more infoi, see: https://stackoverflow.com/questions/78424303/g-optimizes-away-check-for-int-min-in-release-build The issue seems to be fixed in g++12 and not yet present in g++9. Solution: Slightly change the function to ensure it is compiled correctly. This modification should not alter the correct optimized code. Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 --- M src/kudu/common/key_util.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/21396/1 -- To view, visit http://gerrit.cloudera.org:8080/21396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Gerrit-Change-Number: 21396 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Martonka
[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21396 ) Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. Patch Set 1: Build Started http://jenkins.kudu.apache.org/job/pre_commit/95/ -- To view, visit http://gerrit.cloudera.org:8080/21396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3cea2849a88c4d7e2587ceb805cd3258652e3c5 Gerrit-Change-Number: 21396 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 12:15:35 + Gerrit-HasComments: No
[kudu-CR] [CmakeLists.txt] Fix typo
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21395 ) Change subject: [CmakeLists.txt] Fix typo .. Patch Set 1: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/94/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e8da8f49b201daf99c27cc1fc3793f511e81e6c Gerrit-Change-Number: 21395 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 11:06:24 + Gerrit-HasComments: No
[kudu-CR] [CmakeLists.txt] Fix typo
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21395 ) Change subject: [CmakeLists.txt] Fix typo .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e8da8f49b201daf99c27cc1fc3793f511e81e6c Gerrit-Change-Number: 21395 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 10:13:28 + Gerrit-HasComments: No
[kudu-CR] [CmakeLists.txt] Fix typo
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21395 ) Change subject: [CmakeLists.txt] Fix typo .. Patch Set 1: Build Started http://jenkins.kudu.apache.org/job/pre_commit/94/ -- To view, visit http://gerrit.cloudera.org:8080/21395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e8da8f49b201daf99c27cc1fc3793f511e81e6c Gerrit-Change-Number: 21395 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 03 May 2024 10:08:00 + Gerrit-HasComments: No
[kudu-CR] [CmakeLists.txt] Fix typo
Ádám Bakai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21395 Change subject: [CmakeLists.txt] Fix typo .. [CmakeLists.txt] Fix typo Change-Id: I5e8da8f49b201daf99c27cc1fc3793f511e81e6c --- M CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/21395/1 -- To view, visit http://gerrit.cloudera.org:8080/21395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5e8da8f49b201daf99c27cc1fc3793f511e81e6c Gerrit-Change-Number: 21395 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21393 ) Change subject: [tserver] limit number of trace metrics for TabletCopyClient .. Patch Set 1: Code-Review+2 LGTM. nit: http://jenkins.kudu.apache.org/job/build_and_test/523/console -> "All tests passed, yet some left behind their test output." hmm never seen this before, although it is related to webserver-crawl-itest -- To view, visit http://gerrit.cloudera.org:8080/21393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec Gerrit-Change-Number: 21393 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Fri, 03 May 2024 08:57:24 + Gerrit-HasComments: No
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Marton Greber has removed a vote on this change. Change subject: [tserver] limit number of trace metrics for TabletCopyClient .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec Gerrit-Change-Number: 21393 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber
[kudu-CR] [tserver] limit number of trace metrics for TabletCopyClient
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21393 ) Change subject: [tserver] limit number of trace metrics for TabletCopyClient .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I334aa81aaed2378e7cae558bd8bb9e0f0c970fec Gerrit-Change-Number: 21393 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Fri, 03 May 2024 08:56:34 + Gerrit-HasComments: No
