[kudu-CR](branch-1.15.x) [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17511 ) Change subject: [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls .. [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls Prior to this patch, the TestRecoverFromOpIdOverflow scenario of the TsRecoveryITestDeathTest hasn't actually run for TSAN builds, but always reported success. A proper way of dealing with such conditions is to either skip a scenario or don't compile it at all as we do for others: * TestCFileBothCacheMemoryTypes.TestReadWriteLargeStrings * ThreadPoolTest.TestDeadlocks * DebugUtilTest.TestUnwindWhileUnsafe Change-Id: Id4ff9cd8943c780d4fe8bf6afb2ef540c07a5c8d Reviewed-on: http://gerrit.cloudera.org:8080/17491 Tested-by: Alexey Serbin Reviewed-by: Andrew Wong (cherry picked from commit 725c8b728a4c9fd582114aa529d7f8fba186bc9d) Reviewed-on: http://gerrit.cloudera.org:8080/17511 Tested-by: Grant Henke Reviewed-by: Bankim Bhavsar Reviewed-by: Alexey Serbin --- M src/kudu/integration-tests/ts_recovery-itest.cc 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Grant Henke: Verified Bankim Bhavsar: Looks good to me, approved Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: merged Gerrit-Change-Id: Id4ff9cd8943c780d4fe8bf6afb2ef540c07a5c8d Gerrit-Change-Number: 17511 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17511 ) Change subject: [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: comment Gerrit-Change-Id: Id4ff9cd8943c780d4fe8bf6afb2ef540c07a5c8d Gerrit-Change-Number: 17511 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 May 2021 16:51:49 + Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17511 ) Change subject: [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: comment Gerrit-Change-Id: Id4ff9cd8943c780d4fe8bf6afb2ef540c07a5c8d Gerrit-Change-Number: 17511 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 May 2021 16:46:10 + Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17511 ) Change subject: [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls .. Patch Set 1: The failure is unrelated to this change. -- To view, visit http://gerrit.cloudera.org:8080/17511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: comment Gerrit-Change-Id: Id4ff9cd8943c780d4fe8bf6afb2ef540c07a5c8d Gerrit-Change-Number: 17511 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 May 2021 16:23:59 + Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17511 ) Change subject: [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: comment Gerrit-Change-Id: Id4ff9cd8943c780d4fe8bf6afb2ef540c07a5c8d Gerrit-Change-Number: 17511 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 May 2021 16:23:45 + Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls
Grant Henke has removed a vote on this change. Change subject: [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: deleteVote Gerrit-Change-Id: Id4ff9cd8943c780d4fe8bf6afb2ef540c07a5c8d Gerrit-Change-Number: 17511 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17511 ) Change subject: [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls .. Patch Set 1: > Patch Set 1: Verified-1 > > Build Failed > > http://jenkins.kudu.apache.org/job/kudu-gerrit/23936/ : FAILURE The java test failures look unrelated but worth checking. -- To view, visit http://gerrit.cloudera.org:8080/17511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: comment Gerrit-Change-Id: Id4ff9cd8943c780d4fe8bf6afb2ef540c07a5c8d Gerrit-Change-Number: 17511 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 May 2021 16:09:27 + Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17511 Change subject: [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls .. [tests] TsRecoveryITestDeathTest isn't for for TSAN buidls Prior to this patch, the TestRecoverFromOpIdOverflow scenario of the TsRecoveryITestDeathTest hasn't actually run for TSAN builds, but always reported success. A proper way of dealing with such conditions is to either skip a scenario or don't compile it at all as we do for others: * TestCFileBothCacheMemoryTypes.TestReadWriteLargeStrings * ThreadPoolTest.TestDeadlocks * DebugUtilTest.TestUnwindWhileUnsafe Change-Id: Id4ff9cd8943c780d4fe8bf6afb2ef540c07a5c8d Reviewed-on: http://gerrit.cloudera.org:8080/17491 Tested-by: Alexey Serbin Reviewed-by: Andrew Wong (cherry picked from commit 725c8b728a4c9fd582114aa529d7f8fba186bc9d) --- M src/kudu/integration-tests/ts_recovery-itest.cc 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/17511/1 -- To view, visit http://gerrit.cloudera.org:8080/17511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: newchange Gerrit-Change-Id: Id4ff9cd8943c780d4fe8bf6afb2ef540c07a5c8d Gerrit-Change-Number: 17511 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
