[kudu-CR](branch-1.15.x) KUDU-2612: disable TxnSystemClient initialization by default
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17506 ) Change subject: KUDU-2612: disable TxnSystemClient initialization by default .. KUDU-2612: disable TxnSystemClient initialization by default Currently the TxnSystemClient gets initialized on tablet servers by default, retrying every second until successful, and logging an error every minute if unable to. Since transactions support is currently experimental and disabled by default, so too should this initialization be. This patch hides the initialization with the existing --disable_txn_system_client_init flag (previously used for tests), adjusted to --enable_txn_system_client_init to match most of our feature-gating flags. Change-Id: I7c020a66db484f88ae1cb7c15d860d503a3f8a3b Reviewed-on: http://gerrit.cloudera.org:8080/17499 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin Reviewed-by: Grant Henke (cherry picked from commit 923245291fade95febc36265cfba8cc92ee457d5) Reviewed-on: http://gerrit.cloudera.org:8080/17506 Reviewed-by: Bankim Bhavsar --- M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java M src/kudu/client/client-test.cc M src/kudu/integration-tests/client-negotiation-failover-itest.cc M src/kudu/integration-tests/location_assignment-itest.cc M src/kudu/integration-tests/security-itest.cc M src/kudu/integration-tests/ts_tablet_manager-itest.cc M src/kudu/integration-tests/txn_commit-itest.cc M src/kudu/integration-tests/txn_status_manager-itest.cc M src/kudu/integration-tests/txn_status_table-itest.cc M src/kudu/integration-tests/txn_write_ops-itest.cc M src/kudu/tools/kudu-txn-cli-test.cc M src/kudu/transactions/txn_status_manager-test.cc M src/kudu/transactions/txn_system_client.cc M src/kudu/tserver/tablet_service.cc 14 files changed, 144 insertions(+), 32 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved Bankim Bhavsar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: merged Gerrit-Change-Id: I7c020a66db484f88ae1cb7c15d860d503a3f8a3b Gerrit-Change-Number: 17506 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) KUDU-2612: disable TxnSystemClient initialization by default
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17506 ) Change subject: KUDU-2612: disable TxnSystemClient initialization by default .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: comment Gerrit-Change-Id: I7c020a66db484f88ae1cb7c15d860d503a3f8a3b Gerrit-Change-Number: 17506 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 25 May 2021 19:41:17 + Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) KUDU-2612: disable TxnSystemClient initialization by default
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17506 ) Change subject: KUDU-2612: disable TxnSystemClient initialization by default .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: comment Gerrit-Change-Id: I7c020a66db484f88ae1cb7c15d860d503a3f8a3b Gerrit-Change-Number: 17506 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 25 May 2021 18:47:18 + Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) KUDU-2612: disable TxnSystemClient initialization by default
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17506 Change subject: KUDU-2612: disable TxnSystemClient initialization by default .. KUDU-2612: disable TxnSystemClient initialization by default Currently the TxnSystemClient gets initialized on tablet servers by default, retrying every second until successful, and logging an error every minute if unable to. Since transactions support is currently experimental and disabled by default, so too should this initialization be. This patch hides the initialization with the existing --disable_txn_system_client_init flag (previously used for tests), adjusted to --enable_txn_system_client_init to match most of our feature-gating flags. Change-Id: I7c020a66db484f88ae1cb7c15d860d503a3f8a3b Reviewed-on: http://gerrit.cloudera.org:8080/17499 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin Reviewed-by: Grant Henke (cherry picked from commit 923245291fade95febc36265cfba8cc92ee457d5) --- M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java M src/kudu/client/client-test.cc M src/kudu/integration-tests/client-negotiation-failover-itest.cc M src/kudu/integration-tests/location_assignment-itest.cc M src/kudu/integration-tests/security-itest.cc M src/kudu/integration-tests/ts_tablet_manager-itest.cc M src/kudu/integration-tests/txn_commit-itest.cc M src/kudu/integration-tests/txn_status_manager-itest.cc M src/kudu/integration-tests/txn_status_table-itest.cc M src/kudu/integration-tests/txn_write_ops-itest.cc M src/kudu/tools/kudu-txn-cli-test.cc M src/kudu/transactions/txn_status_manager-test.cc M src/kudu/transactions/txn_system_client.cc M src/kudu/tserver/tablet_service.cc 14 files changed, 144 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/17506/1 -- To view, visit http://gerrit.cloudera.org:8080/17506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: newchange Gerrit-Change-Id: I7c020a66db484f88ae1cb7c15d860d503a3f8a3b Gerrit-Change-Number: 17506 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong