[kudu-CR](branch-1.17.x) [compile] fix a compile warning

[Yingchun Lai (Code Review)]

Yingchun Lai has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/20290 )

Change subject: [compile] fix a compile warning
..

[compile] fix a compile warning

I noticed that there is a warning during the compile process:
`
/data/github-kudu/kudu/src/kudu/client/client-test.cc: In member function 
‘virtual void 
kudu::client::ClientTestImmutableColumn_TestUpsert_Test::TestBody()’:
/data/github-kudu/kudu/src/kudu/client/client-test.cc:9562:90: warning: 
‘iftmp.3716’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   update_immu_col_to_null_ ? nullopt : 
optional(999));
`

Although it does not involve functional defects, it
still needs to be fixed.

As it does not involve any logic changes, no new unit tests
have been added.

Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692
Reviewed-on: http://gerrit.cloudera.org:8080/20183
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
(cherry picked from commit 7f9b3e3e29d951c35d4c28fe9f90b9f7cabe873f)
Reviewed-on: http://gerrit.cloudera.org:8080/20290
Reviewed-by: Yingchun Lai 
Tested-by: Yingchun Lai 
---
M src/kudu/client/client-test.cc
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Yingchun Lai: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/20290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692
Gerrit-Change-Number: 20290
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 

[kudu-CR](branch-1.17.x) [compile] fix a compile warning

[Yingchun Lai (Code Review)]

Yingchun Lai has removed a vote on this change.

Change subject: [compile] fix a compile warning
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692
Gerrit-Change-Number: 20290
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 

[kudu-CR](branch-1.17.x) [compile] fix a compile warning

[Yingchun Lai (Code Review)]

Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20290 )

Change subject: [compile] fix a compile warning
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/20290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692
Gerrit-Change-Number: 20290
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Comment-Date: Tue, 01 Aug 2023 11:19:09 +
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [compile] fix a compile warning

[Yingchun Lai (Code Review)]

Hello Alexey Serbin, Kudu Jenkins,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/20290

to review the following change.


Change subject: [compile] fix a compile warning
..

[compile] fix a compile warning

I noticed that there is a warning during the compile process:
`
/data/github-kudu/kudu/src/kudu/client/client-test.cc: In member function 
‘virtual void 
kudu::client::ClientTestImmutableColumn_TestUpsert_Test::TestBody()’:
/data/github-kudu/kudu/src/kudu/client/client-test.cc:9562:90: warning: 
‘iftmp.3716’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   update_immu_col_to_null_ ? nullopt : 
optional(999));
`

Although it does not involve functional defects, it
still needs to be fixed.

As it does not involve any logic changes, no new unit tests
have been added.

Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692
Reviewed-on: http://gerrit.cloudera.org:8080/20183
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
(cherry picked from commit 7f9b3e3e29d951c35d4c28fe9f90b9f7cabe873f)
---
M src/kudu/client/client-test.cc
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/20290/1
--
To view, visit http://gerrit.cloudera.org:8080/20290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692
Gerrit-Change-Number: 20290
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.17.x) [compile] fix a compile warning

[Yingchun Lai (Code Review)]

Yingchun Lai has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/20222 )

Change subject: [compile] fix a compile warning
..

[compile] fix a compile warning

I noticed that there is a warning during the compile
process:
`
/data/github-kudu/kudu/src/kudu/integration-tests/auto_incrementing-itest.cc: 
In member function ‘virtual void 
kudu::itest::AutoIncrementingItest_BootstrapWalsDiverge_Test::TestBody()’:
/data/github-kudu/kudu/src/kudu/integration-tests/auto_incrementing-itest.cc:530:7:
 warning: operation on ‘j’ may be undefined [-Wsequence-point]
 j = ++j % kNumTabletServers;
 ~~^
`
Although it does not involve functional defects, it
still needs to be fixed.

As it does not involve any logic changes, no new unit
tests have been added.

Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08
Reviewed-on: http://gerrit.cloudera.org:8080/20182
Reviewed-by: Alexey Serbin 
Tested-by: Alexey Serbin 
(cherry picked from commit 35aa458d7a5f67caf0ef4111408885fa5ba0b532)
Reviewed-on: http://gerrit.cloudera.org:8080/20222
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/auto_incrementing-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/20222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08
Gerrit-Change-Number: 20222
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 

[kudu-CR](branch-1.17.x) [compile] fix a compile warning

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20222 )

Change subject: [compile] fix a compile warning
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/20222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08
Gerrit-Change-Number: 20222
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 19 Jul 2023 05:51:36 +
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [compile] fix a compile warning

[Yingchun Lai (Code Review)]

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/20222

to review the following change.


Change subject: [compile] fix a compile warning
..

[compile] fix a compile warning

I noticed that there is a warning during the compile
process:
`
/data/github-kudu/kudu/src/kudu/integration-tests/auto_incrementing-itest.cc: 
In member function ‘virtual void 
kudu::itest::AutoIncrementingItest_BootstrapWalsDiverge_Test::TestBody()’:
/data/github-kudu/kudu/src/kudu/integration-tests/auto_incrementing-itest.cc:530:7:
 warning: operation on ‘j’ may be undefined [-Wsequence-point]
 j = ++j % kNumTabletServers;
 ~~^
`
Although it does not involve functional defects, it
still needs to be fixed.

As it does not involve any logic changes, no new unit
tests have been added.

Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08
Reviewed-on: http://gerrit.cloudera.org:8080/20182
Reviewed-by: Alexey Serbin 
Tested-by: Alexey Serbin 
(cherry picked from commit 35aa458d7a5f67caf0ef4111408885fa5ba0b532)
---
M src/kudu/integration-tests/auto_incrementing-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/20222/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08
Gerrit-Change-Number: 20222
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: KeDeng