[kudu-CR](branch-1.17.x) KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21365 ) Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305 Gerrit-Change-Number: 21365 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Comment-Date: Thu, 02 May 2024 20:59:01 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: deleteVote Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305 Gerrit-Change-Number: 21365 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
[kudu-CR](branch-1.17.x) KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21365 ) Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp .. KUDU-3570 fix use-after-free in MajorDeltaCompactionOp This patch addresses heap-use-after-free and data race issues reported in KUDU-3570. With this and one prior patch, neither TSAN nor ASAN reports any warnings when running alter_table-randomized-test, at least that's the stats collected from more than 100 iterations. Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305 Reviewed-on: http://gerrit.cloudera.org:8080/21362 Tested-by: Alexey Serbin Reviewed-by: Abhishek Chennaka (cherry picked from commit 3912a97cd8998ef04c4e6f9c38bd365c582e8171) Reviewed-on: http://gerrit.cloudera.org:8080/21365 Reviewed-by: Wang Xixu <1450306...@qq.com> --- M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h 2 files changed, 15 insertions(+), 10 deletions(-) Approvals: Wang Xixu: Looks good to me, but someone else must approve Abhishek Chennaka: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/21365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305 Gerrit-Change-Number: 21365 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
[kudu-CR](branch-1.17.x) KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21365 ) Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305 Gerrit-Change-Number: 21365 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Comment-Date: Tue, 30 Apr 2024 23:34:00 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21365 ) Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305 Gerrit-Change-Number: 21365 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Comment-Date: Sun, 28 Apr 2024 03:52:33 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21365 ) Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp .. Patch Set 1: Verified-1 Build Failed http://jenkins.kudu.apache.org/job/pre_commit/51/ : FAILURE -- To view, visit http://gerrit.cloudera.org:8080/21365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305 Gerrit-Change-Number: 21365 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 27 Apr 2024 15:50:05 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21365 ) Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp .. Patch Set 1: Build Started http://jenkins.kudu.apache.org/job/pre_commit/51/ -- To view, visit http://gerrit.cloudera.org:8080/21365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305 Gerrit-Change-Number: 21365 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 27 Apr 2024 14:47:49 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21365 Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp .. KUDU-3570 fix use-after-free in MajorDeltaCompactionOp This patch addresses heap-use-after-free and data race issues reported in KUDU-3570. With this and one prior patch, neither TSAN nor ASAN reports any warnings when running alter_table-randomized-test, at least that's the stats collected from more than 100 iterations. Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305 Reviewed-on: http://gerrit.cloudera.org:8080/21362 Tested-by: Alexey Serbin Reviewed-by: Abhishek Chennaka (cherry picked from commit 3912a97cd8998ef04c4e6f9c38bd365c582e8171) --- M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h 2 files changed, 15 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/21365/1 -- To view, visit http://gerrit.cloudera.org:8080/21365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: newchange Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305 Gerrit-Change-Number: 21365 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
