[kudu-CR](branch-1.4.x) [tools] Use PrintTable to format ksck's consensus matrix
Will Berkeley has submitted this change and it was merged. Change subject: [tools] Use PrintTable to format ksck's consensus matrix .. [tools] Use PrintTable to format ksck's consensus matrix The first version of ksck's consensus matrix used its own table code, but actually there was already nice table code available in tool_action_common.h. This switches ksck to use it. It also generalizes the table code to output to a generic ostream instead of only cout; this was necessary for ksck-test but might be useful in other ways later. Change-Id: I8d77005f20091e6778702580e3a269d9689c5b0a Reviewed-on: http://gerrit.cloudera.org:8080/7043 Tested-by: Kudu Jenkins Reviewed-by: Dan BurkertReviewed-by: Mike Percy (cherry picked from commit 30682fd13ffc68ebaeb8200e7450f8317b89bf85) Reviewed-on: http://gerrit.cloudera.org:8080/7086 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_master.cc M src/kudu/tools/tool_action_tserver.cc 6 files changed, 107 insertions(+), 140 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d77005f20091e6778702580e3a269d9689c5b0a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-1.4.x Gerrit-Owner: Will Berkeley Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley
[kudu-CR](branch-1.4.x) [tools] Use PrintTable to format ksck's consensus matrix
Dan Burkert has posted comments on this change. Change subject: [tools] Use PrintTable to format ksck's consensus matrix .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d77005f20091e6778702580e3a269d9689c5b0a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-1.4.x Gerrit-Owner: Will BerkeleyGerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](branch-1.4.x) [tools] Use PrintTable to format ksck's consensus matrix
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7086 Change subject: [tools] Use PrintTable to format ksck's consensus matrix .. [tools] Use PrintTable to format ksck's consensus matrix The first version of ksck's consensus matrix used its own table code, but actually there was already nice table code available in tool_action_common.h. This switches ksck to use it. It also generalizes the table code to output to a generic ostream instead of only cout; this was necessary for ksck-test but might be useful in other ways later. Change-Id: I8d77005f20091e6778702580e3a269d9689c5b0a Reviewed-on: http://gerrit.cloudera.org:8080/7043 Tested-by: Kudu Jenkins Reviewed-by: Dan BurkertReviewed-by: Mike Percy (cherry picked from commit 30682fd13ffc68ebaeb8200e7450f8317b89bf85) --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_master.cc M src/kudu/tools/tool_action_tserver.cc 6 files changed, 107 insertions(+), 140 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/7086/1 -- To view, visit http://gerrit.cloudera.org:8080/7086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8d77005f20091e6778702580e3a269d9689c5b0a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-1.4.x Gerrit-Owner: Will Berkeley