[kudu-CR](branch-1.5.x) KUDU-2113 Segfault because of consensus conflict and missing tablet server

2018-04-16 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10073 )

Change subject: KUDU-2113 Segfault because of consensus conflict and missing 
tablet server
..

KUDU-2113 Segfault because of consensus conflict and missing tablet server

Sometimes the master doesn't report all tablet servers. This can
happen, for example, when the master is starting. When this
happened and there was also a consensus conflict, it caused a
segfault. This fixes the segfault and contains a regression
test.

Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0
Reviewed-on: http://gerrit.cloudera.org:8080/7864
Reviewed-by: Adar Dembo 
Tested-by: Will Berkeley 
(cherry picked from commit b54eab1f31dd2180e103f1cddbaa2194396396c5)
Reviewed-on: http://gerrit.cloudera.org:8080/10073
Reviewed-by: Will Berkeley 
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
3 files changed, 48 insertions(+), 15 deletions(-)

Approvals:
  Will Berkeley: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/10073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: merged
Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0
Gerrit-Change-Number: 10073
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 


[kudu-CR](branch-1.5.x) KUDU-2113 Segfault because of consensus conflict and missing tablet server

2018-04-15 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change.

Change subject: KUDU-2113 Segfault because of consensus conflict and missing 
tablet server
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0
Gerrit-Change-Number: 10073
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR](branch-1.5.x) KUDU-2113 Segfault because of consensus conflict and missing tablet server

2018-04-15 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10073 )

Change subject: KUDU-2113 Segfault because of consensus conflict and missing 
tablet server
..


Patch Set 1: Verified+1 Code-Review+2

Unrelated failures.


--
To view, visit http://gerrit.cloudera.org:8080/10073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0
Gerrit-Change-Number: 10073
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Mon, 16 Apr 2018 05:52:25 +
Gerrit-HasComments: No


[kudu-CR](branch-1.5.x) KUDU-2113 Segfault because of consensus conflict and missing tablet server

2018-04-15 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10073


Change subject: KUDU-2113 Segfault because of consensus conflict and missing 
tablet server
..

KUDU-2113 Segfault because of consensus conflict and missing tablet server

Sometimes the master doesn't report all tablet servers. This can
happen, for example, when the master is starting. When this
happened and there was also a consensus conflict, it caused a
segfault. This fixes the segfault and contains a regression
test.

Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0
Reviewed-on: http://gerrit.cloudera.org:8080/7864
Reviewed-by: Adar Dembo 
Tested-by: Will Berkeley 
(cherry picked from commit b54eab1f31dd2180e103f1cddbaa2194396396c5)
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
3 files changed, 48 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/10073/1
--
To view, visit http://gerrit.cloudera.org:8080/10073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: If80dbe687e70bd21de9dba9e81d71d66a5bd75e0
Gerrit-Change-Number: 10073
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley