[kudu-CR](branch-1.7.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10188 )

Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
Gerrit-Change-Number: 10188
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 25 Apr 2018 20:09:20 +
Gerrit-HasComments: No

[kudu-CR](branch-1.7.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

[Grant Henke (Code Review)]

Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10188 )

Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test
..

KUDU-2416: Fix PartialRow.setMin and add a unit test

* Fixes a missing break after the decimal type that could
   lead to IllegalArgumentExceptions.
* Fixes INTEGER.MIN_VALUE being used for LONG colums
  that could lead to incorrect partition prunning.
* Adds a unit test for all types.

Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
Reviewed-on: http://gerrit.cloudera.org:8080/10188
Reviewed-by: Dan Burkert 
Tested-by: Grant Henke 
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
2 files changed, 22 insertions(+), 1 deletion(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Grant Henke: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
Gerrit-Change-Number: 10188
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR](branch-1.7.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10188 )

Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
Gerrit-Change-Number: 10188
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 25 Apr 2018 19:47:35 +
Gerrit-HasComments: No

[kudu-CR](branch-1.7.x) KUDU-2416: Fix PartialRow.setMin and add a unit test

[Grant Henke (Code Review)]

Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10188


Change subject: KUDU-2416: Fix PartialRow.setMin and add a unit test
..

KUDU-2416: Fix PartialRow.setMin and add a unit test

* Fixes a missing break after the decimal type that could
   lead to IllegalArgumentExceptions.
* Fixes INTEGER.MIN_VALUE being used for LONG colums
  that could lead to incorrect partition prunning.
* Adds a unit test for all types.

Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
2 files changed, 22 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/10188/1
--
To view, visit http://gerrit.cloudera.org:8080/10188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I510743385cc567a8443efc8b0c9f5b641cf04c31
Gerrit-Change-Number: 10188
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke