[kudu-CR] [Java] Add Yetus doclet to Gradle build

2018-04-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10059 )

Change subject: [Java] Add Yetus doclet to Gradle build
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I283a3ccb8003356c875c603c9169d68a66b45804
Gerrit-Change-Number: 10059
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 13 Apr 2018 17:39:47 +
Gerrit-HasComments: No


[kudu-CR] [Java] Add Yetus doclet to Gradle build

2018-04-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10059 )

Change subject: [Java] Add Yetus doclet to Gradle build
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10059/1/java/gradle/compile.gradle
File java/gradle/compile.gradle:

http://gerrit.cloudera.org:8080/#/c/10059/1/java/gradle/compile.gradle@a28
PS1, Line 28:
> Is this implicitly defined in Yetus already?
Well Yetus does this weird thing where it filters out doclint warnings. That's 
why we didn't need this in the Maven build.

I opened YETUS-626 to track that when removing this.


http://gerrit.cloudera.org:8080/#/c/10059/1/java/gradle/docs.gradle
File java/gradle/docs.gradle:

http://gerrit.cloudera.org:8080/#/c/10059/1/java/gradle/docs.gradle@34
PS1, Line 34: 7
> Should this be 8?
We still support Java 7 so I link to that.



--
To view, visit http://gerrit.cloudera.org:8080/10059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I283a3ccb8003356c875c603c9169d68a66b45804
Gerrit-Change-Number: 10059
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 13 Apr 2018 17:34:40 +
Gerrit-HasComments: Yes


[kudu-CR] [Java] Add Yetus doclet to Gradle build

2018-04-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10059 )

Change subject: [Java] Add Yetus doclet to Gradle build
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10059/1/java/gradle/compile.gradle
File java/gradle/compile.gradle:

http://gerrit.cloudera.org:8080/#/c/10059/1/java/gradle/compile.gradle@a28
PS1, Line 28:
Is this implicitly defined in Yetus already?


http://gerrit.cloudera.org:8080/#/c/10059/1/java/gradle/docs.gradle
File java/gradle/docs.gradle:

http://gerrit.cloudera.org:8080/#/c/10059/1/java/gradle/docs.gradle@34
PS1, Line 34: 7
Should this be 8?



--
To view, visit http://gerrit.cloudera.org:8080/10059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I283a3ccb8003356c875c603c9169d68a66b45804
Gerrit-Change-Number: 10059
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 13 Apr 2018 17:31:31 +
Gerrit-HasComments: Yes


[kudu-CR] [Java] Add Yetus doclet to Gradle build

2018-04-13 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10059


Change subject: [Java] Add Yetus doclet to Gradle build
..

[Java] Add Yetus doclet to Gradle build

- Adds the yetus doclet to the gradle build
- Adds missing interface annotations
- Fixes a couple leaked SLF4J Loggers that are
  also documented.

Change-Id: I283a3ccb8003356c875c603c9169d68a66b45804
---
M java/build.gradle
M java/gradle/compile.gradle
A java/gradle/docs.gradle
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DecimalUtil.java
M java/kudu-hive/build.gradle
9 files changed, 72 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/10059/1
--
To view, visit http://gerrit.cloudera.org:8080/10059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I283a3ccb8003356c875c603c9169d68a66b45804
Gerrit-Change-Number: 10059
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke