[kudu-CR] [KUDU-2214] Voting while tablet copying says "voting while tombstoned"

2018-04-10 Thread Will Berkeley (Code Review) 
Will Berkeley has abandoned this change. ( http://gerrit.cloudera.org:8080/8666 
)

Change subject: [KUDU-2214] Voting while tablet copying says "voting while 
tombstoned"
..


Abandoned

I never finished this, and I think Fengling is working on it now.
--
To view, visit http://gerrit.cloudera.org:8080/8666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id604bc6122c4291a27fe4c8543408b5be382742c
Gerrit-Change-Number: 8666
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley

[kudu-CR] [KUDU-2214] Voting while tablet copying says "voting while tombstoned"

2017-11-30 Thread Mike Percy (Code Review) 
Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8666 )

Change subject: [KUDU-2214] Voting while tablet copying says "voting while 
tombstoned"
..


Patch Set 1:

> OK. But looking at test logs more, it doesn't actually distinguish between 
> voting while copying vs running while tombstoned, since if a server restarts 
> with a tombstoned tablet its consensus state will be "Initializing" just like 
> a copying tablet's, so maybe it's not so useful.

Ah, of course you're right. But wouldn't my suggested change still work in that 
case?


--
To view, visit http://gerrit.cloudera.org:8080/8666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id604bc6122c4291a27fe4c8543408b5be382742c
Gerrit-Change-Number: 8666
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 30 Nov 2017 21:02:41 +
Gerrit-HasComments: No

[kudu-CR] [KUDU-2214] Voting while tablet copying says "voting while tombstoned"

2017-11-30 Thread Will Berkeley (Code Review) 
Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8666 )

Change subject: [KUDU-2214] Voting while tablet copying says "voting while 
tombstoned"
..


Patch Set 1:

> (1 comment)

OK. But looking at test logs more, it doesn't actually distinguish between 
voting while copying vs running while tombstoned, since if a server restarts 
with a tombstoned tablet its consensus state will be "Initializing" just like a 
copying tablet's, so maybe it's not so useful.


--
To view, visit http://gerrit.cloudera.org:8080/8666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id604bc6122c4291a27fe4c8543408b5be382742c
Gerrit-Change-Number: 8666
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 30 Nov 2017 17:15:47 +
Gerrit-HasComments: No

[kudu-CR] [KUDU-2214] Voting while tablet copying says "voting while tombstoned"

2017-11-28 Thread Mike Percy (Code Review) 
Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8666 )

Change subject: [KUDU-2214] Voting while tablet copying says "voting while 
tombstoned"
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8666/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

http://gerrit.cloudera.org:8080/#/c/8666/1/src/kudu/consensus/raft_consensus.cc@1552
PS1, Line 1552:   LOG_WITH_PREFIX_UNLOCKED(INFO) << Substitute("voting in 
state $0 ", State_Name(state_))
> I'm not sure this is an improvement. Can you give an example of what it loo
Let me restate that. This is likely an improvement but I'm not sure users will 
understand the significance of the message as written. I think the only 
possible states are running or stopped, so perhaps make the message something 
like "voting while consensus is " state_ == kRunning ? "running" : "stopped" or 
something like that?



--
To view, visit http://gerrit.cloudera.org:8080/8666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id604bc6122c4291a27fe4c8543408b5be382742c
Gerrit-Change-Number: 8666
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Wed, 29 Nov 2017 01:21:11 +
Gerrit-HasComments: Yes

[kudu-CR] [KUDU-2214] Voting while tablet copying says "voting while tombstoned"

2017-11-28 Thread Mike Percy (Code Review) 
Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8666 )

Change subject: [KUDU-2214] Voting while tablet copying says "voting while 
tombstoned"
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8666/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

http://gerrit.cloudera.org:8080/#/c/8666/1/src/kudu/consensus/raft_consensus.cc@1552
PS1, Line 1552:   LOG_WITH_PREFIX_UNLOCKED(INFO) << Substitute("voting in 
state $0 ", State_Name(state_))
I'm not sure this is an improvement. Can you give an example of what it looks 
like when voting while tombstoned vs. copying?



--
To view, visit http://gerrit.cloudera.org:8080/8666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id604bc6122c4291a27fe4c8543408b5be382742c
Gerrit-Change-Number: 8666
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Tue, 28 Nov 2017 20:45:10 +
Gerrit-HasComments: Yes

[kudu-CR] [KUDU-2214] Voting while tablet copying says "voting while tombstoned"

2017-11-28 Thread Will Berkeley (Code Review) 
Will Berkeley has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8666


Change subject: [KUDU-2214] Voting while tablet copying says "voting while 
tombstoned"
..

[KUDU-2214] Voting while tablet copying says "voting while tombstoned"

The offending log statement now logs the tablet's consensus state
instead.

Change-Id: Id604bc6122c4291a27fe4c8543408b5be382742c
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/8666/1
--
To view, visit http://gerrit.cloudera.org:8080/8666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id604bc6122c4291a27fe4c8543408b5be382742c
Gerrit-Change-Number: 8666
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley