[kudu-CR] [c++client] performance optimizations

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [c++client] performance optimizations
..


Patch Set 8: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b57fc7355f9f673f30861ec30cb6b48cdf656d2
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [c++client] performance optimizations

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4385

to look at the new patch set (#7).

Change subject: [c++client] performance optimizations
..

[c++client] performance optimizations

The change on Batcher::ComputeDeadlineUnlocked() gave
about 50% boost while running scenarios when timeout for session
operations is not set and small raw (wire) operation size (~100 bytes).
Also, avoid calling std::shared_from_this(KuduSession)
for every scheduled write operation.

Change-Id: I4b57fc7355f9f673f30861ec30cb6b48cdf656d2
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client.cc
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
5 files changed, 45 insertions(+), 51 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/4385/7
-- 
To view, visit http://gerrit.cloudera.org:8080/4385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b57fc7355f9f673f30861ec30cb6b48cdf656d2
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [c++client] performance optimizations

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4385

to look at the new patch set (#6).

Change subject: [c++client] performance optimizations
..

[c++client] performance optimizations

The change on Batcher::ComputeDeadlineUnlocked() gave
about 50% boost while running scenarios when timeout for session
operations is not set and small raw (wire) operation size (~100 bytes).
Also, avoid calling std::shared_from_this(KuduSession)
for every scheduled write operation.

Change-Id: I4b57fc7355f9f673f30861ec30cb6b48cdf656d2
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client.cc
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
5 files changed, 38 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/4385/6
-- 
To view, visit http://gerrit.cloudera.org:8080/4385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b57fc7355f9f673f30861ec30cb6b48cdf656d2
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon