[kudu-CR] [client] Improve message when setting a decimal on a non-decimal column
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12433 ) Change subject: [client] Improve message when setting a decimal on a non-decimal column .. [client] Improve message when setting a decimal on a non-decimal column This patch improves the error messaging when setting a decimal on a non-decimal column. Changes the order of validation operations to first check the column type is valid before checking the value is in range. Change-Id: I331028c3ce88e54eef0a091c0cc98b39293fb3c1 Reviewed-on: http://gerrit.cloudera.org:8080/12433 Tested-by: Grant Henke Reviewed-by: Andrew Wong --- M src/kudu/client/scan_batch.cc M src/kudu/common/partial_row-test.cc M src/kudu/common/partial_row.cc 3 files changed, 19 insertions(+), 6 deletions(-) Approvals: Grant Henke: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I331028c3ce88e54eef0a091c0cc98b39293fb3c1 Gerrit-Change-Number: 12433 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [client] Improve message when setting a decimal on a non-decimal column
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12433 ) Change subject: [client] Improve message when setting a decimal on a non-decimal column .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I331028c3ce88e54eef0a091c0cc98b39293fb3c1 Gerrit-Change-Number: 12433 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 11 Feb 2019 18:36:27 + Gerrit-HasComments: No
[kudu-CR] [client] Improve message when setting a decimal on a non-decimal column
Grant Henke has removed a vote on this change. Change subject: [client] Improve message when setting a decimal on a non-decimal column .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I331028c3ce88e54eef0a091c0cc98b39293fb3c1 Gerrit-Change-Number: 12433 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [client] Improve message when setting a decimal on a non-decimal column
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12433 ) Change subject: [client] Improve message when setting a decimal on a non-decimal column .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I331028c3ce88e54eef0a091c0cc98b39293fb3c1 Gerrit-Change-Number: 12433 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 11 Feb 2019 18:05:56 + Gerrit-HasComments: No
[kudu-CR] [client] Improve message when setting a decimal on a non-decimal column
Hello Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12433 to look at the new patch set (#2). Change subject: [client] Improve message when setting a decimal on a non-decimal column .. [client] Improve message when setting a decimal on a non-decimal column This patch improves the error messaging when setting a decimal on a non-decimal column. Changes the order of validation operations to first check the column type is valid before checking the value is in range. Change-Id: I331028c3ce88e54eef0a091c0cc98b39293fb3c1 --- M src/kudu/client/scan_batch.cc M src/kudu/common/partial_row-test.cc M src/kudu/common/partial_row.cc 3 files changed, 19 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/12433/2 -- To view, visit http://gerrit.cloudera.org:8080/12433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I331028c3ce88e54eef0a091c0cc98b39293fb3c1 Gerrit-Change-Number: 12433 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [client] Improve message when setting a decimal on a non-decimal column
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12433 ) Change subject: [client] Improve message when setting a decimal on a non-decimal column .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I331028c3ce88e54eef0a091c0cc98b39293fb3c1 Gerrit-Change-Number: 12433 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 11 Feb 2019 17:17:10 + Gerrit-HasComments: No
[kudu-CR] [client] Improve message when setting a decimal on a non-decimal column
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12433 Change subject: [client] Improve message when setting a decimal on a non-decimal column .. [client] Improve message when setting a decimal on a non-decimal column This patch improves the error messaging when setting a decimal on a non-decimal column. Changes the order of validation operations to first check the column type is valid before checking the value is in range. Change-Id: I331028c3ce88e54eef0a091c0cc98b39293fb3c1 --- M src/kudu/client/scan_batch.cc M src/kudu/common/partial_row-test.cc M src/kudu/common/partial_row.cc 3 files changed, 18 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/12433/1 -- To view, visit http://gerrit.cloudera.org:8080/12433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I331028c3ce88e54eef0a091c0cc98b39293fb3c1 Gerrit-Change-Number: 12433 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
