[kudu-CR] [cmake] add project(Kudu) to avoid warning
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15354 ) Change subject: [cmake] add project(Kudu) to avoid warning .. [cmake] add project(Kudu) to avoid warning Once switching to cmake 3.16.4, the following warning started to appear (at least when building on Ubuntu 18.04): No project() command is present. The top-level CMakeLists.txt file must contain a literal, direct call to the project() command. Add a line of code such as project(ProjectName) near the top of the file, but after cmake_minimum_required(). CMake is pretending there is a "project(Project)" command on the first line. This patch adds project() command, exactly as instructed. Change-Id: Ie8ac913520644690561af073609d58ac320faa51 Reviewed-on: http://gerrit.cloudera.org:8080/15354 Tested-by: Kudu Jenkins Reviewed-by: Bankim Bhavsar Reviewed-by: Andrew Wong --- M CMakeLists.txt 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified Bankim Bhavsar: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie8ac913520644690561af073609d58ac320faa51 Gerrit-Change-Number: 15354 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin
[kudu-CR] [cmake] add project(Kudu) to avoid warning
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15354 ) Change subject: [cmake] add project(Kudu) to avoid warning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8ac913520644690561af073609d58ac320faa51 Gerrit-Change-Number: 15354 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Wed, 04 Mar 2020 00:21:34 + Gerrit-HasComments: No
[kudu-CR] [cmake] add project(Kudu) to avoid warning
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15354 ) Change subject: [cmake] add project(Kudu) to avoid warning .. Patch Set 1: Code-Review+1 Thanks for fixing! -- To view, visit http://gerrit.cloudera.org:8080/15354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8ac913520644690561af073609d58ac320faa51 Gerrit-Change-Number: 15354 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin Gerrit-Comment-Date: Wed, 04 Mar 2020 00:09:41 + Gerrit-HasComments: No
[kudu-CR] [cmake] add project(Kudu) to avoid warning
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15354 Change subject: [cmake] add project(Kudu) to avoid warning .. [cmake] add project(Kudu) to avoid warning Once switching to cmake 3.16.4, the following warning started to appear (at least when building on Ubuntu 18.04): No project() command is present. The top-level CMakeLists.txt file must contain a literal, direct call to the project() command. Add a line of code such as project(ProjectName) near the top of the file, but after cmake_minimum_required(). CMake is pretending there is a "project(Project)" command on the first line. This patch adds project() command, exactly as instructed. Change-Id: Ie8ac913520644690561af073609d58ac320faa51 --- M CMakeLists.txt 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/15354/1 -- To view, visit http://gerrit.cloudera.org:8080/15354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie8ac913520644690561af073609d58ac320faa51 Gerrit-Change-Number: 15354 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
