[kudu-CR] [cmake] place all DATA FILES under bin/testdata
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11841 ) Change subject: [cmake] place all DATA_FILES under bin/testdata .. [cmake] place all DATA_FILES under bin/testdata Updated the convention for the DATA_FILES parameter of the ADD_KUDU_TEST macro. With this patch, all test data files are placed under the /bin/testdata directory after running cmake. The new convention eases the restrictions on the layout of the source data files. That, in its turn, helps to stop duplicating auxiliary files needed for various tests. Change-Id: I75064c6bcf9a569648b922b55f539730769cdf4c Reviewed-on: http://gerrit.cloudera.org:8080/11841 Reviewed-by: Adar Dembo Tested-by: Alexey Serbin --- M CMakeLists.txt M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/master/CMakeLists.txt D src/kudu/master/testdata/first_argument.sh M src/kudu/mini-cluster/external_mini_cluster.cc R src/kudu/scripts/assign-location.py R src/kudu/scripts/first_argument.sh M src/kudu/tablet/compaction_policy-test.cc M src/kudu/tools/CMakeLists.txt D src/kudu/tools/testdata/first_argument.sh 11 files changed, 19 insertions(+), 66 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/11841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I75064c6bcf9a569648b922b55f539730769cdf4c Gerrit-Change-Number: 11841 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin
[kudu-CR] [cmake] place all DATA FILES under bin/testdata
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11841 ) Change subject: [cmake] place all DATA_FILES under bin/testdata .. Patch Set 2: Verified+1 Unrelated fluke in TSAN build -- To view, visit http://gerrit.cloudera.org:8080/11841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75064c6bcf9a569648b922b55f539730769cdf4c Gerrit-Change-Number: 11841 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Comment-Date: Thu, 01 Nov 2018 01:54:01 + Gerrit-HasComments: No
[kudu-CR] [cmake] place all DATA FILES under bin/testdata
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11841 ) Change subject: [cmake] place all DATA_FILES under bin/testdata .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I75064c6bcf9a569648b922b55f539730769cdf4c Gerrit-Change-Number: 11841 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin
[kudu-CR] [cmake] place all DATA FILES under bin/testdata
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11841 ) Change subject: [cmake] place all DATA_FILES under bin/testdata .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75064c6bcf9a569648b922b55f539730769cdf4c Gerrit-Change-Number: 11841 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 31 Oct 2018 23:31:37 + Gerrit-HasComments: No
[kudu-CR] [cmake] place all DATA FILES under bin/testdata
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11841 to look at the new patch set (#2). Change subject: [cmake] place all DATA_FILES under bin/testdata .. [cmake] place all DATA_FILES under bin/testdata Updated the convention for the DATA_FILES parameter of the ADD_KUDU_TEST macro. With this patch, all test data files are placed under the /bin/testdata directory after running cmake. The new convention eases the restrictions on the layout of the source data files. That, in its turn, helps to stop duplicating auxiliary files needed for various tests. Change-Id: I75064c6bcf9a569648b922b55f539730769cdf4c --- M CMakeLists.txt M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/master/CMakeLists.txt D src/kudu/master/testdata/first_argument.sh M src/kudu/mini-cluster/external_mini_cluster.cc R src/kudu/scripts/assign-location.py R src/kudu/scripts/first_argument.sh M src/kudu/tablet/compaction_policy-test.cc M src/kudu/tools/CMakeLists.txt D src/kudu/tools/testdata/first_argument.sh 11 files changed, 19 insertions(+), 66 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/11841/2 -- To view, visit http://gerrit.cloudera.org:8080/11841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I75064c6bcf9a569648b922b55f539730769cdf4c Gerrit-Change-Number: 11841 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [cmake] place all DATA FILES under bin/testdata
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11841 ) Change subject: [cmake] place all DATA_FILES under bin/testdata .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11841/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11841/1//COMMIT_MSG@7 PS1, Line 7: DATA_FILE > Nit: DATA_FILES Done http://gerrit.cloudera.org:8080/#/c/11841/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/11841/1/CMakeLists.txt@834 PS1, Line 834: set(DATA_FILE_LIST "") > I think set(DATA_FILES_LIST) suffices. Done -- To view, visit http://gerrit.cloudera.org:8080/11841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75064c6bcf9a569648b922b55f539730769cdf4c Gerrit-Change-Number: 11841 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 31 Oct 2018 23:28:23 + Gerrit-HasComments: Yes
