[kudu-CR] [consensus queue] the leader is always a viable voter

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8709 )

Change subject: [consensus_queue] the leader is always a viable voter
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 01 Dec 2017 04:39:17 +
Gerrit-HasComments: No

[kudu-CR] [consensus queue] the leader is always a viable voter

[Alexey Serbin (Code Review)]

Hello Mike Percy, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8709

to look at the new patch set (#3).

Change subject: [consensus_queue] the leader is always a viable voter
..

[consensus_queue] the leader is always a viable voter

While iterating over peers in PeerMessageQueue::SafeToEvictUnlocked(),
assume that the leader is always a viable voter.  Prior to this patch,
the leader itself was not counted as a viable voter since the leader
does not update its own last_communication_time.

Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/8709/3
--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [consensus queue] the leader is always a viable voter

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8709 )

Change subject: [consensus_queue] the leader is always a viable voter
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8709/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8709/2//COMMIT_MSG@7
PS2, Line 7: healthy
> nit: can you also call it a viable voter here? In case it gets confused wit
Done



--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 01 Dec 2017 04:02:36 +
Gerrit-HasComments: Yes