[kudu-CR] [java] Fix javadoc issues

[Grant Henke (Code Review)]

Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9839 )

Change subject: [java] Fix javadoc issues
..

[java] Fix javadoc issues

Fixes some javadoc warnings:
- Removed @link and @see to external classes
- Remove invalid @inheritDoc tags
- Fixed code block
- Fixed a couple @return statment

This is far from all of the correctness issue, but the few
that were resulting in Javadoc Gradle errors.

Also disabled the super strict doc linter for Java 8+
in the gradle build to prevent a ton of warning output
and potnetial build failures. We could enable this at
somepoint after we correct the hundreds of warnings.

Change-Id: I5914b416e1b084a4f50dd8ea878be2f065acbe94
Reviewed-on: http://gerrit.cloudera.org:8080/9839
Tested-by: Grant Henke 
Reviewed-by: Adar Dembo 
---
M java/gradle/compile.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
6 files changed, 15 insertions(+), 14 deletions(-)

Approvals:
  Grant Henke: Verified
  Adar Dembo: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/9839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5914b416e1b084a4f50dd8ea878be2f065acbe94
Gerrit-Change-Number: 9839
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java] Fix javadoc issues

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9839 )

Change subject: [java] Fix javadoc issues
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9839/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9839/2//COMMIT_MSG@15
PS2, Line 15: This is far from all of the correctness issue, but the few
: that were resulting in Javadoc Gradle errors.
> Can we convert these errors into precommit build failures so they're caught
The actual errors will fail the build. Though there are less of them now that 
we disable the strict linter.


http://gerrit.cloudera.org:8080/#/c/9839/2/java/gradle/compile.gradle
File java/gradle/compile.gradle:

http://gerrit.cloudera.org:8080/#/c/9839/2/java/gradle/compile.gradle@31
PS2, Line 31: // Disable the super-strict doclint tool in Java 8+
> Hmm, do we do this in the Maven build too? If not, why isn't it necessary?
I didn't investigate why Maven wasn't outputting all the warnings on the cli 
output but just assumed it handled it.

Since you asked I look into it and it turns out the Yetus doclet we are using 
is what suppresses all of the Java 8 doclint warnings. I hadn't setup the 
doclet in gradle yet.

I will look into why the Yetus doclet suppresses them and also into adding the 
doclet to the gradle build.



--
To view, visit http://gerrit.cloudera.org:8080/9839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5914b416e1b084a4f50dd8ea878be2f065acbe94
Gerrit-Change-Number: 9839
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 28 Mar 2018 16:37:07 +
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix javadoc issues

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9839 )

Change subject: [java] Fix javadoc issues
..


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9839/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9839/2//COMMIT_MSG@15
PS2, Line 15: This is far from all of the correctness issue, but the few
: that were resulting in Javadoc Gradle errors.
Can we convert these errors into precommit build failures so they're caught 
when introduced?


http://gerrit.cloudera.org:8080/#/c/9839/2/java/gradle/compile.gradle
File java/gradle/compile.gradle:

http://gerrit.cloudera.org:8080/#/c/9839/2/java/gradle/compile.gradle@31
PS2, Line 31: // Disable the super-strict doclint tool in Java 8+
Hmm, do we do this in the Maven build too? If not, why isn't it necessary?



--
To view, visit http://gerrit.cloudera.org:8080/9839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5914b416e1b084a4f50dd8ea878be2f065acbe94
Gerrit-Change-Number: 9839
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 28 Mar 2018 16:07:59 +
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix javadoc issues

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9839 )

Change subject: [java] Fix javadoc issues
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5914b416e1b084a4f50dd8ea878be2f065acbe94
Gerrit-Change-Number: 9839
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 28 Mar 2018 15:58:45 +
Gerrit-HasComments: No

[kudu-CR] [java] Fix javadoc issues

[Grant Henke (Code Review)]

Grant Henke has removed a vote on this change.

Change subject: [java] Fix javadoc issues
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5914b416e1b084a4f50dd8ea878be2f065acbe94
Gerrit-Change-Number: 9839
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java] Fix javadoc issues

[Grant Henke (Code Review)]

Hello Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9839

to look at the new patch set (#2).

Change subject: [java] Fix javadoc issues
..

[java] Fix javadoc issues

Fixes some javadoc warnings:
- Removed @link and @see to external classes
- Remove invalid @inheritDoc tags
- Fixed code block
- Fixed a couple @return statment

This is far from all of the correctness issue, but the few
that were resulting in Javadoc Gradle errors.

Also disabled the super strict doc linter for Java 8+
in the gradle build to prevent a ton of warning output
and potnetial build failures. We could enable this at
somepoint after we correct the hundreds of warnings.

Change-Id: I5914b416e1b084a4f50dd8ea878be2f065acbe94
---
M java/gradle/compile.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
6 files changed, 15 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/9839/2
--
To view, visit http://gerrit.cloudera.org:8080/9839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5914b416e1b084a4f50dd8ea878be2f065acbe94
Gerrit-Change-Number: 9839
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java] Fix javadoc issues

[Grant Henke (Code Review)]

Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9839


Change subject: [java] Fix javadoc issues
..

[java] Fix javadoc issues

Fixes some javadoc warnings:
- Removed @link and @see to external classes
- Remove invalid @inheritDoc tags
- Fixed code block
- Fixed a couple @return statment

This is far from all of the correctness issue, but the few
that were resulting in Javadoc Gradle errors.

Also disabled the super strict doc linter for Java 8+
in the gradle build to prevent a ton of warning output
and potnetial build failures. We could enable this at
somepoint after we correct the hundreds of warnings.

Change-Id: I5914b416e1b084a4f50dd8ea878be2f065acbe94
---
M java/gradle/compile.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableInputFormat.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
6 files changed, 13 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/9839/1
--
To view, visit http://gerrit.cloudera.org:8080/9839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5914b416e1b084a4f50dd8ea878be2f065acbe94
Gerrit-Change-Number: 9839
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke