[kudu-CR] [kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16478 ) Change subject: [kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31 .. [kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31 This patch updates the expected error message in the ToolTest.ClusterNameResolverFileCorrupt scenario to make the test pass on Ubuntu 20.04 LTS (it should fix it on other platforms which use newer glibc versions). Without this patch, the scenario failed on Ubuntu 20.04 LTS: src/kudu/tools/kudu-tool-test.cc:637: Failure Value of: stderr Expected: has substring "Network error: Could not connect to the cluster: unable to resolve address for bad: Name or service not known" Actual: "W0919 23:39:50.032436 1041101 flags.cc:405] Enabled unsafe flag: --openssl_security_level_override=0\nW0919 23:39:50.032559 1041101 flags.cc:405] Enabled unsafe flag: --never_fsync=true\nNetwork error: Could not connect to the cluster: unable to resolve address for bad: Temporary failure in name resolution" Instead of tailoring the errno-converted message for every platform, it's easier to rely in the essential part of it that corresponds to the DNS resolver failure. In addition, I did a minor cleanup on the code around, removing calls of the Substitute() function where a fixed string is enough. Change-Id: I3eb0991cb2d4311051e55e231cb4fe6d065aa632 Reviewed-on: http://gerrit.cloudera.org:8080/16478 Tested-by: Kudu Jenkins Reviewed-by: Grant Henke --- M src/kudu/tools/kudu-tool-test.cc 1 file changed, 4 insertions(+), 9 deletions(-) Approvals: Kudu Jenkins: Verified Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3eb0991cb2d4311051e55e231cb4fe6d065aa632 Gerrit-Change-Number: 16478 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16478 ) Change subject: [kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3eb0991cb2d4311051e55e231cb4fe6d065aa632 Gerrit-Change-Number: 16478 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 21 Sep 2020 13:08:52 + Gerrit-HasComments: No
[kudu-CR] [kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16478 Change subject: [kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31 .. [kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31 This patch updates the expected error message in the ToolTest.ClusterNameResolverFileCorrupt scenario to make the test pass on Ubuntu 20.04 LTS (it should fix it on other platforms which use newer glibc versions). Without this patch, the scenario failed on Ubuntu 20.04 LTS: src/kudu/tools/kudu-tool-test.cc:637: Failure Value of: stderr Expected: has substring "Network error: Could not connect to the cluster: unable to resolve address for bad: Name or service not known" Actual: "W0919 23:39:50.032436 1041101 flags.cc:405] Enabled unsafe flag: --openssl_security_level_override=0\nW0919 23:39:50.032559 1041101 flags.cc:405] Enabled unsafe flag: --never_fsync=true\nNetwork error: Could not connect to the cluster: unable to resolve address for bad: Temporary failure in name resolution" Instead of tailoring the errno-converted message for every platform, it's easier to rely in the essential part of it that corresponds to the DNS resolver failure. In addition, I did a minor cleanup on the code around, removing calls of the Substitute() function where a fixed string is enough. Change-Id: I3eb0991cb2d4311051e55e231cb4fe6d065aa632 --- M src/kudu/tools/kudu-tool-test.cc 1 file changed, 4 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/16478/1 -- To view, visit http://gerrit.cloudera.org:8080/16478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3eb0991cb2d4311051e55e231cb4fe6d065aa632 Gerrit-Change-Number: 16478 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
