[kudu-CR] [python] - Expand gitignore for python

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: [python] - Expand gitignore for python
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [python] - Expand gitignore for python

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged.

Change subject: [python] - Expand gitignore for python
..


[python] - Expand gitignore for python

Adding additional exclusion rules for python to .gitignore.

Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
Reviewed-on: http://gerrit.cloudera.org:8080/4616
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M python/.gitignore
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [python] - Expand gitignore for python

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: [python] - Expand gitignore for python
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4616/1/.gitignore
File .gitignore:

> Since all of this stuff is rooted in python/, can you make a second .gitign
Done


Line 74
> How could egg files leak out of the python subdirectory? That seems like so
My mistake, not happening, also moved to the python gitignore


-- 
To view, visit http://gerrit.cloudera.org:8080/4616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [python] - Expand gitignore for python

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4616

to look at the new patch set (#2).

Change subject: [python] - Expand gitignore for python
..

[python] - Expand gitignore for python

Adding additional exclusion rules for python to .gitignore.

Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
---
M python/.gitignore
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/4616/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [python] - Expand gitignore for python

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4616

Change subject: [python] - Expand gitignore for python
..

[python] - Expand gitignore for python

Adding additional exclusion rules for python to .gitignore.

Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
---
M .gitignore
1 file changed, 24 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/4616/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell