[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17281 ) Change subject: [python] KUDU-1884 Make SASL protocol configurable .. [python] KUDU-1884 Make SASL protocol configurable Similar to the C++ and Java clients in previous commits, this patch adds support for configuring sasl_protocol_name in the Python client to match the server-side Kerberos service principal name. Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 Reviewed-on: http://gerrit.cloudera.org:8080/17281 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin Reviewed-by: Grant Henke --- M python/kudu/client.pyx M python/kudu/libkudu_client.pxd 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 Gerrit-Change-Number: 17281 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17281 ) Change subject: [python] KUDU-1884 Make SASL protocol configurable .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 Gerrit-Change-Number: 17281 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 09 Apr 2021 13:51:23 + Gerrit-HasComments: No
[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17281 ) Change subject: [python] KUDU-1884 Make SASL protocol configurable .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 Gerrit-Change-Number: 17281 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 08 Apr 2021 21:36:44 + Gerrit-HasComments: No
[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17281 to look at the new patch set (#4). Change subject: [python] KUDU-1884 Make SASL protocol configurable .. [python] KUDU-1884 Make SASL protocol configurable Similar to the C++ and Java clients in previous commits, this patch adds support for configuring sasl_protocol_name in the Python client to match the server-side Kerberos service principal name. Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 --- M python/kudu/client.pyx M python/kudu/libkudu_client.pxd 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/17281/4 -- To view, visit http://gerrit.cloudera.org:8080/17281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 Gerrit-Change-Number: 17281 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17281 ) Change subject: [python] KUDU-1884 Make SASL protocol configurable .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17281/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17281/2//COMMIT_MSG@11 PS2, Line 11: princip > typo: principal Done http://gerrit.cloudera.org:8080/#/c/17281/2//COMMIT_MSG@11 PS2, Line 11: Kerbero > typo: Kerberos Done http://gerrit.cloudera.org:8080/#/c/17281/2/python/kudu/libkudu_client.pxd File python/kudu/libkudu_client.pxd: http://gerrit.cloudera.org:8080/#/c/17281/2/python/kudu/libkudu_client.pxd@580 PS2, Line 580: sasl_proto_name > Maybe, name this 'sasl_protocol_name' to match Java client as in https://ge this matches the underlying C++ API -- To view, visit http://gerrit.cloudera.org:8080/17281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 Gerrit-Change-Number: 17281 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 08 Apr 2021 11:52:36 + Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17281 to look at the new patch set (#3). Change subject: [python] KUDU-1884 Make SASL protocol configurable .. [python] KUDU-1884 Make SASL protocol configurable Similar to the C++ and Java clients in previous commits, this patch adds support for configuring sasl_proto_name in the Python client to match the server-side Kerberos service principal name. Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 --- M python/kudu/client.pyx M python/kudu/libkudu_client.pxd 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/17281/3 -- To view, visit http://gerrit.cloudera.org:8080/17281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 Gerrit-Change-Number: 17281 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17281 ) Change subject: [python] KUDU-1884 Make SASL protocol configurable .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17281/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17281/2//COMMIT_MSG@11 PS2, Line 11: Keberos typo: Kerberos http://gerrit.cloudera.org:8080/#/c/17281/2//COMMIT_MSG@11 PS2, Line 11: princial typo: principal http://gerrit.cloudera.org:8080/#/c/17281/2/python/kudu/libkudu_client.pxd File python/kudu/libkudu_client.pxd: http://gerrit.cloudera.org:8080/#/c/17281/2/python/kudu/libkudu_client.pxd@580 PS2, Line 580: sasl_proto_name Maybe, name this 'sasl_protocol_name' to match Java client as in https://gerrit.cloudera.org/#/c/17280/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2904 -- To view, visit http://gerrit.cloudera.org:8080/17281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 Gerrit-Change-Number: 17281 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Apr 2021 21:39:08 + Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable
Attila Bukor has removed a vote on this change. Change subject: [python] KUDU-1884 Make SASL protocol configurable .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 Gerrit-Change-Number: 17281 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17281 ) Change subject: [python] KUDU-1884 Make SASL protocol configurable .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 Gerrit-Change-Number: 17281 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Apr 2021 17:17:40 + Gerrit-HasComments: No
[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17281 ) Change subject: [python] KUDU-1884 Make SASL protocol configurable .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 Gerrit-Change-Number: 17281 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Apr 2021 14:14:31 + Gerrit-HasComments: No
[kudu-CR] [python] KUDU-1884 Make SASL protocol configurable
Hello Alexey Serbin, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/17281 to review the following change. Change subject: [python] KUDU-1884 Make SASL protocol configurable .. [python] KUDU-1884 Make SASL protocol configurable Similar to the C++ and Java clients in previous commits, this patch adds support for configuring sasl_proto_name in the Python client to match the server-side Keberos service princial name. Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 --- M python/kudu/client.pyx M python/kudu/libkudu_client.pxd 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/17281/1 -- To view, visit http://gerrit.cloudera.org:8080/17281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iddff06c1a4cc2d07a9bbd08bf03d7c863aa6a645 Gerrit-Change-Number: 17281 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke
