[kudu-CR] [tests] fix flakiness in TestSpaceAvailableMetrics

2023-12-19 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20821 )

Change subject: [tests] fix flakiness in TestSpaceAvailableMetrics
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/20821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec10ca3d19aa5e378cebd3ceef6368496797229f
Gerrit-Change-Number: 20821
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Abhishek Chennaka 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Dec 2023 07:12:50 +
Gerrit-HasComments: No


[kudu-CR] [tests] fix flakiness in TestSpaceAvailableMetrics

2023-12-19 Thread Abhishek Chennaka (Code Review)
Abhishek Chennaka has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/20821 )

Change subject: [tests] fix flakiness in TestSpaceAvailableMetrics
..

[tests] fix flakiness in TestSpaceAvailableMetrics

I saw TabletServerDiskErrorITest.TestSpaceAvailableMetrics failing
with an error like below in a pre-commit test run [1] (TSAN build):

  src/kudu/integration-tests/disk_failure-itest.cc:352: Failure
  Expected equality of these values:
wal_dir_space
  Which is: 40835236209
wal_dir_space_refetch
  Which is: 40767713649

This patch addresses the issue.

[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1703028347.1027630

Change-Id: Iec10ca3d19aa5e378cebd3ceef6368496797229f
Reviewed-on: http://gerrit.cloudera.org:8080/20821
Tested-by: Alexey Serbin 
Reviewed-by: Abhishek Chennaka 
---
M src/kudu/integration-tests/disk_failure-itest.cc
1 file changed, 29 insertions(+), 17 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Abhishek Chennaka: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/20821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec10ca3d19aa5e378cebd3ceef6368496797229f
Gerrit-Change-Number: 20821
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Abhishek Chennaka 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] [tests] fix flakiness in TestSpaceAvailableMetrics

2023-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change.

Change subject: [tests] fix flakiness in TestSpaceAvailableMetrics
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iec10ca3d19aa5e378cebd3ceef6368496797229f
Gerrit-Change-Number: 20821
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Abhishek Chennaka 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] [tests] fix flakiness in TestSpaceAvailableMetrics

2023-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20821 )

Change subject: [tests] fix flakiness in TestSpaceAvailableMetrics
..


Patch Set 1: Verified+1

unrelated test failure in 
MultiServerTxnStatusTableITest.TestSystemClientLeadershipChange (ASAN)


--
To view, visit http://gerrit.cloudera.org:8080/20821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec10ca3d19aa5e378cebd3ceef6368496797229f
Gerrit-Change-Number: 20821
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Abhishek Chennaka 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Dec 2023 04:35:16 +
Gerrit-HasComments: No


[kudu-CR] [tests] fix flakiness in TestSpaceAvailableMetrics

2023-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/20821


Change subject: [tests] fix flakiness in TestSpaceAvailableMetrics
..

[tests] fix flakiness in TestSpaceAvailableMetrics

I saw TabletServerDiskErrorITest.TestSpaceAvailableMetrics failing
with an error like below in a pre-commit test run [1] (TSAN build):

  src/kudu/integration-tests/disk_failure-itest.cc:352: Failure
  Expected equality of these values:
wal_dir_space
  Which is: 40835236209
wal_dir_space_refetch
  Which is: 40767713649

This patch addresses the issue.

[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1703028347.1027630

Change-Id: Iec10ca3d19aa5e378cebd3ceef6368496797229f
---
M src/kudu/integration-tests/disk_failure-itest.cc
1 file changed, 29 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/20821/1
--
To view, visit http://gerrit.cloudera.org:8080/20821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec10ca3d19aa5e378cebd3ceef6368496797229f
Gerrit-Change-Number: 20821
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin