[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

[Alexey Serbin (Code Review)]

Alexey Serbin has submitted this change and it was merged.

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..


[twitter-demo] use AUTO_FLUSH_BACKGROUND session

Changed the twitter demo application to use AUTO_FLUSH_BACKGROUND
flush mode instead of MANUAL_FLUSH mode.

Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Reviewed-on: http://gerrit.cloudera.org:8080/4477
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves 
---
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
3 files changed, 61 insertions(+), 115 deletions(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..


Patch Set 5:

nah, that all I wanted. thanks

-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4477

to look at the new patch set (#5).

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..

[twitter-demo] use AUTO_FLUSH_BACKGROUND session

Changed the twitter demo application to use AUTO_FLUSH_BACKGROUND
flush mode instead of MANUAL_FLUSH mode.

Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
---
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
3 files changed, 61 insertions(+), 115 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4477/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4477

to look at the new patch set (#4).

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..

[twitter-demo] use AUTO_FLUSH_BACKGROUND session

Changed the twitter demo application to use AUTO_FLUSH_BACKGROUND
flush mode instead of MANUAL_FLUSH mode.

Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
---
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
3 files changed, 59 insertions(+), 115 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4477/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..


Patch Set 3:

> did you test this manually? I'm not sure whether jenkins even
 > builds this (needs oauth) and pretty sure there are no tests.

Yes, sure -- I built it on MacOS X (installed liboauth from ports).  It worked 
for me.

Or you mentioned running that demo app?  I haven't tried to run that.  Will try 
to do that.

-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..


Patch Set 3:

did you test this manually? I'm not sure whether jenkins even builds this 
(needs oauth) and pretty sure there are no tests.

-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4477

to look at the new patch set (#2).

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND
..

[twitter-demo] use AUTO_FLUSH_BACKGROUND

Changed the twitter demo application to use sessions in
AUTO_FLUSH_BACKGROUND instead of sessions in MANUAL_FLUSH mode.

Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
---
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
3 files changed, 57 insertions(+), 113 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4477/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot