[kudu-CR] Fix missing @Override annotations

2018-04-26 Thread Todd Lipcon (Code Review) 
Todd Lipcon has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10193 )

Change subject: Fix missing @Override annotations
..

Fix missing @Override annotations

This fixes a bunch of error-prone warnings. Generated the patch by
running:

./gradlew clean compileTestJava -Derrorprone-fix=MissingOverride
git diff --name-only | xargs perl -p -i  -e 's,^(\s+)(\@Override) ,\1\2\n\1,g'

(the perl script was necessary to conform to our style)

Change-Id: I7cc822d4c620b74eaaa45b0ed9546659684b3ba8
Reviewed-on: http://gerrit.cloudera.org:8080/10193
Reviewed-by: Grant Henke 
Tested-by: Todd Lipcon 
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeadlineTracker.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/PleaseThrottleException.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Statistics.java
M java/kudu-client/src/main/java/org/apache/kudu/util/Slice.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduOperationsProducer.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
16 files changed, 46 insertions(+), 0 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Todd Lipcon: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cc822d4c620b74eaaa45b0ed9546659684b3ba8
Gerrit-Change-Number: 10193
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Fix missing @Override annotations

2018-04-26 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10193 )

Change subject: Fix missing @Override annotations
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cc822d4c620b74eaaa45b0ed9546659684b3ba8
Gerrit-Change-Number: 10193
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 26 Apr 2018 18:20:20 +
Gerrit-HasComments: No

[kudu-CR] Fix missing @Override annotations

2018-04-26 Thread Todd Lipcon (Code Review) 
Todd Lipcon has removed a vote on this change.

Change subject: Fix missing @Override annotations
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7cc822d4c620b74eaaa45b0ed9546659684b3ba8
Gerrit-Change-Number: 10193
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Fix missing @Override annotations

2018-04-26 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10193 )

Change subject: Fix missing @Override annotations
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cc822d4c620b74eaaa45b0ed9546659684b3ba8
Gerrit-Change-Number: 10193
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Apr 2018 14:25:58 +
Gerrit-HasComments: No

[kudu-CR] Fix missing @Override annotations

2018-04-25 Thread Todd Lipcon (Code Review) 
Hello Grant Henke,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10193

to review the following change.


Change subject: Fix missing @Override annotations
..

Fix missing @Override annotations

This fixes a bunch of error-prone warnings. Generated the patch by
running:

./gradlew clean compileTestJava -Derrorprone-fix=MissingOverride
git diff --name-only | xargs perl -p -i  -e 's,^(\s+)(\@Override) ,\1\2\n\1,g'

(the perl script was necessary to conform to our style)

Change-Id: I7cc822d4c620b74eaaa45b0ed9546659684b3ba8
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/DeadlineTracker.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/PleaseThrottleException.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Statistics.java
M java/kudu-client/src/main/java/org/apache/kudu/util/Slice.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduOperationsProducer.java
M 
java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
16 files changed, 46 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/10193/1
--
To view, visit http://gerrit.cloudera.org:8080/10193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cc822d4c620b74eaaa45b0ed9546659684b3ba8
Gerrit-Change-Number: 10193
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Grant Henke