[kudu-CR] Introduce samples directory
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9837 ) Change subject: Introduce samples directory .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9837/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9837/1//COMMIT_MSG@7 PS1, Line 7: Introduce samples directory > I know this bike-sheddy, but now is probably the past time to discuss this: +1 -- To view, visit http://gerrit.cloudera.org:8080/9837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e Gerrit-Change-Number: 9837 Gerrit-PatchSet: 1 Gerrit-Owner: Will BerkeleyGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 28 Mar 2018 18:22:54 + Gerrit-HasComments: Yes
[kudu-CR] Introduce samples directory
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9837 ) Change subject: Introduce samples directory .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9837/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9837/1//COMMIT_MSG@7 PS1, Line 7: Introduce samples directory I know this bike-sheddy, but now is probably the past time to discuss this: I'd prefer 'examples' over 'samples'. The latter could be confused with other uses of the word 'sample' (like "statistical sampling"), while the former is unambiguous. -- To view, visit http://gerrit.cloudera.org:8080/9837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e Gerrit-Change-Number: 9837 Gerrit-PatchSet: 1 Gerrit-Owner: Will BerkeleyGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 28 Mar 2018 16:10:33 + Gerrit-HasComments: Yes
[kudu-CR] Introduce samples directory
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9837 Change subject: Introduce samples directory .. Introduce samples directory This introduces the top-level samples directory, which will be for samples of how to use the Kudu clients and integrations. As a first step, I moved the client samples from src/kudu/client/samples to samples/cpp. I also manually verified that the instructions in the README for building the sample application still work. Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e --- R samples/cpp/CMakeLists.txt R samples/cpp/README.adoc R samples/cpp/sample.cc M src/kudu/client/CMakeLists.txt 4 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/9837/1 -- To view, visit http://gerrit.cloudera.org:8080/9837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iceca48771541f95e4f0caf8c098bc85d34aa558e Gerrit-Change-Number: 9837 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley