[kudu-CR] KUDU-1766: Java client partition pruning with MAX VALUE equality predicate fails

2016-11-29 Thread Adar Dembo (Code Review) 
Adar Dembo has submitted this change and it was merged.

Change subject: KUDU-1766: Java client partition pruning with MAX_VALUE 
equality predicate fails
..


KUDU-1766: Java client partition pruning with MAX_VALUE equality predicate fails

The bug orginated in a mistransliteration of the c++ partition pruning
algorithm; the original version has always had the missing if statement:
https://github.com/apache/kudu/blob/53e67e9eb7b4fc940a14a17119041871e80bcc3f/src/kudu/common/key_util.cc#L152-L155

Change-Id: Iad6d00d9f401c510e14709323e7686bfa6d1b449
Reviewed-on: http://gerrit.cloudera.org:8080/5266
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M src/kudu/common/partition_pruner-test.cc
3 files changed, 47 insertions(+), 3 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iad6d00d9f401c510e14709323e7686bfa6d1b449
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-1766: Java client partition pruning with MAX VALUE equality predicate fails

2016-11-29 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: KUDU-1766: Java client partition pruning with MAX_VALUE 
equality predicate fails
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6d00d9f401c510e14709323e7686bfa6d1b449
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1766: Java client partition pruning with MAX VALUE equality predicate fails

2016-11-29 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: KUDU-1766: Java client partition pruning with MAX_VALUE 
equality predicate fails
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5266/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
File 
java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java:

Line 294: // c < MIN
> Do we have this new coverage in the C++ tests already?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6d00d9f401c510e14709323e7686bfa6d1b449
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1766: Java client partition pruning with MAX VALUE equality predicate fails

2016-11-29 Thread Dan Burkert (Code Review) 
Hello Todd Lipcon,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5266

to look at the new patch set (#2).

Change subject: KUDU-1766: Java client partition pruning with MAX_VALUE 
equality predicate fails
..

KUDU-1766: Java client partition pruning with MAX_VALUE equality predicate fails

The bug orginated in a mistransliteration of the c++ partition pruning
algorithm; the original version has always had the missing if statement:
https://github.com/apache/kudu/blob/53e67e9eb7b4fc940a14a17119041871e80bcc3f/src/kudu/common/key_util.cc#L152-L155

Change-Id: Iad6d00d9f401c510e14709323e7686bfa6d1b449
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M src/kudu/common/partition_pruner-test.cc
3 files changed, 47 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/5266/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad6d00d9f401c510e14709323e7686bfa6d1b449
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-1766: Java client partition pruning with MAX VALUE equality predicate fails

2016-11-29 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: KUDU-1766: Java client partition pruning with MAX_VALUE 
equality predicate fails
..


Patch Set 1:

(1 comment)

Just passing through...

http://gerrit.cloudera.org:8080/#/c/5266/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
File 
java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java:

Line 294: // c < MIN
Do we have this new coverage in the C++ tests already?


-- 
To view, visit http://gerrit.cloudera.org:8080/5266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6d00d9f401c510e14709323e7686bfa6d1b449
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1766: Java client partition pruning with MAX VALUE equality predicate fails

2016-11-29 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: KUDU-1766: Java client partition pruning with MAX_VALUE 
equality predicate fails
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6d00d9f401c510e14709323e7686bfa6d1b449
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1766: Java client partition pruning with MAX VALUE equality predicate fails

2016-11-29 Thread Dan Burkert (Code Review) 
Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/5266

to review the following change.

Change subject: KUDU-1766: Java client partition pruning with MAX_VALUE 
equality predicate fails
..

KUDU-1766: Java client partition pruning with MAX_VALUE equality predicate fails

The bug orginated in a mistransliteration of the c++ partition pruning
algorithm; the original version has always had the missing if statement:
https://github.com/apache/kudu/blob/53e67e9eb7b4fc940a14a17119041871e80bcc3f/src/kudu/common/key_util.cc#L152-L155

Change-Id: Iad6d00d9f401c510e14709323e7686bfa6d1b449
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
2 files changed, 26 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/5266/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad6d00d9f401c510e14709323e7686bfa6d1b449
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon