[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Andrew Wong (Code Review)]

Andrew Wong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..

KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log

This improvement removes the double "Could not lock.." and the
double file paths and adds a descriptive message for the cause
of the error.

Before:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock /private/tmp/kudu/data/master/0/1/data/
block_manager_instance: Could not lock /private/tmp/kudu/data/
master/0/1/data/block_manager_instance: lock /private/tmp/kudu/
data/master/0/1/data/block_manager_instance: Resource temporarily
unavailable (error 35)

After:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock block_manager_instance file. Make sure
that Kudu is not already running and you are not trying to run
Kudu with a different user than before: lock /private/tmp/kudu/
data/master/0/1/data/block_manager_instance: Resource temporarily
unavailable (error 35)

Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Reviewed-on: http://gerrit.cloudera.org:8080/10419
Reviewed-by: Andrew Wong 
Tested-by: Andrew Wong 
---
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/data_dirs.cc
2 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Andrew Wong: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 8
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 7: Verified+1 Code-Review+2

Pre-commit failure appears to be KUDU-2444


--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 7
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Mon, 21 May 2018 23:13:11 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Andrew Wong (Code Review)]

Andrew Wong has removed a vote on this change.

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 7
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10419/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/6//COMMIT_MSG@14
PS6, Line 14: Check failed: _s.ok() Bad status: IO error: Failed to load FS
: layout: Could not lock /private/tmp/kudu/data/master/0/1/data/
: block_manager_instance: Could not lock /private/tmp/kudu/data/
: master/0/1/data/block_manager_instance: lock /pri
> This should be what it was in PS4 I think
Opps sorry. Changed it back.



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 7
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Mon, 21 May 2018 22:23:17 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Hello Will Berkeley, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10419

to look at the new patch set (#7).

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..

KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log

This improvement removes the double "Could not lock.." and the
double file paths and adds a descriptive message for the cause
of the error.

Before:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock /private/tmp/kudu/data/master/0/1/data/
block_manager_instance: Could not lock /private/tmp/kudu/data/
master/0/1/data/block_manager_instance: lock /private/tmp/kudu/
data/master/0/1/data/block_manager_instance: Resource temporarily
unavailable (error 35)

After:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock block_manager_instance file. Make sure
that Kudu is not already running and you are not trying to run
Kudu with a different user than before: lock /private/tmp/kudu/
data/master/0/1/data/block_manager_instance: Resource temporarily
unavailable (error 35)

Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
---
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/data_dirs.cc
2 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/10419/7
--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 7
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10419/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/6//COMMIT_MSG@14
PS6, Line 14: Check failed: _s.ok() Bad status: IO error: Failed to load FS
: layout: Could not lock block_manager_instance file: Could not
: lock block_manager_instance file: lock block_manager_instance
: file: Resource temporarily unavailable (error 35)
This should be what it was in PS4 I think



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 6
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Sat, 19 May 2018 01:35:02 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10419/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/5//COMMIT_MSG@22
PS5, Line 22:  a
> Maybe I'm too picky, but this bugs me. Can you rephrase as a statement rath
Done



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 6
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 18 May 2018 20:23:31 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Hello Will Berkeley, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10419

to look at the new patch set (#6).

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..

KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log

This improvement removes the double "Could not lock.." and the
double file paths and adds a descriptive message for the cause
of the error.

Before:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock block_manager_instance file: Could not
lock block_manager_instance file: lock block_manager_instance
file: Resource temporarily unavailable (error 35)

After:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock block_manager_instance file. Make sure
that Kudu is not already running and you are not trying to run
Kudu with a different user than before: lock /private/tmp/kudu/
data/master/0/1/data/block_manager_instance: Resource temporarily
unavailable (error 35)

Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
---
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/data_dirs.cc
2 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/10419/6
--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 6
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG@22
PS4, Line 22: n before?: lock block_manager_instance file: Resource
: temporarily unavailabl
> Oops sorry, I misunderstood your previous comment. So do you mean we don't
Yup.


http://gerrit.cloudera.org:8080/#/c/10419/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/5//COMMIT_MSG@14
PS5, Line 14: Could not
: lock block_manager_instance file: lock block_manager_instance
: file: Resource temporarily unavailable (error 35)
Yeah the filename should be in here.


http://gerrit.cloudera.org:8080/#/c/10419/5//COMMIT_MSG@22
PS5, Line 22: ?:
Maybe I'm too picky, but this bugs me. Can you rephrase as a statement rather 
than a question, i.e. Make sure that...



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 5
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 18 May 2018 16:27:46 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG@22
PS4, Line 22: n before?: lock block_manager_instance file: Resource
: temporarily unavailabl
> Oops sorry, I misunderstood your previous comment. So do you mean we don't
Yep, exactly! Sorry I wasn't clearer.



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 5
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 18 May 2018 16:27:35 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG@22
PS4, Line 22: Could not lock /private/tmp/kudu/data/master/0/2/data/
: block_manager_instance
> I don't see the changes in PS5. Also from PS5's commit message, it seems li
Oops sorry, I misunderstood your previous comment. So do you mean we don't need 
to expose the filename in upper log layer cuz there's lower level log that also 
prints out this filename?

So will the log be like:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock the block_manager_instance. Is Kudu already running or 
are you trying to run Kudu with a different user than before?: lock 
/private/tmp/kudu/data/master/0/2/data/block_manager_instance: 
Resourcetemporarily unavailable (error 35)



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 4
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 18 May 2018 16:18:41 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG@22
PS4, Line 22: n before?: lock block_manager_instance file: Resource
: temporarily unavailabl
> Done
I don't see the changes in PS5. Also from PS5's commit message, it seems like 
you're thinking of also getting rid of the filename reported in env_posix.cc? 
Returning the filename in env_posix.cc seems fine to me, but because we're 
doing that, we don't need to add it further in the other layers.


http://gerrit.cloudera.org:8080/#/c/10419/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/5//COMMIT_MSG@13
PS5, Line 13: Check failed: _s.ok() Bad status: IO error: Failed to load FS
: layout: Could not lock block_manager_instance file: Could not
: lock block_manager_instance file: lock block_manager_instance
: file: Resource temporarily unavailable (error 35)
Mmm this should probably stay as it was :)



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 5
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 18 May 2018 04:04:07 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG@22
PS4, Line 22: Could not lock /private/tmp/kudu/data/master/0/2/data/
: block_manager_instance
> Seems the filename is already a part of the status at an even lower level (
Done



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 4
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 18 May 2018 00:42:57 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Hello Will Berkeley, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10419

to look at the new patch set (#5).

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..

KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log

This improvement removes the double "Could not lock.." and adds
a descriptive message for the cause of the error.

Before:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock block_manager_instance file: Could not
lock block_manager_instance file: lock block_manager_instance
file: Resource temporarily unavailable (error 35)

After:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock block_manager_instance file. Is Kudu
already running or are you trying to run Kudu with a different
user than before?: lock block_manager_instance file: Resource
temporarily unavailable (error 35)

Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
---
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/data_dirs.cc
2 files changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/10419/5
--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 5
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/4//COMMIT_MSG@22
PS4, Line 22: Could not lock /private/tmp/kudu/data/master/0/2/data/
: block_manager_instance
Seems the filename is already a part of the status at an even lower level 
(seems like in env_posix.cc during the call to LockFile()). Since that's the 
case, let's just change this to "could not lock block_manager_instance file" or 
something.



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 4
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 18 May 2018 00:32:37 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10419/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/2//COMMIT_MSG@8
PS2, Line 8:
> nit: I think it'd be helpful (if anything, just as a sanity check) to see a
Good point. Thanks.



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 4
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 17 May 2018 21:18:12 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Hello Will Berkeley, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10419

to look at the new patch set (#4).

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..

KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log

This improvement removes the double "Could not lock.." and adds
a descriptive message for the cause of the error.

Before:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock /private/tmp/kudu/data/master/0/1/data/
block_manager_instance: Could not lock /private/tmp/kudu/data/
master/0/1/data/block_manager_instance: lock /private/tmp/kudu/
data/master/0/1/data/block_manager_instance: Resource temporarily
unavailable (error 35)

After:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock /private/tmp/kudu/data/master/0/2/data/
block_manager_instance. Is Kudu already running or are you trying
to run Kudu with a different user than before?: lock /private/tmp/
kudu/data/master/0/2/data/block_manager_instance: Resource
temporarily unavailable (error 35)

Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
---
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/data_dirs.cc
2 files changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/10419/4
--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 4
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Hello Will Berkeley, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10419

to look at the new patch set (#3).

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..

KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log

Before:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock /private/tmp/kudu/data/master/0/1/data/
block_manager_instance: Could not lock /private/tmp/kudu/data/
master/0/1/data/block_manager_instance: lock /private/tmp/kudu/
data/master/0/1/data/block_manager_instance: Resource temporarily
unavailable (error 35)

After:
Check failed: _s.ok() Bad status: IO error: Failed to load FS
layout: Could not lock /private/tmp/kudu/data/master/0/2/data/
block_manager_instance. Is Kudu already running or are you trying
to run Kudu with a different user than before?: lock /private/tmp/
kudu/data/master/0/2/data/block_manager_instance: Resource
temporarily unavailable (error 35)

This improvement removes the double "Could not lock.." and adds
a descriptive message for the cause of the error.

Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
---
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/data_dirs.cc
2 files changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/10419/3
--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 3
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10419/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10419/2//COMMIT_MSG@8
PS2, Line 8:
nit: I think it'd be helpful (if anything, just as a sanity check) to see a 
before and after of the output being changed.



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 17 May 2018 17:37:31 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 2:

Looks pretty good to me. Andrew, do you want to look it over quickly?


--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 17 May 2018 17:28:42 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10419/2/src/kudu/fs/block_manager_util.cc
File src/kudu/fs/block_manager_util.cc:

http://gerrit.cloudera.org:8080/#/c/10419/2/src/kudu/fs/block_manager_util.cc@155
PS2, Line 155: PathInstanceMetadataFile::Lock
It seems to me this is only used by DataDirManager::LoadInstances



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 21:41:05 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Fengling Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10419 )

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..


Patch Set 1:

(1 comment)

After a few ack-greps, I think maybe it's safe to remove the outer "Could not 
lock.." (in data_dirs.cc) and improve the inner "Could not lock.." (in 
block_manager_util.cc). Cuz the these two always come together.

http://gerrit.cloudera.org:8080/#/c/10419/1/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/10419/1/src/kudu/server/server_base.cc@449
PS1, Line 449: Is Kudu already running or are you trying "
 :"to run Kudu with a different user 
than before?
> The Status s comes from fs_manager_->Open, and could be any Status that fun
I see. Thanks.



--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Wed, 16 May 2018 21:38:30 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1867 Improve the "Could not lock .../block manager instance" error log

[Fengling Wang (Code Review)]

Hello Will Berkeley, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10419

to look at the new patch set (#2).

Change subject: KUDU-1867 Improve the "Could not lock 
.../block_manager_instance" error log
..

KUDU-1867 Improve the "Could not lock .../block_manager_instance" error log

Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
---
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/data_dirs.cc
2 files changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/10419/2
--
To view, visit http://gerrit.cloudera.org:8080/10419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c6f078f95b3295e31047b9fe9a5dd643a402ba0
Gerrit-Change-Number: 10419
Gerrit-PatchSet: 2
Gerrit-Owner: Fengling Wang 
Gerrit-Reviewer: Fengling Wang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley